From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D8F017A5BE for ; Fri, 8 Nov 2024 20:52:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731099137; cv=none; b=NC2XLAAu+9p3UBihFnj5byVSbPaIYujCiR0YGcrHN0Umk3D+8fIhyaegK+K0MFYO69wcQTj8IQs/D3KsiR1RuCQdhpnhezJchczEeJa+EcQsw5nPh0aSsHFYv/A5mqvTLw5627JP1YedoyinT+TUlyXJkSnQwM+vKeT1CqPhY3A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731099137; c=relaxed/simple; bh=g2i//UKfIgyqpn5AcF7hv/8fn2kw3ee4/fXPyElQpso=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=t7yHvxO6sOk17LT5CAshaKVi96mCpSYeuq/4jsoaY9/DM8Qdx37KCRABQsR8A2g/T4jeqxI/RXCB21h7kG15cwdG1SMCnloomhuMJtvgS0wW4mxIyqfhPa6phnBrn3Ew4mQJavQhflOc39QgJzfyVtEaj2R7ik/nmgiuHoET6uI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=fail smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=iUq5BV2A; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="iUq5BV2A" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4A8F9pVW000660 for ; Fri, 8 Nov 2024 20:52:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 9rqRqJHdABUGtN1Oa6Wf8KKvgmkCqU/Lt+jAre/pNEQ=; b=iUq5BV2AsFwkwqrz QUnxMq+OFA71mWewKQP7R2It31ZdURgf9SM+oXXiFn8SPtoqG/5dKiVa7XhAQ9eE 1kJpoFivxyMSGwJfclGK0cva3eB9ib5ZU9mSvb7/+iPvQFh9sdtHE5YLIL4wvf/c vr+6w0RANgyuBaJhLhII6/kE1IrTfZpZLsrxIpkacJL7jFy1rS3b9dO9HnHiNAQA 3VMuVyn0AtpCMR0kpzZ/+bH5+dV910H0nHS7dub2ILDuHkOliFGE1+98rLii6VTG +UZUYAAU5yyYQ/PMIEodbXrfIPpDHGfVYMQkY0q3Au/S3rrLSkTlT5ZU4r0Q1EEm Yd9zWw== Received: from mail-io1-f71.google.com (mail-io1-f71.google.com [209.85.166.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 42s6gkakjg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 08 Nov 2024 20:52:09 +0000 (GMT) Received: by mail-io1-f71.google.com with SMTP id ca18e2360f4ac-83ba5dcee51so57547839f.1 for ; Fri, 08 Nov 2024 12:52:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731099128; x=1731703928; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9rqRqJHdABUGtN1Oa6Wf8KKvgmkCqU/Lt+jAre/pNEQ=; b=s8tUQUc6SF/9affE1c/oZfX5hT3RqC/fJcAi+taQPvm9h3JEj0RLJnIJclW72n0Ocl NG7+mMvLQypj9r3/H9ujWcNhjBmlxzAxYU2MZVbYGw0F/spdlo84kwoELaE+/7rKkftq aF+9hEgQUf/8YEOxfIwRFQLy93C7uO8Cr4xT8e8up9kmgyJabBSxXLUNn3RocekFidqe joWw3E7aQlWQN8xb9y/vFkJbnNXE3SHYOg98A+qML3Bg9yQ8v0QlYkNDn5R/0r/fZ7mJ p9Q7+vJh6qMi6kfReLfkxdlZwEiqVpdAkCAU5fLQeOFTcN2bRvqb5/ro1HCCAD8zDaon L4Hg== X-Gm-Message-State: AOJu0Yxe8gGqHFU6pJMxgSiXP30sFzBSGkEdv0NtYLLGOPL1jbD1ID1c Iw7bHOf9bgLFRB1GqQN8fHUaOhIbh6+OWsVmv5Ruz11HI2T9k9c5QvTVkbl652SducM3PmxKMZv Bk4lregkvE2i8AiM5D/a9MpOjcJj00LEVIm9WhUgn0RRlCsyvP5Kpc2vj/gq7Yvw= X-Received: by 2002:a05:6e02:1a82:b0:3a6:c8cf:9d5e with SMTP id e9e14a558f8ab-3a6f1a570ebmr10843595ab.6.1731099128523; Fri, 08 Nov 2024 12:52:08 -0800 (PST) X-Google-Smtp-Source: AGHT+IG0SkFz1RuD5aydeU3vKatb/g3KQgNxDav5jnYzffNXFhUJayuliKzxND2HIbBSn+ua6ypJaQ== X-Received: by 2002:a05:6e02:1a82:b0:3a6:c8cf:9d5e with SMTP id e9e14a558f8ab-3a6f1a570ebmr10843505ab.6.1731099128178; Fri, 08 Nov 2024 12:52:08 -0800 (PST) Received: from [192.168.212.120] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9ee0e2eb28sm275429266b.197.2024.11.08.12.52.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Nov 2024 12:52:06 -0800 (PST) Message-ID: Date: Fri, 8 Nov 2024 21:52:04 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] RFC: arm64: dts: qcom: Disable USB U1/U2 entry for QC targets To: Krishna Kurapati , Krzysztof Kozlowski , Rob Herring , Conor Dooley , Bjorn Andersson , Konrad Dybcio Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, quic_ppratap@quicinc.com, quic_jackp@quicinc.com References: <20241107073650.13473-1-quic_kriskura@quicinc.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20241107073650.13473-1-quic_kriskura@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: 9JrdV4QO2f4wgQ_IIeeYzMPIo7DZb56W X-Proofpoint-ORIG-GUID: 9JrdV4QO2f4wgQ_IIeeYzMPIo7DZb56W X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 mlxlogscore=489 mlxscore=0 clxscore=1015 suspectscore=0 spamscore=0 malwarescore=0 impostorscore=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2409260000 definitions=main-2411080172 On 7.11.2024 8:36 AM, Krishna Kurapati wrote: > Enabling U1 and U2 power-saving states can lead to stability and > performance issues, particularly for latency-sensitive or high- > throughput applications. These low-power link states are intended > to reduce power consumption by allowing the device to enter partial > low-power modes during idle periods. However, they can sometimes > result in unexpected behavior. Over the years, some of the issues > seen are as follows: > > 1. In device mode of operation, when UVC is active, enabling U1/U2 > is sometimes causing packets drops due to delay in entry/exit of > intermittent low power states. These packet drops are often reflected > as Missed Isochronous transfers as the controller was not able to > send the packet in that microframe interval and hence glitches are > seen on the final transmitted video output. > > 2. On QCS6490-Rb3Gen2 Vision kit, ADB connection is heavily unstable > when U1/U2 is enabled. Often when link enters U2, there is a re- > enumeration seen and device is unusable for many use cases. Would be nice to enable it on there too, then ;) Generally per-file commits are preferred to make potential reverts easier down the road Konrad