From: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
To: Rishikesh Donadkar <r-donadkar@ti.com>,
jai.luthra@linux.dev, laurent.pinchart@ideasonboard.com,
mripard@kernel.org
Cc: y-abhilashchandra@ti.com, devarsht@ti.com, s-jain1@ti.com,
vigneshr@ti.com, mchehab@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, p.zabel@pengutronix.de, conor+dt@kernel.org,
sakari.ailus@linux.intel.com, hverkuil-cisco@xs4all.nl,
jai.luthra@ideasonboard.com, changhuang.liang@starfivetech.com,
jack.zhu@starfivetech.com, sjoerd@collabora.com,
dan.carpenter@linaro.org, hverkuil+cisco@kernel.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v8 01/18] media: ti: j721e-csi2rx: Remove word size alignment on frame width
Date: Thu, 20 Nov 2025 13:58:40 +0200 [thread overview]
Message-ID: <f15d1ac0-5f87-4221-8af3-c0aa5a5b29b2@ideasonboard.com> (raw)
In-Reply-To: <20251112115459.2479225-2-r-donadkar@ti.com>
Hi,
On 12/11/2025 13:54, Rishikesh Donadkar wrote:
> j721e-csi2rx driver has a limitation of frame width being a multiple
> word size. However, there is no such limitation imposed by the
> hardware [1].
>
> Remove this limitation from the driver.
>
> Link: https://www.ti.com/lit/pdf/spruj16
> Reviewed-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>
> Signed-off-by: Rishikesh Donadkar <r-donadkar@ti.com>
> ---
> .../platform/ti/j721e-csi2rx/j721e-csi2rx.c | 24 ++++---------------
> 1 file changed, 4 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c b/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c
> index b75aa363d1bf2..710d05a053539 100644
> --- a/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c
> +++ b/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c
> @@ -43,7 +43,6 @@
> #define SHIM_PSI_CFG0_DST_TAG GENMASK(31, 16)
>
> #define TI_CSI2RX_MAX_PIX_PER_CLK 4
> -#define PSIL_WORD_SIZE_BYTES 16
> /*
> * There are no hard limits on the width or height. The DMA engine can handle
> * all sizes. The max width and height are arbitrary numbers for this driver.
> @@ -250,19 +249,12 @@ static void ti_csi2rx_fill_fmt(const struct ti_csi2rx_fmt *csi_fmt,
> struct v4l2_format *v4l2_fmt)
> {
> struct v4l2_pix_format *pix = &v4l2_fmt->fmt.pix;
> - unsigned int pixels_in_word;
> -
> - pixels_in_word = PSIL_WORD_SIZE_BYTES * 8 / csi_fmt->bpp;
>
> /* Clamp width and height to sensible maximums (16K x 16K) */
> pix->width = clamp_t(unsigned int, pix->width,
> - pixels_in_word,
> - MAX_WIDTH_BYTES * 8 / csi_fmt->bpp);
> + 1, MAX_WIDTH_BYTES * 8 / csi_fmt->bpp);
> pix->height = clamp_t(unsigned int, pix->height, 1, MAX_HEIGHT_LINES);
>
> - /* Width should be a multiple of transfer word-size */
> - pix->width = rounddown(pix->width, pixels_in_word);
> -
> v4l2_fmt->type = V4L2_BUF_TYPE_VIDEO_CAPTURE;
> pix->pixelformat = csi_fmt->fourcc;
> pix->bytesperline = pix->width * (csi_fmt->bpp / 8);
> @@ -360,23 +352,15 @@ static int ti_csi2rx_enum_framesizes(struct file *file, void *fh,
> struct v4l2_frmsizeenum *fsize)
> {
> const struct ti_csi2rx_fmt *fmt;
> - unsigned int pixels_in_word;
>
> fmt = find_format_by_fourcc(fsize->pixel_format);
> if (!fmt || fsize->index != 0)
> return -EINVAL;
>
> - /*
> - * Number of pixels in one PSI-L word. The transfer happens in multiples
> - * of PSI-L word sizes.
> - */
> - pixels_in_word = PSIL_WORD_SIZE_BYTES * 8 / fmt->bpp;
> -
> fsize->type = V4L2_FRMSIZE_TYPE_STEPWISE;
> - fsize->stepwise.min_width = pixels_in_word;
> - fsize->stepwise.max_width = rounddown(MAX_WIDTH_BYTES * 8 / fmt->bpp,
> - pixels_in_word);
> - fsize->stepwise.step_width = pixels_in_word;
> + fsize->stepwise.min_width = 1;
> + fsize->stepwise.max_width = MAX_WIDTH_BYTES * 8 / fmt->bpp;
> + fsize->stepwise.step_width = 1;
> fsize->stepwise.min_height = 1;
> fsize->stepwise.max_height = MAX_HEIGHT_LINES;
> fsize->stepwise.step_height = 1;
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Tomi
next prev parent reply other threads:[~2025-11-20 11:58 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-12 11:54 [PATCH v8 00/18] media: cadence,ti: CSI2RX Multistream Support Rishikesh Donadkar
2025-11-12 11:54 ` [PATCH v8 01/18] media: ti: j721e-csi2rx: Remove word size alignment on frame width Rishikesh Donadkar
2025-11-20 11:58 ` Tomi Valkeinen [this message]
2025-11-12 11:54 ` [PATCH v8 02/18] dt-bindings: media: ti,j721e-csi2rx-shim: Support 32 dma chans Rishikesh Donadkar
2025-11-12 11:54 ` [PATCH v8 03/18] media: ti: j721e-csi2rx: separate out device and context Rishikesh Donadkar
2025-11-12 11:54 ` [PATCH v8 04/18] media: ti: j721e-csi2rx: prepare SHIM code for multiple contexts Rishikesh Donadkar
2025-11-12 11:54 ` [PATCH v8 05/18] media: ti: j721e-csi2rx: allocate DMA channel based on context index Rishikesh Donadkar
2025-11-12 11:54 ` [PATCH v8 06/18] media: ti: j721e-csi2rx: add a subdev for the core device Rishikesh Donadkar
2025-11-20 12:39 ` Sakari Ailus
2025-11-21 6:59 ` Rishikesh Donadkar
2025-11-12 11:54 ` [PATCH v8 07/18] media: cadence: csi2rx: Move to .enable/disable_streams API Rishikesh Donadkar
2025-11-20 13:00 ` Tomi Valkeinen
2025-11-21 7:02 ` Rishikesh Donadkar
2025-11-12 11:54 ` [PATCH v8 08/18] media: ti: j721e-csi2rx: " Rishikesh Donadkar
2025-11-20 12:40 ` Sakari Ailus
2025-11-21 7:04 ` Rishikesh Donadkar
2025-11-12 11:54 ` [PATCH v8 09/18] media: ti: j721e-csi2rx: get number of contexts from device tree Rishikesh Donadkar
2025-11-12 11:54 ` [PATCH v8 10/18] media: cadence: csi2rx: add get_frame_desc wrapper Rishikesh Donadkar
2025-11-20 12:40 ` Tomi Valkeinen
2025-12-02 9:03 ` Rishikesh Donadkar
2025-11-12 11:54 ` [PATCH v8 11/18] media: ti: j721e-csi2rx: add support for processing virtual channels Rishikesh Donadkar
2025-11-20 12:32 ` Tomi Valkeinen
2025-12-01 9:25 ` Rishikesh Donadkar
2025-11-12 11:54 ` [PATCH v8 12/18] media: cadence: csi2rx: add multistream support Rishikesh Donadkar
2025-11-20 12:53 ` Sakari Ailus
2025-12-09 9:43 ` Rishikesh Donadkar
2025-12-29 11:14 ` Sakari Ailus
2025-11-20 13:14 ` Tomi Valkeinen
2025-12-09 9:45 ` Rishikesh Donadkar
2025-11-12 11:54 ` [PATCH v8 13/18] media: ti: j721e-csi2rx: " Rishikesh Donadkar
2025-12-01 13:03 ` Tomi Valkeinen
2025-12-09 10:08 ` Rishikesh Donadkar
2025-12-09 10:36 ` Jai Luthra
2025-12-09 11:52 ` Tomi Valkeinen
2025-12-09 12:06 ` Jai Luthra
2025-11-12 11:54 ` [PATCH v8 14/18] media: ti: j721e-csi2rx: Submit all available buffers Rishikesh Donadkar
2025-11-12 11:54 ` [PATCH v8 15/18] media: ti: j721e-csi2rx: Change the drain architecture for multistream Rishikesh Donadkar
2025-11-12 11:54 ` [PATCH v8 16/18] media: cadence: csi2rx: Support runtime PM Rishikesh Donadkar
2025-12-01 13:11 ` Tomi Valkeinen
2025-12-18 5:35 ` Rishikesh Donadkar
2025-11-12 11:54 ` [PATCH v8 17/18] media: ti: j721e-csi2rx: Support runtime suspend Rishikesh Donadkar
2025-11-20 13:16 ` Sakari Ailus
2025-12-08 7:47 ` Jai Luthra
2025-12-08 9:39 ` Sakari Ailus
2025-12-01 13:22 ` Tomi Valkeinen
2025-12-08 7:36 ` Jai Luthra
2025-12-29 10:07 ` Rishikesh Donadkar
2025-11-12 11:54 ` [PATCH v8 18/18] media: ti: j721e-csi2rx: Support system suspend using pm_notifier Rishikesh Donadkar
2025-12-01 13:46 ` Tomi Valkeinen
2025-12-08 8:01 ` Jai Luthra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f15d1ac0-5f87-4221-8af3-c0aa5a5b29b2@ideasonboard.com \
--to=tomi.valkeinen@ideasonboard.com \
--cc=changhuang.liang@starfivetech.com \
--cc=conor+dt@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=devarsht@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil+cisco@kernel.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jack.zhu@starfivetech.com \
--cc=jai.luthra@ideasonboard.com \
--cc=jai.luthra@linux.dev \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mripard@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=r-donadkar@ti.com \
--cc=robh@kernel.org \
--cc=s-jain1@ti.com \
--cc=sakari.ailus@linux.intel.com \
--cc=sjoerd@collabora.com \
--cc=vigneshr@ti.com \
--cc=y-abhilashchandra@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®