Re: [PATCH v6 3/3] riscv: dts: thead: Add mailbox node

[Michal Wilczynski <m.wilczynski@samsung.com>]

On 12/13/24 05:23, Drew Fustini wrote:
> On Thu, Dec 12, 2024 at 06:56:25PM -0800, Drew Fustini wrote:
>> On Wed, Dec 11, 2024 at 02:15:01PM -0800, Drew Fustini wrote:
>>> On Mon, Nov 04, 2024 at 11:07:34AM +0100, Michal Wilczynski wrote:
>>>> Add mailbox device tree node. This work is based on the vendor kernel [1].
>>>>
>>>> Link: https://protect2.fireeye.com/v1/url?k=da478eb3-bbcc9b8a-da4605fc-000babffae10-a5d9fc4237b185e3&q=1&e=465c5302-3d9e-4713-b219-30181e5944c2&u=https%3A%2F%2Fgithub.com%2Frevyos%2Fthead-kernel.git [1]
>>>>
>>>> Signed-off-by: Michal Wilczynski <m.wilczynski@samsung.com>
>>>> ---
>>>>  arch/riscv/boot/dts/thead/th1520.dtsi | 16 ++++++++++++++++
>>>>  1 file changed, 16 insertions(+)
>>>>
>>>> diff --git a/arch/riscv/boot/dts/thead/th1520.dtsi b/arch/riscv/boot/dts/thead/th1520.dtsi
>>>> index 6992060e6a54..89de5634d3d3 100644
>>>> --- a/arch/riscv/boot/dts/thead/th1520.dtsi
>>>> +++ b/arch/riscv/boot/dts/thead/th1520.dtsi
>>>> @@ -520,6 +520,22 @@ timer7: timer@ffffc3303c {
>>>>  			status = "disabled";
>>>>  		};
>>>>  
>>>> +		mbox_910t: mailbox@ffffc38000 {
>>>> +			compatible = "thead,th1520-mbox";
>>>> +			reg = <0xff 0xffc38000 0x0 0x6000>,
>>>> +			      <0xff 0xffc40000 0x0 0x6000>,
>>>> +			      <0xff 0xffc4c000 0x0 0x2000>,
>>>> +			      <0xff 0xffc54000 0x0 0x2000>;
>>>> +			reg-names = "local", "remote-icu0", "remote-icu1", "remote-icu2";
>>>> +			clocks = <&clk CLK_MBOX0>, <&clk CLK_MBOX1>, <&clk CLK_MBOX2>,
>>>> +				 <&clk CLK_MBOX3>;
>>>> +			clock-names = "clk-local", "clk-remote-icu0", "clk-remote-icu1",
>>>> +				      "clk-remote-icu2";
>>>> +			interrupt-parent = <&plic>;
>>>> +			interrupts = <28 IRQ_TYPE_LEVEL_HIGH>;
>>>> +			#mbox-cells = <1>;
>>>> +		};
>>>> +
>>>>  		ao_gpio0: gpio@fffff41000 {
>>>>  			compatible = "snps,dw-apb-gpio";
>>>>  			reg = <0xff 0xfff41000 0x0 0x1000>;
>>>> -- 
>>>> 2.34.1
>>>>
>>>
>>> Reviewed-by: Drew Fustini <dfustini@tenstorrent.com>
>>>
>>> dt_binding_check and dtbs_check are clean when I apply this patch to
>>> v6.13-rc1. There is trivial conflict due to the gpio node label having
>>> changed. I'll resolve it when I apply the patch to thead-dt-for-next.
>>
>> I've applied this patch to thead-dt-for-next [1].

Thanks for confirming. I’m currently preparing v2 of the series [2]. In
addition to the changes already discussed, I plan to broaden the scope
to include the power-domain user of the mailbox for completeness, so
I'll include this commit in my series as well. I’ll also ensure that
your Reviewed-by tag is included in the updated commit. Thanks again for
the review and your ongoing support.

[2] - https://lore.kernel.org/all/20241203134137.2114847-1-m.wilczynski@samsung.com/

Michał
>>
>> Thanks,
>> Drew
>>
>> [1] https://protect2.fireeye.com/v1/url?k=ded1044e-bf5a1177-ded08f01-000babffae10-a43021e0091864fc&q=1&e=465c5302-3d9e-4713-b219-30181e5944c2&u=https%3A%2F%2Fgithub.com%2Fpdp7%2Flinux%2Fcommit%2F98064af36cbc0c216d0a2d11da5e3746a57ccce7
> 
> I forgot my SoB so it is now a new hash [1].
> 
> -Drew
> 
> [1] https://protect2.fireeye.com/v1/url?k=21bcf54a-4037e073-21bd7e05-000babffae10-2408d35c4723ee6d&q=1&e=465c5302-3d9e-4713-b219-30181e5944c2&u=https%3A%2F%2Fgithub.com%2Fpdp7%2Flinux%2Fcommit%2Fc95c1362e5bcd90c45987828bbef02236d181ffd
>