From: Marek Szyprowski <m.szyprowski@samsung.com>
To: John Ogness <john.ogness@linutronix.de>, Petr Mladek <pmladek@suse.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Andrea Parri <parri.andrea@gmail.com>,
Paul McKenney <paulmck@kernel.org>,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH printk v5 6/6] printk: reimplement log_cont using record extension
Date: Fri, 25 Sep 2020 21:08:28 +0200 [thread overview]
Message-ID: <f1651593-3579-5820-6863-5f4973d2bfdc@samsung.com> (raw)
In-Reply-To: <20200914123354.832-7-john.ogness@linutronix.de>
Hi John,
On 14.09.2020 14:33, John Ogness wrote:
> Use the record extending feature of the ringbuffer to implement
> continuous messages. This preserves the existing continuous message
> behavior.
>
> Signed-off-by: John Ogness <john.ogness@linutronix.de>
> Reviewed-by: Petr Mladek <pmladek@suse.com>
This patch landed recently in linux-next as commit f5f022e53b87
("printk: reimplement log_cont using record extension"). I've noticed
that it causes a regression on my test system (ARM 32bit Samsung Exynos
4412-based Trats2 board). The messages are printed correctly on the
serial console during boot, but then when I run 'dmesg' command, the log
is truncated.
Here is are the last lines of the dmesg log after this patch:
[ 6.649018] Waiting 2 sec before mounting root device...
[ 6.766423] dwc2 12480000.hsotg: new device is high-speed
[ 6.845290] dwc2 12480000.hsotg: new device is high-speed
[ 6.914217] dwc2 12480000.hsotg: new address 51
[ 8.710351] RAMDISK: squashfs filesystem found at block 0
The corresponding dmesg lines before applying this patch:
[ 8.864320] RAMDISK: squashfs filesystem found at block 0
[ 8.868410] RAMDISK: Loading 37692KiB [1 disk] into ram disk... /
[ 9.071670] /
[ 9.262498] /
[ 9.540711] /
[ 9.818031] done.
[ 10.660074] VFS: Mounted root (squashfs filesystem) readonly on
device 1:0.
[ 10.739525] EXT4-fs (mmcblk0p1): INFO: recovery required on readonly
filesystem
[ 10.745347] EXT4-fs (mmcblk0p1): write access will be enabled during
recovery
[ 10.861129] EXT4-fs (mmcblk0p1): recovery complete
[ 10.878150] EXT4-fs (mmcblk0p1): mounted filesystem with ordered data
mode. Opts: (null)
[ 10.881811] VFS: Mounted root (ext4 filesystem) readonly on device
179:49.
[ 10.889858] Trying to move old root to /initrd ...
[ 10.895192] okay
[ 10.914411] devtmpfs: mounted
[ 10.925087] Freeing unused kernel memory: 1024K
[ 10.933222] Run /sbin/init as init process
[ 10.941723] with arguments:
[ 10.949890] /sbin/init
[ 10.949900] with environment:
[ 10.949909] HOME=/
[ 10.949917] TERM=linux
[ 12.415991] random: systemd-udevd: uninitialized urandom read (16
bytes read)
[ 12.425361] random: systemd-udevd: uninitialized urandom read (16
bytes read)
[ 12.438578] random: systemd-udevd: uninitialized urandom read (16
bytes read)
...
I can provide a complete logs if that helps.
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
next prev parent reply other threads:[~2020-09-25 20:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 12:33 [PATCH printk v5 0/6] printk: reimplement LOG_CONT handling John Ogness
2020-09-14 12:33 ` [PATCH printk v5 1/6] printk: ringbuffer: relocate get_data() John Ogness
2020-09-14 12:33 ` [PATCH printk v5 2/6] printk: ringbuffer: add BLK_DATALESS() macro John Ogness
2020-09-14 12:33 ` [PATCH printk v5 3/6] printk: ringbuffer: clear initial reserved fields John Ogness
2020-09-14 12:33 ` [PATCH printk v5 4/6] printk: ringbuffer: change representation of states John Ogness
2020-09-14 12:33 ` [PATCH printk v5 5/6] printk: ringbuffer: add finalization/extension support John Ogness
2020-09-15 9:30 ` Petr Mladek
2020-09-14 12:33 ` [PATCH printk v5 6/6] printk: reimplement log_cont using record extension John Ogness
[not found] ` <CGME20200925190829eucas1p2f35866317389cd5e842e99b465632902@eucas1p2.samsung.com>
2020-09-25 19:08 ` Marek Szyprowski [this message]
[not found] ` <CGME20200925193852eucas1p10c459f3f90192c1079f8a8f04b872015@eucas1p1.samsung.com>
2020-09-25 19:38 ` Marek Szyprowski
2020-09-25 22:59 ` John Ogness
2020-09-15 9:47 ` [PATCH printk v5 0/6] printk: reimplement LOG_CONT handling Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1651593-3579-5820-6863-5f4973d2bfdc@samsung.com \
--to=m.szyprowski@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=john.ogness@linutronix.de \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=parri.andrea@gmail.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®