From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41F5B1755F for ; Thu, 21 Mar 2024 17:13:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711041241; cv=none; b=KJ28Khmcy4sSldTt53cY7osDVPBjZWCFfzJ1NPJh6j4Yflo2dIc86hsjJTldVixHgbvUloTsNIQp2gnbFT1JfxvM7d1RfG0pZfYQKzkq2iw7mvwtmbonZ9YzCz+fXlqUYVf1hzM/IQncZa2VybgRd0MkUAdgPbbcCeujmWqwSkM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711041241; c=relaxed/simple; bh=Gy9dSISYC3+iioEVBCt5B4Eh35ZBRiWCProDJ1p0Lbc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rxMjrciIS/w0ekVPjlgK+/zs87b3DAOXXLyMebM2rBVyI5CrBDi2f5fDgu64z7ZzCIlMZb7JcH0/9Uyq20Y3apQ6BtzMRKY2/oJmKaHeM+T5PZLZ6WMeNuTwpw40k/qiHXsApJxPzjQ4C1k1DsHFkWUQSpRgjvAqgsT2+Y7wwUA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=iwyjuyp+; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="iwyjuyp+" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-41478162b64so2004915e9.3 for ; Thu, 21 Mar 2024 10:13:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1711041237; x=1711646037; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WjLTQlvuPOBaz+D+LjUilodmD16xs/15SSgaRqgavvw=; b=iwyjuyp+hhAo4htDuUkMsPGWE/+o39uZTbnjWObUfd0FlsI9fYoeIG+jem5DUe/qS6 ftI5Rrtr428hrAB2Dq1TKofkWRDYJ2I5/702rpwWm83eE95SHmlYVpc4XWgdQaXxgtb6 nZI0g/lxPR08n5qugI/y+MbL7HJ/Un7BzI9DQB/PLGR0Y2t71h5WbAuglosQQz9E2Wsh lelkTiX2ryva85eObm3U7K1oWZ/7WO6V4jxDIZJqPHibSXrjeYgXhG7Prbp9d6JZm5A5 0INKfKrntr6NC3dJL9PjlZIQ6vlr15TgsQGq11RFSfsHxec4qiWos9MAANt6UNNZLcwU WORg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711041237; x=1711646037; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WjLTQlvuPOBaz+D+LjUilodmD16xs/15SSgaRqgavvw=; b=txItkphWcx+YJEdubLMVkQN3MvzW+6mhfUPx75v2InZ+d1Obtd863eGOzvNwLjRdke p3HPQIHQjg2CjDy/iwQtTPEe0EOzs2An/UMFVl2ljawiQTV+NULBZrMcer5/k5OQu48J azKitmQ0/5oCTjaAQc5zbRQcl1Vjc6jGTi9RCY2C2/sXsGDri5d/fRHa2sutRFSlmNXI t7rzk19uXjtjF72Jmt21v2GB5bSelpCBOha8lnlWC5JDwNsip7PXoQfEIbF9E0I2cZOT fj7P6Y1T1ZbibZKEAt3geLdLzkqlrRrTJouspyNvHm4s9oJKK1/nqFdsEXXriJBCm3A0 OK5A== X-Forwarded-Encrypted: i=1; AJvYcCW8Lh+hrpEhYirgraojuzSJuslSiBC1cWayVq1bNzRSBYRNrixIa0Iqx9Le+eADnvtYr92FqvRnMSa5mftth9/QhkqnVr/CJnBOhQGP X-Gm-Message-State: AOJu0YycCirXIOqUjwtQDIj3LOyEqzJEl1zGTJ2QF/xVMZ5jdGkV3/4n lSMNi3AkLuK9DbSAIDuCxIHHxwWIiUIfB9EK2xGDKFY6BOinNONLMQwWWoik3M4= X-Google-Smtp-Source: AGHT+IFOV+vBJ3LYFE2xnOuvgPXYkdUnxlYzK1C2rDlHvcszqkpE8OzJg48OnEGPHHmSbsRP45KCIg== X-Received: by 2002:a05:600c:3c8c:b0:414:6211:14a0 with SMTP id bg12-20020a05600c3c8c00b00414621114a0mr7243975wmb.2.1711041237531; Thu, 21 Mar 2024 10:13:57 -0700 (PDT) Received: from [192.168.10.46] (146725694.box.freepro.com. [130.180.211.218]) by smtp.googlemail.com with ESMTPSA id v9-20020a05600c470900b0041409db0349sm333276wmo.48.2024.03.21.10.13.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Mar 2024 10:13:57 -0700 (PDT) Message-ID: Date: Thu, 21 Mar 2024 18:13:56 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/3] thermal: qcom: lmh: Check for SCM availability at probe Content-Language: en-US To: Konrad Dybcio , Bjorn Andersson , "Rafael J. Wysocki" , Zhang Rui , Lukasz Luba , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thara Gopinath , Amit Kucheria Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov , stable@vger.kernel.org References: <20240308-topic-rb1_lmh-v2-0-bac3914b0fe3@linaro.org> <20240308-topic-rb1_lmh-v2-2-bac3914b0fe3@linaro.org> From: Daniel Lezcano In-Reply-To: <20240308-topic-rb1_lmh-v2-2-bac3914b0fe3@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 09/03/2024 14:15, Konrad Dybcio wrote: > Up until now, the necessary scm availability check has not been > performed, leading to possible null pointer dereferences (which did > happen for me on RB1). > > Fix that. > > Fixes: 53bca371cdf7 ("thermal/drivers/qcom: Add support for LMh driver") > Cc: > Reviewed-by: Dmitry Baryshkov > Signed-off-by: Konrad Dybcio > --- Applied, thanks -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog