From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756928AbcJMUpd (ORCPT ); Thu, 13 Oct 2016 16:45:33 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:36776 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756795AbcJMUpO (ORCPT ); Thu, 13 Oct 2016 16:45:14 -0400 From: Don Brace X-Google-Original-From: Don Brace To: Javier Martinez Canillas Cc: iss_storagedev@hp.com, linux-scsi@vger.kernel.org, "James E.J. Bottomley" , esc.storagedev@microsemi.com, "Martin K. Petersen" , linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi: hpsa: remove unneeded void pointer cast References: <1476375008-10034-1-git-send-email-javier@osg.samsung.com> Message-ID: Date: Thu, 13 Oct 2016 15:45:00 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1476375008-10034-1-git-send-email-javier@osg.samsung.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/13/2016 11:10 AM, Javier Martinez Canillas wrote: > It's not necessary to cast the result of kmalloc, since void pointers are > promoted to any other type. This also fixes following coccinelle warning: > > casting value returned by memory allocation function to (BIG_IOCTL_Command_struct *) is useless. > > Signed-off-by: Javier Martinez Canillas > --- > > drivers/scsi/hpsa.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c > index d007ec18179a..4e82b692298e 100644 > --- a/drivers/scsi/hpsa.c > +++ b/drivers/scsi/hpsa.c > @@ -6657,8 +6657,7 @@ static int hpsa_big_passthru_ioctl(struct ctlr_info *h, void __user *argp) > return -EINVAL; > if (!capable(CAP_SYS_RAWIO)) > return -EPERM; > - ioc = (BIG_IOCTL_Command_struct *) > - kmalloc(sizeof(*ioc), GFP_KERNEL); > + ioc = kmalloc(sizeof(*ioc), GFP_KERNEL); > if (!ioc) { > status = -ENOMEM; > goto cleanup1; Acked-by: Don Brace