From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932323AbeEHJwa (ORCPT ); Tue, 8 May 2018 05:52:30 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:54553 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932067AbeEHJw3 (ORCPT ); Tue, 8 May 2018 05:52:29 -0400 X-Google-Smtp-Source: AB8JxZrwQu0O8gHAwVJDs6p+r0ZljaOgP7tLrji32J6Pq05/HOQBK/OHJ4afLk+RLmCqwfaD0JIpPg== Subject: Re: [RFC PATCH 2/3] arcnet: com20020: Fixup missing SLOWARB bit To: "Tobin C. Harding" Cc: m.grzeschik@pengutronix.de, Andrea Greco , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20180505213754.8400-1-andrea.greco.gapmilano@gmail.com> <20180507025556.GG4197@eros> From: Andrea Greco Message-ID: Date: Tue, 8 May 2018 11:52:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180507025556.GG4197@eros> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/07/2018 04:55 AM, Tobin C. Harding wrote: > On Sat, May 05, 2018 at 11:37:54PM +0200, Andrea Greco wrote: >> From: Andrea Greco >> >> If com20020 clock is major of 40Mhz SLOWARB bit is requested. >> >> Signed-off-by: Andrea Greco >> --- >> drivers/net/arcnet/com20020.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/drivers/net/arcnet/com20020.c b/drivers/net/arcnet/com20020.c >> index f09ea77dd6a8..abd32ed8ec9b 100644 >> --- a/drivers/net/arcnet/com20020.c >> +++ b/drivers/net/arcnet/com20020.c >> @@ -102,6 +102,10 @@ int com20020_check(struct net_device *dev) >> lp->setup = lp->clockm ? 0 : (lp->clockp << 1); >> lp->setup2 = (lp->clockm << 4) | 8; >> >> + // If clock is major of 40Mhz, SLOWARB bit must be set > > /* C89 style comments please :) */ > Done > > Hope this helps, > Tobin. >