From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752646AbdKFL7e (ORCPT <rfc822;w@1wt.eu>);
        Mon, 6 Nov 2017 06:59:34 -0500
Received: from mail-wm0-f67.google.com ([74.125.82.67]:44827 "EHLO
        mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752362AbdKFL7c (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 6 Nov 2017 06:59:32 -0500
X-Google-Smtp-Source: ABhQp+SXuuvsWfqSdOe4NnYyZu5YKfWdgVpnI34eG1wssM+x5l5gvocyFXSKlxwWe4Gl0vXL6FbQiA==
Reply-To: christian.koenig@amd.com
Subject: Re: [PATCH] drm/amd/display: remove some unneeded code
To: Dan Carpenter <dan.carpenter@oracle.com>,
        Alex Deucher <alexander.deucher@amd.com>
Cc: Charlene Liu <charlene.liu@amd.com>, David Airlie <airlied@linux.ie>,
        Harry Wentland <harry.wentland@amd.com>,
        dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org,
        linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
        Dmytro Laktyushkin <Dmytro.Laktyushkin@amd.com>,
        Vitaly Prosyak <vitaly.prosyak@amd.com>,
        Yongqiang Sun <yongqiang.sun@amd.com>, Tony Cheng <tony.cheng@amd.com>,
        =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
References: <20171106114422.sd5zoah6k6eaww4e@mwanda>
From: =?UTF-8?Q?Christian_K=c3=b6nig?= <ckoenig.leichtzumerken@gmail.com>
Message-ID: <f1752f40-42fc-7c3e-38ae-50e1d3b1617b@gmail.com>
Date: Mon, 6 Nov 2017 12:59:29 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20171106114422.sd5zoah6k6eaww4e@mwanda>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 06.11.2017 um 12:44 schrieb Dan Carpenter:
> We assign "v_init = asic_blank_start;" a few lines earlier so there is
> no need to do it again inside the if statements.  Also "v_init" is
> unsigned so it can't be less than zero.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Acked-by: Christian König <christian.koenig@amd.com>

>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_timing_generator.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_timing_generator.c
> index 1994865d4351..c7333cdf1802 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_timing_generator.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_timing_generator.c
> @@ -236,13 +236,10 @@ static void tgn10_program_timing(
>   	if (tg->dlg_otg_param.signal == SIGNAL_TYPE_DISPLAY_PORT ||
>   		tg->dlg_otg_param.signal == SIGNAL_TYPE_DISPLAY_PORT_MST ||
>   		tg->dlg_otg_param.signal == SIGNAL_TYPE_EDP) {
> -		v_init = asic_blank_start;
>   		start_point = 1;
>   		if (patched_crtc_timing.flags.INTERLACE == 1)
>   			field_num = 1;
>   	}
> -	if (v_init < 0)
> -		v_init = 0;
>   	v_fp2 = 0;
>   	if (tg->dlg_otg_param.vstartup_start > asic_blank_end)
>   		v_fp2 = tg->dlg_otg_param.vstartup_start > asic_blank_end;
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx