From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF63A3CCA02 for ; Mon, 20 Jul 2026 08:44:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784537048; cv=none; b=hKpNsfRTXO9/G0w3aliqfFlG2urt5hoebg2yO8n9mNR+mXCb6cy2Py7SMSsvBHdwNxvFefndzoj8EshAas2b7npvPT5LZ0Nnp8Uf47fC1w9piIMjp+R2YAsFLAsqHdKUlgAfziBx4HGPB9EJ1RawLoWpM8XQw5WG8fV6GRjrt9A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784537048; c=relaxed/simple; bh=X9c4GzGT8qhRHB9Hodv1J7Q7GA2MHFDjaY9D2UXMQn8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Io3z294VAHog4IA+ToNEjrnyPdJwUJH/YlUNJqIT/0ZJ3kUPCZCCwIhzTUvT0spAYcLsYjKMiFEdGwXat6xdj2jquTD84wTBjPEfSQsB/zKaHoES59MSVhgSBYfUZHUCQgWlzWrHitzZAixateR6gpIhtAwjeCEZ6C9M1ji+Zrw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=AknK9Qwc; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=a698s6qH; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="AknK9Qwc"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="a698s6qH" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66K76ReV1712957 for ; Mon, 20 Jul 2026 08:44:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= dPXnHQbZ/zB5wkjjc+qQcK1xn5/hbaCj20uwYbxkeO0=; b=AknK9Qwc0u9l1cA+ 5SHWeYukgusWa4oyebLcXZl5hz+eu0BWWIy/JLB7qsTVAII4IHRbl+GxZ6UBQQnZ ZozdXveBw42P6XksShRhA8WhObyXXs78ptlJsC51IKhR28tMg6r5+9ni7TFNFXC1 DwHJGgdWWwq+9PQOUJhVSasL9gI/CT8m3NP3e4ZIQzwyqJDQrbKgoD61bMKTMmOY oIn+4bn2jelDC7c1Clu+RWYjCmt5EoPN/63Nfg5CNmKZVZoIa6uZ8GLhGl0TfLpz Gxo04riTju8A9GyvoDpZUzzjbanRYnr+cjl2hEs7qEIWBLT4WOHcj53OEWU8tPpQ 5xIHhw== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fhf0c0bqr-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 20 Jul 2026 08:44:05 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-92e661ce1dcso186483585a.0 for ; Mon, 20 Jul 2026 01:44:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784537045; x=1785141845; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=dPXnHQbZ/zB5wkjjc+qQcK1xn5/hbaCj20uwYbxkeO0=; b=a698s6qHG3bDsvU23Z+5IJ2wsZRNlmm5bS7k2FTnqcAwkdkwD1PJzqM1PWI3mcZZV2 4RPUFv48sEtO0HAcaJb4w5xq+apEke6R5XsX8DRSZjmRdtwMXFumQ7cpMLnWAeXWm8LW HNUPhtXnyPTDMDmlP3Nn6CT/BbLk17b629jSLx8HlBvuiWn1I+3CCN0QXcjxw3zLUIoI c7SCZsR1dBRP3sqEW/Z2O3pxIi7p5IZlDqZOT7/NAgqhuVGxSssVX5HdMFRmlZXLNKMp kRjHRHSQtlQenRcXG+uSM/uy940GPDfpYBHNszTNkZGmQ/2Y0BvApiWhyrF+6kX1oquT Pn2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784537045; x=1785141845; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=dPXnHQbZ/zB5wkjjc+qQcK1xn5/hbaCj20uwYbxkeO0=; b=LvwLUvy3oN/jRCyluCewJcphomrNcmsArUNyoW9g3my+0HoLakI0IXnFffxkUrs7HY Y3MFlczIs6dTL6xK3dWChVaCJtNsod9yTiMSBQ5QLEE9+qBia41UxUnO4XHq+oiMMHhz zyzx0Ab/fhS/4vdSl7vuaz/qDt5vd6DUnR9KBY0u0B+FoxHqbc1k3qAVHglHPy4CgdBx nQnrn1NCDO6NFB2dNRwRoXk9LWVMF0Z7zO8Ggubou6DqZKpTx5v92AwIMQtTOyrr6VEG b1QXkDL6bkXul50szGltoEkSpJG8g4m9hOYtFnXiPFzoRI9K4BOoF7HgC5vChn4TCjUG +WaA== X-Forwarded-Encrypted: i=1; AHgh+Rr78AmgIDfwH3JnePAE4CiaZtxuM/N8Yk1CHkOFvmK7DXo13rAKSr2NhwFQNEhN2IRXS3GuAlr14RknPy4=@vger.kernel.org X-Gm-Message-State: AOJu0YyljzvA1jNGS95Xzroe/GRME4+QmwwksMJLXA/SUTftaAv8vcLN R/QDhZADwMBGORNoNQnF3iILuLuiKDNewEwAuwL56A0jdy7v9vbDpVf8/PTVP0hPIbXfhrBPONm dFpScUmtPHdNEEX/RByhtOkgF7kd5lmyK/OsVOCdAxSuQq7nxGlYbprs0sk7jxRXnWes= X-Gm-Gg: AfdE7cmrnhTg0qi4og+wxrETtlqFvwYEcxktpSH51QZkFd2/QJSDv5ey9ZIE9tGTMIA 90vUg5WCjbybjf+Q3HaolLbaaWl9xGAFf9gdeqDTxgceIw2uBC7krNizcQ8jX546599ctRKTt4g 644IZyc7YyuZS9SH1zjQFpIniPbGE5yPygzMnEi+7fHY0ufMcYD2RNjXn8oZKDe3quiLbBnnNhr G7x0F3lXhkwHeJ8t4H9l3ZnnrJrZi9TdWTUTGLXmOloNZhEtUkY8g3QKOE9Vxy81rFM4B6dJpOa du0Xo5L9Oy155JIrpyq41t5OgDukj8tBhJttHy4aD6m/10+cbdX60b6zFXn+q7kQr4XNuBvkkou TP8/JWH1VKY8X1+/f3Pmfr1dG X-Received: by 2002:a05:620a:a01c:b0:92e:5ba4:b841 with SMTP id af79cd13be357-930b435ce40mr906619185a.6.1784537045082; Mon, 20 Jul 2026 01:44:05 -0700 (PDT) X-Received: by 2002:a05:620a:a01c:b0:92e:5ba4:b841 with SMTP id af79cd13be357-930b435ce40mr906617285a.6.1784537044675; Mon, 20 Jul 2026 01:44:04 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1705912972sm431659866b.14.2026.07.20.01.44.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jul 2026 01:44:03 -0700 (PDT) Message-ID: Date: Mon, 20 Jul 2026 10:44:02 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] pinctrl: qcom: ipq9650: fix audio_sec_mclk_in1/out1 group pins To: Taceddin Sancak , Bjorn Andersson , Linus Walleij Cc: Kathiravan Thirumoorthy , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260718002146.698973-1-ts.solidarity@gmail.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260718002146.698973-1-ts.solidarity@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=HeYkiCE8 c=1 sm=1 tr=0 ts=6a5ddfd5 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=fW5ZgvKe1gcteIz5WIgA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-GUID: XORSDc_kOFBa5bmQ8A32K3omCKO0cbiL X-Proofpoint-ORIG-GUID: XORSDc_kOFBa5bmQ8A32K3omCKO0cbiL X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIwMDA5NiBTYWx0ZWRfX6xNr83WsBWvG 1ZkpUWCSXcMm/TdUmw/rpzMtvJ+j0QfKPgedX32QtzMSg+RhDaIEfQDunqgDLXntBN5jutmDy+W 76PMuemCVbsl+t4g3f35U6UQS/Qc4KE= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIwMDA5NiBTYWx0ZWRfX55s2JpKi7d34 /vfJnAkETQwu3a6TXfspoHgzH/D8hunVrE7+WRah09r+tQJiW9bXfgSYpyHiyP/NyZssaCsVgfI SHVjJ8PlGR3pgVRV3ddlJ/Yi28dI9E0sawRMP4pnFxf1kEuSZfoomcw/SlUI6txsCo9f2Dw1Gvd t0iVLIh0Z92qtdr1aBsXxUWen0lTzFeFHw6/Nmys4Nl3CzlsV9T9q16WidJsb6Ob84WPq9z0Hqn HiBCPe1z1GyAP5pU0hEFICdkhyvWaf3NeSQz9w/zc6wijLlCZY2btRKuWmN850YHl5gii0Gqp2n 8YuqyYKSTAvKJuA/DRr/LUytmH1X5OufCbBqwmWWGZOXss2VMbgFkSslyyH3tjUAmJE/ZaeTczq TmJhyiSYyGDe0I0hfg98I352t6lvXxp+UMXnskBLTGcqtyVkB13avpTptgk7qO0ZLa+G5cgZEZ+ VhrLUNJMkCTJxbtNzPg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-20_01,2026-07-17_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 lowpriorityscore=0 impostorscore=0 malwarescore=0 suspectscore=0 phishscore=0 clxscore=1015 adultscore=0 bulkscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607200096 On 7/18/26 2:21 AM, Taceddin Sancak wrote: > The audio_sec_mclk_in1 and audio_sec_mclk_out1 groups both list > "gpio37", but in the pingroup table those functions are muxed on > gpio39, while gpio37 provides the audio_sec_mclk_in0/out0 variants. > This makes both functions unusable: selecting them on gpio39 is > rejected by the pinmux core because the group is not listed for the > function, and selecting them on gpio37 trips the WARN_ON() in > msm_pinmux_set_mux() and fails with -EINVAL because that group > cannot mux them. > > Point both groups at gpio39, matching the pingroup table. This also > mirrors the primary audio MCLK pair, where the mclk0 and mclk1 > variants live on separate pins (gpio53 and gpio51 respectively). > > Fixes: 3c8e7ba0e399 ("pinctrl: qcom: Introduce IPQ9650 TLMM driver") > Assisted-by: Claude:claude-fable-5 > Signed-off-by: Taceddin Sancak > --- Reviewed-by: Konrad Dybcio Konrad