From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7506EB64DA for ; Thu, 20 Jul 2023 18:53:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229844AbjGTSxz (ORCPT ); Thu, 20 Jul 2023 14:53:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229519AbjGTSxy (ORCPT ); Thu, 20 Jul 2023 14:53:54 -0400 Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A98510FC for ; Thu, 20 Jul 2023 11:53:52 -0700 (PDT) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id E721A3202ADA; Thu, 20 Jul 2023 14:53:47 -0400 (EDT) Received: from imap47 ([10.202.2.97]) by compute5.internal (MEProxy); Thu, 20 Jul 2023 14:53:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=svenpeter.dev; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1689879227; x= 1689965627; bh=UsCIH3GnKiEckT+NRUJpbKBJyrIYS4v+Hkal0eCfojk=; b=D hxeJRYr/bgQagplL/v//yrho2U0iMTVVTYTfDxkLDfCFOXYWPVpP1doHILYwdFHR P0rg3a+FUY4xED0exa+KcC9tCvsA3u8OV8grScAbWuFiEgdT46EVbmhI64E8aHR2 2Lx+z9UD1JRvLbJFh/5IvNyu7cKoTb9/jV4uaS9QJGOPm+AAt2lR/Ymd2O4fPLeG ri1cWAXHldntSeRiMlsN6Ffz3ncXJ19+ktZmSRevxUtzbPBzzvzwo31bS8eMTWtM Kj8PEFISc7bPPoAbvk8hqtPyGpHRehfH1xGwyym8F+Wky/WdGtbM3jdneipcmcva y3FOdqOfTGKmgupZbvhNQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1689879227; x=1689965627; bh=UsCIH3GnKiEck T+NRUJpbKBJyrIYS4v+Hkal0eCfojk=; b=nj81Hxud2v8K5nBoY8G1EP0ihpFMZ panHSt5GnbkotKZGVaTt/ph3eauYR2Jn9H43kDNEZpOn4yU/3VBeU7Djk0bt1/2k Bn6Mlcwo2OfTcZVr4+a2ZniJxunf3BnGAksl4d/wZPryNU9YbXiOUZ2WBAO27KjK 1ZTAFEG6e3wLmWMlDEykzg7uhB1t7W1hlommUlU/bysAsAoxMCIxMsk0EXK+X1RA L484WxmpGwlplr0nwJ/IYqjkSHSTkFhoRmITkHt9OkkZMSy000iX9p9/vRrkIcWg ttmerg7/PUxbVoTfADo/oETqnoUFTzQ1+kJtt90gETNseWKXzAyg8f+nQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrhedtgdduvdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedfufhv vghnucfrvghtvghrfdcuoehsvhgvnhesshhvvghnphgvthgvrhdruggvvheqnecuggftrf grthhtvghrnhepleevgfegffehvedtieevhfekheeftedtjeetudevieehveevieelgffh ieevieeunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epshhvvghnsehsvhgvnhhpvghtvghrrdguvghv X-ME-Proxy: Feedback-ID: i51094778:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 979D8A60077; Thu, 20 Jul 2023 14:53:46 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-531-gfdfa13a06d-fm-20230703.001-gfdfa13a0 Mime-Version: 1.0 Message-Id: In-Reply-To: <20230719222033.117513-1-minhuadotchen@gmail.com> References: <20230719222033.117513-1-minhuadotchen@gmail.com> Date: Thu, 20 Jul 2023 20:53:26 +0200 From: "Sven Peter" To: "Min-Hua Chen" , "Hector Martin" , "Alyssa Rosenzweig" , "Joerg Roedel" , "Will Deacon" , "Robin Murphy" Cc: asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iommu/apple-dart: mark apple_dart_pm_ops static Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 20, 2023, at 00:20, Min-Hua Chen wrote: > This patch fixes the following sprse warning: typo: sparse > > drivers/iommu/apple-dart.c:1279:1: sparse: warning: symbol > 'apple_dart_pm_ops' was not declared. Should it be static? > > No functional change intended. > > Signed-off-by: Min-Hua Chen > --- Acked-by: Sven Peter Thanks, Sven > drivers/iommu/apple-dart.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/apple-dart.c b/drivers/iommu/apple-dart.c > index 8af64b57f048..2082081402d3 100644 > --- a/drivers/iommu/apple-dart.c > +++ b/drivers/iommu/apple-dart.c > @@ -1276,7 +1276,7 @@ static __maybe_unused int > apple_dart_resume(struct device *dev) > return 0; > } > > -DEFINE_SIMPLE_DEV_PM_OPS(apple_dart_pm_ops, apple_dart_suspend, > apple_dart_resume); > +static DEFINE_SIMPLE_DEV_PM_OPS(apple_dart_pm_ops, apple_dart_suspend, > apple_dart_resume); > > static const struct of_device_id apple_dart_of_match[] = { > { .compatible = "apple,t8103-dart", .data = &apple_dart_hw_t8103 }, > -- > 2.34.1