mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "eric miao" <eric.y.miao@gmail.com>
To: ian <spyro@f2s.com>
Cc: "Dmitry Baryshkov" <dbaryshkov@gmail.com>,
	"ARM Linux" <linux-arm-kernel@lists.arm.linux.org.uk>,
	linux-kernel@vger.kernel.org
Subject: Re: [patch] 0/4 Support for Toshiba TMIO multifunction devices
Date: Wed, 21 Nov 2007 10:23:41 +0800	[thread overview]
Message-ID: <f17812d70711201823w6201bf88uf6268aaee3a32312@mail.gmail.com> (raw)
In-Reply-To: <1195597252.2329.70.camel@wirenth>

Roughly went through the patch, looks good, here comes the remind, though :-)

1. is it possible to use some name other than "soc_core", maybe
"tmio_core" so that
other multifunction chips sharing a core base will live easier.

2. those C++ style comments "//" are not so pleasant...

- eric

On Nov 21, 2007 6:20 AM, ian <spyro@f2s.com> wrote:
> On Wed, 2007-11-21 at 01:04 +0300, Dmitry Baryshkov wrote:
> > Just to note, that there is an alternative implementation for at least
> > the tc6393 chip devices. Most current version of those patches can be
> > found in the OpenEmbedded monotone.
>
> Yes, this is true. The core code in both cases originates from my and
> Dirks work.
>
> I'd just like to get something pushed up to mainline so that work can
> begin on expanding the number of chips supported.
>
> This would include the ASICs found in many iPAQ PDAs (their MMC module
> seems to be an IRQ-less TMIO chip).
>
> I havent submitted the subdevice drivers yet, only the base/core
> drivers.
>
> The OE versions probably have better USB and video subdevice support
> (which I shall evaluate as I go on), wheras the NAND flash and MMC
> drivers in hh.org are probably more up to date (I run root on SD usinf
> the hh.org tmio_mmc driver on all three of the MFD chips in this patch
> series on a daily basis).
>
> merging the best of these patch series is my goal and it shouldnt be too
> hard.
>
>
>
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>



-- 
Cheers
- eric

  reply	other threads:[~2007-11-21  2:23 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-20 20:40 ian
2007-11-20 22:04 ` Dmitry Baryshkov
2007-11-20 22:20   ` ian
2007-11-21  2:23     ` eric miao [this message]
2007-11-21  3:54       ` ian
2007-11-21  4:05         ` eric miao
2007-11-22  0:34           ` [UPDATED PATCH] " ian
2007-11-22  0:52             ` Russell King - ARM Linux
2007-11-22 10:52               ` ian
2007-11-26 12:23                 ` Russell King - ARM Linux
2007-11-22  0:49         ` [patch] 0/4 " Anton Vorontsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f17812d70711201823w6201bf88uf6268aaee3a32312@mail.gmail.com \
    --to=eric.y.miao@gmail.com \
    --cc=dbaryshkov@gmail.com \
    --cc=linux-arm-kernel@lists.arm.linux.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=spyro@f2s.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®