From: "eric miao" <eric.y.miao@gmail.com>
To: "Jean Delvare" <khali@linux-fr.org>
Cc: "David Brownell" <david-b@pacbell.net>,
linux-kernel@vger.kernel.org, i2c@lm-sensors.org,
bgardner@wabtec.com
Subject: Re: [PATCH 2.6.24-rc5-mm 3/3] gpiolib: obsolete drivers/i2c/chips/pca9539.c
Date: Tue, 18 Dec 2007 09:54:42 +0800 [thread overview]
Message-ID: <f17812d70712171754q3b71a39dl7d17f5d9e5b8014c@mail.gmail.com> (raw)
In-Reply-To: <20071217212953.260f7826@hyperion.delvare>
Well, I guess it would be a smooth path if we rename the
drivers/i2c/chips/pca9539.c
since that's old style I2C driver, which means the driver name is not
so useful external
so the impact is actually minimum.
On Dec 18, 2007 4:29 AM, Jean Delvare <khali@linux-fr.org> wrote:
> Hi David,
>
>
> On Mon, 17 Dec 2007 10:09:53 -0800, David Brownell wrote:
> > > Date: Mon, 17 Dec 2007 14:33:27 +0800
> > > From: "eric miao" <eric.y.miao@gmail.com>
> > >
> > > for the following reasons:
> > >
> > > 1. there is currently no known users of this driver
> > >
> > > 2. the functionality of this driver is well supported with the recent
> > > proposed drivers/gpio/pca9539.c, using GPIO_LIB
> > >
> > > Signed-off-by: eric miao <eric.miao@marvell.com>
> > > Acked-by: Ben Gardner <bgardner@wabtec.com>
> > > ---
> > > Documentation/i2c/chips/pca9539 | 47 --------
> > > drivers/i2c/chips/Kconfig | 10 --
> > > drivers/i2c/chips/Makefile | 1 -
> > > drivers/i2c/chips/pca9539.c | 196 ----------------------------------
> >
> > Jean, do you sign off on this? In any case I think this should
> > be going through your I2C patches.
> >
> > I'd be a trifle uneasy just deleting this, because it's possible
> > there are *unknown* users ... and also because nobody's yet done
> > a userspace interface to the gpiolib infrastructure. (It seems
> > to be the usual case of nobody wanting such a thing quite enough
> > to write the code.)
> >
> > I'd be more comfortable marking it as obsolete and flagging it
> > for removal a release or two after Eric's new version merges ...
> > though maybe that's just paranoia.
>
> I'm fine with this and I agree that it would be safer, however please
> note that both drivers are mutually exclusive because they have the
> same name, meaning that deprecating the old driver is not enough, you
> also need Kconfig magic to make sure that both drivers aren't built at
> the same time. Or alternatively the old driver could be renamed... I
> don't really care myself, I'll take whatever patch you or Eric submit.
>
> --
> Jean Delvare
>
--
Cheers
- eric
next prev parent reply other threads:[~2007-12-18 1:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-15 4:16 eric miao
2007-12-16 19:42 ` Jean Delvare
2007-12-17 6:33 ` eric miao
2007-12-17 18:09 ` David Brownell
2007-12-17 20:29 ` Jean Delvare
2007-12-18 1:54 ` eric miao [this message]
2007-12-18 14:40 ` Jean Delvare
2007-12-19 8:45 ` eric miao
2007-12-19 9:01 ` Jean Delvare
2007-12-19 9:32 ` eric miao
2007-12-23 18:32 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f17812d70712171754q3b71a39dl7d17f5d9e5b8014c@mail.gmail.com \
--to=eric.y.miao@gmail.com \
--cc=bgardner@wabtec.com \
--cc=david-b@pacbell.net \
--cc=i2c@lm-sensors.org \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®