From: "eric miao" <eric.y.miao@gmail.com>
To: "Andrew Morton" <akpm@linux-foundation.org>
Cc: "linux-arm-kernel email list"
<linux-arm-kernel@lists.arm.linux.org.uk>,
linux-fbdev-devel@lists.sourceforge.net,
lkml <linux-kernel@vger.kernel.org>,
"Russell King - ARM Linux" <linux@arm.linux.org.uk>,
"Daniel Mack" <daniel@caiaq.de>
Subject: Re: [PATCH 3/4] pxafb: move parallel LCD timing setup into dedicate function
Date: Tue, 8 Apr 2008 18:01:46 +0800 [thread overview]
Message-ID: <f17812d70804080301j5670244dr21346e75c4744eab@mail.gmail.com> (raw)
In-Reply-To: <20080408012136.30b71560.akpm@linux-foundation.org>
On Tue, Apr 8, 2008 at 4:21 PM, Andrew Morton <akpm@linux-foundation.org> wrote:
> On Tue, 8 Apr 2008 12:05:16 +0800 "eric miao" <eric.y.miao@gmail.com> wrote:
>
> > @@ -636,61 +671,31 @@ static int pxafb_activate_var(struct
> > fb_var_screeninfo *var,
> > printk(KERN_ERR "%s: invalid lower_margin %d\n",
> > fbi->fb.fix.id, var->lower_margin);
> > #endif
> > + /* Update shadow copy atomically */
> > + local_irq_save(flags);
>
> So this code will only ever work on uniprocessor machines?
>
> Is this a safe and reasonable assumption?
>
Y, this is a reasonable assumption for PXA2xx/3xx, though as noted in
the comment, it's too heavy for an local_irq_{save,restore} here, but
a fix to this would involve more investigation, so I'd rather have this
fixed later.
--
Cheers
- eric
prev parent reply other threads:[~2008-04-08 10:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-08 4:05 eric miao
2008-04-08 8:21 ` Andrew Morton
2008-04-08 10:01 ` eric miao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f17812d70804080301j5670244dr21346e75c4744eab@mail.gmail.com \
--to=eric.y.miao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=daniel@caiaq.de \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®