mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Eric Miao" <eric.y.miao@gmail.com>
To: "Marc Zyngier" <maz@misterjones.org>
Cc: linux-kernel@vger.kernel.org,
	"Amit Walambe" <amit.walambe@eurotech-ltd.co.uk>,
	"Dominik Brodowski" <linux@dominikbrodowski.net>,
	"Marc Zyngier" <marc.zyngier@altran.com>
Subject: Re: [PATCH 2/5] Add support for the Arcom/Eurotech Viper SBC onboard ethernet.
Date: Thu, 7 Aug 2008 11:52:13 +0800	[thread overview]
Message-ID: <f17812d70808062052p7943441ax5a70aea0a9d3447f@mail.gmail.com> (raw)
In-Reply-To: <15b4632ba095731c7c6c384de0698e2ef84fa775.1218018637.git.marc.zyngier@altran.com>

Consider merging this to the following code in the front of smc91x.h

#if defined(CONFIG_ARCH_LUBBOCK) ||\
    defined(CONFIG_MACH_MAINSTONE) ||\
    defined(CONFIG_MACH_ZYLONITE) ||\
    defined(CONFIG_MACH_LITTLETON)

#include <asm/mach-types.h>

/* Now the bus width is specified in the platform data
 * pretend here to support all I/O access types
 */
#define SMC_CAN_USE_8BIT        1
#define SMC_CAN_USE_16BIT       1
#define SMC_CAN_USE_32BIT       1
#define SMC_NOWAIT              1

#define SMC_IO_SHIFT            (lp->io_shift)

....
#else

On Wed, Aug 6, 2008 at 9:19 PM, Marc Zyngier <maz@misterjones.org> wrote:
> Signed-off-by: Marc Zyngier <marc.zyngier@altran.com>
> ---
>  drivers/net/smc91x.h |   21 +++++++++++++++++++++
>  1 files changed, 21 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/smc91x.h b/drivers/net/smc91x.h
> index 22209b6..9481412 100644
> --- a/drivers/net/smc91x.h
> +++ b/drivers/net/smc91x.h
> @@ -185,6 +185,27 @@ static inline void SMC_outw(u16 val, void __iomem *ioaddr, int reg)
>
>  #define SMC_IRQ_FLAGS          (-1)
>
> +#elif defined(CONFIG_ARCH_VIPER)
> +
> +/* We can only do 16-bit reads and writes in the static memory space. */
> +#define SMC_CAN_USE_8BIT       0
> +#define SMC_CAN_USE_16BIT      1
> +#define SMC_CAN_USE_32BIT      0
> +#define SMC_CAN_USE_DATACS     1
> +#define SMC_NOWAIT             1
> +
> +#define SMC_IO_SHIFT           0
> +
> +#define SMC_inw(a, r)          readw((a) + (r))
> +#define SMC_outw(v, a, r)      writew(v, (a) + (r))
> +#define SMC_insw(a, r, p, l)   insw((a) + (r), p, l)
> +#define SMC_outsw(a, r, p, l)  outsw((a) + (r), p, l)
> +
> +#define RPC_LSA_DEFAULT                RPC_LED_100_10
> +#define RPC_LSB_DEFAULT                RPC_LED_TX_RX
> +
> +#define SMC_IRQ_FLAGS          (-1)    /* from resource */
> +
>  #elif defined(CONFIG_SA1100_ASSABET)
>
>  #include <asm/arch/neponset.h>
> --
> 1.5.4.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>



-- 
Cheers
- eric

  parent reply	other threads:[~2008-08-07  3:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-06 13:19 [PATCH 0/5] Support for Arcom/Eurotech Viper SBC Marc Zyngier
2008-08-06 13:19 ` [PATCH 1/5] Basic support for the " Marc Zyngier
2008-08-06 13:19   ` [PATCH 2/5] Add support for the Arcom/Eurotech Viper SBC onboard ethernet Marc Zyngier
2008-08-06 13:19     ` [PATCH 3/5] [PCMCIA] Add support for platform dependant quirks Marc Zyngier
2008-08-06 13:19       ` [PATCH 4/5] Add support for the Arcom/Eurotech Viper SBC CompactFlash card slot Marc Zyngier
2008-08-07  3:53       ` [PATCH 3/5] [PCMCIA] Add support for platform dependant quirks Eric Miao
2008-08-07  3:52     ` Eric Miao [this message]
2008-08-07  3:50   ` [PATCH 1/5] Basic support for the Arcom/Eurotech Viper SBC Eric Miao
2008-08-07  9:07     ` Marc Zyngier
2008-08-07  9:12       ` Eric Miao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f17812d70808062052p7943441ax5a70aea0a9d3447f@mail.gmail.com \
    --to=eric.y.miao@gmail.com \
    --cc=amit.walambe@eurotech-ltd.co.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@dominikbrodowski.net \
    --cc=marc.zyngier@altran.com \
    --cc=maz@misterjones.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®