From: "Eric Miao" <eric.y.miao@gmail.com>
To: "Liam Girdwood" <lrg@kernel.org>
Cc: "Jonathan Cameron" <jic23@cam.ac.uk>,
"Jonathan Cameron" <Jonathan.Cameron@gmail.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] da903x regulator bug fix
Date: Tue, 28 Oct 2008 20:21:57 +0800 [thread overview]
Message-ID: <f17812d70810280521g7cbf53b6kda2e7a1f7eef4de7@mail.gmail.com> (raw)
In-Reply-To: <1225192778.28382.137.camel@dell-desktop.example.com>
On Tue, Oct 28, 2008 at 7:19 PM, Liam Girdwood <lrg@kernel.org> wrote:
> On Tue, 2008-10-28 at 11:03 +0000, Jonathan Cameron wrote:
>> Changes the device registration part of the probe function to supply the
>> regulator device rather than its parent (the mfd device) as this caused
>> problems when the regulator core attempted to find constraints associated
>> with the regulators.
>>
>> Signed-of-by: Jonathan Cameron <jic23@cam.ac.uk>
>
> Thanks, this is more preferable than the first patch. I would ultimately
> prefer this regulator to be more like wm8350 in terms of mfd
> registration but we are in rc2 so this will have to wait.
>
> Eric, would you like to Ack ?
>
Yeah, I'm fine with this.
Acked-by: Eric Miao <eric.miao@marvell.com>
> Thanks
>
> Liam
>
>
>
--
Cheers
- eric
prev parent reply other threads:[~2008-10-28 12:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-24 15:47 Da903x regulator driver. Bug? Jonathan Cameron
2008-10-24 17:23 ` Jonathan Cameron
2008-10-24 18:24 ` Liam Girdwood
2008-10-24 18:53 ` Jonathan Cameron
2008-10-24 19:44 ` Mark Brown
2008-10-27 15:29 ` [PATCH] da903x regulator bug fix Jonathan Cameron
2008-10-28 1:01 ` Eric Miao
2008-10-28 1:02 ` Eric Miao
2008-10-28 10:40 ` Jonathan Cameron
2008-10-28 11:03 ` Jonathan Cameron
2008-10-28 11:19 ` Liam Girdwood
2008-10-28 12:21 ` Eric Miao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f17812d70810280521g7cbf53b6kda2e7a1f7eef4de7@mail.gmail.com \
--to=eric.y.miao@gmail.com \
--cc=Jonathan.Cameron@gmail.com \
--cc=jic23@cam.ac.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®