From: "Eric Miao" <eric.y.miao@gmail.com>
To: "Mark Brown" <broonie@sirena.org.uk>
Cc: "Samuel Ortiz" <sameo@openedhand.com>,
"Eric Miao" <eric.miao@marvell.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: Fix section mismatch in da903x
Date: Fri, 2 Jan 2009 11:46:41 +0800 [thread overview]
Message-ID: <f17812d70901011946p369bcd3bp8977405053cb6354@mail.gmail.com> (raw)
In-Reply-To: <1230814351-29527-1-git-send-email-broonie@sirena.org.uk>
Acked-by: Eric Miao <eric.miao@marvell.com>
Samuel, please help to merge.
On Thu, Jan 1, 2009 at 8:52 PM, Mark Brown <broonie@sirena.org.uk> wrote:
> The subdevice removal functions are marked __devexit but are referenced
> from the error handling path when probing so are needed even when
> __devexit functions are removed.
>
> Signed-off-by: Mark Brown <broonie@sirena.org.uk>
> ---
> drivers/mfd/da903x.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mfd/da903x.c b/drivers/mfd/da903x.c
> index 0b5bd85..248756f 100644
> --- a/drivers/mfd/da903x.c
> +++ b/drivers/mfd/da903x.c
> @@ -435,13 +435,13 @@ static const struct i2c_device_id da903x_id_table[] = {
> };
> MODULE_DEVICE_TABLE(i2c, da903x_id_table);
>
> -static int __devexit __remove_subdev(struct device *dev, void *unused)
> +static int __remove_subdev(struct device *dev, void *unused)
> {
> platform_device_unregister(to_platform_device(dev));
> return 0;
> }
>
> -static int __devexit da903x_remove_subdevs(struct da903x_chip *chip)
> +static int da903x_remove_subdevs(struct da903x_chip *chip)
> {
> return device_for_each_child(chip->dev, NULL, __remove_subdev);
> }
> --
> 1.5.6.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
--
Cheers
- eric
next prev parent reply other threads:[~2009-01-02 3:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-01 12:52 Mark Brown
2009-01-02 3:46 ` Eric Miao [this message]
2009-01-04 14:34 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f17812d70901011946p369bcd3bp8977405053cb6354@mail.gmail.com \
--to=eric.y.miao@gmail.com \
--cc=broonie@sirena.org.uk \
--cc=eric.miao@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@openedhand.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®