From: Eric Miao <eric.y.miao@gmail.com>
To: coly.li@suse.de
Cc: LKML <linux-kernel@vger.kernel.org>,
Eric Miao <eric.miao@marvell.com>, Ingo Molnar <mingo@elte.hu>,
Magnus Damm <damm@igel.co.jp>
Subject: Re: [PATCH 1/7] mach-mmp: add parameter to clksrc_read()
Date: Thu, 23 Apr 2009 14:18:03 +0800 [thread overview]
Message-ID: <f17812d70904222318n4b742c17y647b8a8ca5273112@mail.gmail.com> (raw)
In-Reply-To: <49EF6A4D.3030606@suse.de>
This looks to be already fixed by Magnus Damm and merged in recent -rc3.
On Thu, Apr 23, 2009 at 3:04 AM, Coly Li <coly.li@suse.de> wrote:
> After the patch to add parameter to uv_read_rtc(), I did a grep and found
> several similar issues.
>
> This patch modifies parameter of clksrc_read() from 'void' to 'struct
> clocksource *cs', which fixes compile warning for incompatible parameter type.
>
> Signed-off-by: Coly Li <coly.li@suse.de>
> Cc: Eric Miao <eric.miao@marvell.com>
> Cc: Ingo Molnar <mingo@elte.hu>
> ---
> arch/arm/mach-mmp/time.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-mmp/time.c b/arch/arm/mach-mmp/time.c
> index b03a6ed..a8400bb 100644
> --- a/arch/arm/mach-mmp/time.c
> +++ b/arch/arm/mach-mmp/time.c
> @@ -136,7 +136,7 @@ static struct clock_event_device ckevt = {
> .set_mode = timer_set_mode,
> };
>
> -static cycle_t clksrc_read(void)
> +static cycle_t clksrc_read(struct clocksource *cs)
> {
> return timer_read();
> }
>
> --
> Coly Li
> SuSE Labs
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
--
Cheers
- eric
next prev parent reply other threads:[~2009-04-23 6:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-22 19:04 Coly Li
2009-04-23 6:18 ` Eric Miao [this message]
2009-04-23 8:37 ` Coly Li
2009-04-23 8:45 ` Eric Miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f17812d70904222318n4b742c17y647b8a8ca5273112@mail.gmail.com \
--to=eric.y.miao@gmail.com \
--cc=coly.li@suse.de \
--cc=damm@igel.co.jp \
--cc=eric.miao@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®