From: Eric Miao <eric.y.miao@gmail.com>
To: Daniel Mack <daniel@caiaq.de>
Cc: Pierre Ossman <pierre@ossman.eu>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, stable@kernel.org
Subject: Re: [PATCH] mmc: pxamci: call mmc_remove_host() before freeing resources
Date: Wed, 2 Dec 2009 23:02:55 +0800 [thread overview]
Message-ID: <f17812d70912020702n318089f0rd2e129b0e45458b2@mail.gmail.com> (raw)
In-Reply-To: <20091202110326.GZ14091@buzzloop.caiaq.de>
On Wed, Dec 2, 2009 at 7:03 PM, Daniel Mack <daniel@caiaq.de> wrote:
> On Wed, Dec 02, 2009 at 08:50:44AM +0800, Eric Miao wrote:
>> On Wed, Dec 2, 2009 at 1:17 AM, Daniel Mack <daniel@caiaq.de> wrote:
>> > mmc_remove_host() will cause the mmc core to switch off the bus power by
>> > eventually calling pxamci_set_ios(). This function uses the regulator or
>> > the GPIO which have been freed already.
>> >
>> > This causes the following Oops on module unload.
>> >
>
> [...]
>
>> >
>> > Signed-off-by: Daniel Mack <daniel@caiaq.de>
>> > Reported-by: Sven Neumann <s.neumann@raumfeld.com>
>> > Cc: Pierre Ossman <pierre@ossman.eu>
>> > Cc: Eric Miao <eric.y.miao@gmail.com>
>> > Cc: linux-mmc@vger.kernel.org
>> > Cc: linux-arm-kernel@lists.infradead.org
>> > Cc: stable@kernel.org
>> > ---
>> > drivers/mmc/host/pxamci.c | 4 ++--
>>
>> Looks like a correct fix to me.
>>
>> Acked-by: Eric Miao <eric.y.miao@gmail.com>
>
> Would be good to still get this into .32 - who will take care of picking
> this?
>
I'll send a pull request, and see if Russell will be happy to send
another one in such a short time :)
prev parent reply other threads:[~2009-12-02 15:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-01 17:17 Daniel Mack
2009-12-02 0:50 ` Eric Miao
2009-12-02 11:03 ` Daniel Mack
2009-12-02 15:02 ` Eric Miao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f17812d70912020702n318089f0rd2e129b0e45458b2@mail.gmail.com \
--to=eric.y.miao@gmail.com \
--cc=daniel@caiaq.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=pierre@ossman.eu \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®