From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755720Ab0AFKc3 (ORCPT ); Wed, 6 Jan 2010 05:32:29 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755661Ab0AFKc2 (ORCPT ); Wed, 6 Jan 2010 05:32:28 -0500 Received: from qw-out-2122.google.com ([74.125.92.27]:13277 "EHLO qw-out-2122.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755638Ab0AFKc2 (ORCPT ); Wed, 6 Jan 2010 05:32:28 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=doyxTu3js/wUi4GM//PY4Jeyfu8528mBfJ8rk+sWvnIv6ulB34kTD3nWCggaNc6SV0 VSDbW5xy4iTROG4pwmqAdkb7ykCqILxHwQN7N7GSeWY9YQDwlUP9ndOVfHnmeJwjIt78 zFQXMGsdoU3v1j5b53goz6YdQc2gY+vejtWuk= MIME-Version: 1.0 In-Reply-To: <4B445D3E.8080600@suse.cz> References: <4B445D3E.8080600@suse.cz> From: Eric Miao Date: Wed, 6 Jan 2010 18:31:13 +0800 Message-ID: Subject: Re: [PATCH] kbuild: include only necessary in scripts/Makefile.modbuiltin To: Michal Marek Cc: linux-kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 6, 2010 at 5:51 PM, Michal Marek wrote: > On 6.1.2010 07:26, Eric Miao wrote: >> scripts/Makefile.modbuiltin assumes either Kbuild or Makefile exists in >> every sub-directory, which is not true. > > It assumes what there is a kbuild file in each directory listed in > subdir-[ym] or obj-[ym]. For which directory is this not true? Did you > see an actual build failure? The same include is used in > scripts/Makefile.build, where it has been working fine for ages... > Well, it's in my tree outside mainline, I have to make this change to get it build. And'm wondering if that's a correct assumption.