From: Eric Miao <eric.y.miao@gmail.com>
To: Eric Miao <eric.y.miao@gmail.com>,
List Linux Kernel <linux-kernel@vger.kernel.org>,
linux@arm.linux.org.uk, Dinh.Nguyen@freescale.com,
s.hauer@pengutronix.de, grant.likely@secretlab.ca,
r.herring@freescale.com, linux-arm-kernel@lists.infradead.org,
daniel@caiaq.de, bryan.wu@canonical.com,
valentin.longchamp@epfl.ch
Subject: Re: [PATCHv2 01/11] arm: mxc: TrustZone interrupt controller (TZIC) for i.MX5 family
Date: Wed, 3 Feb 2010 07:09:57 -0800 [thread overview]
Message-ID: <f17812d71002030709i6ecbc374g30e2b1343455b650@mail.gmail.com> (raw)
In-Reply-To: <20100203132404.GC5252@k2>
On Wed, Feb 3, 2010 at 5:24 AM, Amit Kucheria
<amit.kucheria@canonical.com> wrote:
> On 10 Feb 02, Eric Miao wrote:
>> Hi Amit,
>>
>> Just some nit-picking review comments, see below:
>>
>> On Tue, Feb 2, 2010 at 9:16 PM, Amit Kucheria
>> <amit.kucheria@canonical.com> wrote:
>> > Freescale i.MX51 processor uses a new interrupt controller. Add
>> > driver for TrustZone Interrupt Controller
>> >
>> > Signed-off-by: Amit Kucheria <amit.kucheria@canonical.com>
>> > ---
>> > arch/arm/plat-mxc/Kconfig | 8 ++
>> > arch/arm/plat-mxc/Makefile | 3 +
>> > arch/arm/plat-mxc/tzic.c | 182 ++++++++++++++++++++++++++++++++++++++++++++
>> > 3 files changed, 193 insertions(+), 0 deletions(-)
>> > create mode 100644 arch/arm/plat-mxc/tzic.c
>> >
>> > diff --git a/arch/arm/plat-mxc/Kconfig b/arch/arm/plat-mxc/Kconfig
>> > index 8b0a1ee..59558c4 100644
>> > --- a/arch/arm/plat-mxc/Kconfig
>> > +++ b/arch/arm/plat-mxc/Kconfig
>> > @@ -62,6 +62,14 @@ config MXC_IRQ_PRIOR
>> > requirements for timing.
>> > Say N here, unless you have a specialized requirement.
>> >
>> > +config MXC_TZIC
>> > + bool "Enable TrustZone Interrupt Controller"
>> > + depends on ARCH_MX51
>>
>> This is the first patch of the base port, yet I cannot find any reference to
>> this ARCH_MX51, did you miss something?
>
> ARCH_MX51 is only introduced in the later patches that add the core i.MX5
> code. Since TZIC is not inherently dependent on i.MX5 (it's merely the first
> processor to use it), I thought of splitting it out as a separate patch.
>
> Does this break the sanctity of one self-contained change?
>
This breaks git-bisect, we may want a buildable kernel every commit if possible.
>> > + help
>> > + This will be automatically selected for all processors
>> > + containing this interrupt controller.
>> > + Say N here only if you are really sure.
>> > +
...
>
> Thanks for the review.
>
No problem, dude.
next prev parent reply other threads:[~2010-02-03 15:10 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-03 5:16 [PATCHv2 00/11] Base support for Freescale i.MX51 SoC platform Amit Kucheria
[not found] ` <cover.1265173480.git.amit.kucheria@canonical.com>
2010-02-03 5:16 ` [PATCHv2 01/11] arm: mxc: TrustZone interrupt controller (TZIC) for i.MX5 family Amit Kucheria
2010-02-03 6:23 ` Eric Miao
2010-02-03 9:45 ` Sascha Hauer
2010-02-03 13:24 ` Amit Kucheria
2010-02-03 15:09 ` Eric Miao [this message]
2010-02-04 0:54 ` Eric Miao
2010-02-04 17:09 ` Nguyen Dinh-R00091
2010-02-03 5:16 ` [PATCHv2 02/11] mxc timer: refactor timer code to use timer versions Amit Kucheria
2010-02-03 16:23 ` Grant Likely
2010-02-03 5:16 ` [PATCHv2 03/11] mxc: Fix Drive Strength Field in the IOMUX controller Amit Kucheria
2010-02-03 6:29 ` Eric Miao
2010-02-03 9:40 ` Sascha Hauer
2010-02-03 16:27 ` Grant Likely
2010-02-04 0:25 ` Amit Kucheria
2010-02-03 5:16 ` [PATCHv2 04/11] mxc: changes to common plat-mxc code to add support for i.MX5 Amit Kucheria
2010-02-03 6:43 ` Eric Miao
2010-02-03 9:49 ` Sascha Hauer
2010-02-03 13:38 ` Amit Kucheria
2010-02-03 15:16 ` Eric Miao
2010-02-03 16:35 ` Grant Likely
2010-02-03 5:16 ` [PATCHv2 05/11] mxc: Core support for i.MX5 series of processors from Freescale Amit Kucheria
2010-02-03 7:03 ` Eric Miao
2010-02-03 14:20 ` Amit Kucheria
2010-02-03 9:24 ` Russell King - ARM Linux
2010-02-03 11:04 ` Sascha Hauer
2010-02-03 20:07 ` Amit Kucheria
2010-02-03 16:08 ` Rabin Vincent
2010-02-03 5:16 ` [PATCHv2 06/11] mxc: enable support for Freescale i.MX5 series of processors Amit Kucheria
2010-02-03 5:16 ` [PATCHv2 07/11] mxc: Add support for the Babbage board Amit Kucheria
2010-02-03 11:10 ` Sascha Hauer
2010-02-03 5:16 ` [PATCHv2 08/11] fec: fix uninitialized rx buffer usage Amit Kucheria
2010-02-03 16:46 ` Grant Likely
2010-02-03 18:33 ` Amit Kucheria
2010-02-03 18:38 ` Grant Likely
2010-02-03 20:23 ` Grant Likely
2010-02-03 5:16 ` [PATCHv2 09/11] fec: Add LAN8700 phy support Amit Kucheria
2010-02-03 5:16 ` [PATCHv2 10/11] fec: Add ARCH_MX5 as a dependency Amit Kucheria
2010-02-03 5:16 ` [PATCHv2 11/11] mxc: Add imx51_defconfig Amit Kucheria
2010-02-05 6:48 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f17812d71002030709i6ecbc374g30e2b1343455b650@mail.gmail.com \
--to=eric.y.miao@gmail.com \
--cc=Dinh.Nguyen@freescale.com \
--cc=bryan.wu@canonical.com \
--cc=daniel@caiaq.de \
--cc=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=r.herring@freescale.com \
--cc=s.hauer@pengutronix.de \
--cc=valentin.longchamp@epfl.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®