From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f177.google.com (mail-il1-f177.google.com [209.85.166.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5259ABA45 for ; Wed, 19 Feb 2025 00:26:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739924784; cv=none; b=HQMub9dE4Eif1qMILu6hB0ZS/XPH7yOqK5hHwkyZM7d4f70Qs+wM8wn+dV5paI4U/0vzrWNzxFbRiyoLrpViC07zs4BlLex8ttZ46tcKrNFZeqnmBSOR0HfhSg9423nNSRCCPB1xnRv6wpMjeUG3VMsmoHDER9feUTVtzOBXzME= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739924784; c=relaxed/simple; bh=ZZo//4hODelh2c6BfzMbQ4+GU8HzqqhnXsMuuww/k94=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jUvnnUirM5oTE+vNw1u+f3ARhrU3RujvoXkGaojgMKsq7vTWgFVu0rTiP7Lq5AeoeNucx+G2B9bLI7uPipHUqi/Y/p2xyndoMbYg1dgILTKbsG9B8q7v/Y+8D7oJR8fUq/27Fhe+lh6FnNgOtqXC8I3Gf4g/puU5WhG+utIR4wM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=aG7B9L+F; arc=none smtp.client-ip=209.85.166.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="aG7B9L+F" Received: by mail-il1-f177.google.com with SMTP id e9e14a558f8ab-3d2a8c2467eso5588635ab.3 for ; Tue, 18 Feb 2025 16:26:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1739924781; x=1740529581; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fjj+IpI8XLPpxvRHICEn5KoIEt2tfZVRuk+n8D88sxs=; b=aG7B9L+Fvm+Umbxq8JRgiVWh2yWxh4ngIjz7szLfPrGmW1cTjqkML/Im9XTVzBDhR0 dwJVLeAkBd3/pz/ygWxhsr4l4CUhWa2Vyj2fyUyaQO198ROUm0p+dxLn1b2tgSlMEltO s5SOZUAZCdsRZ/SwHjVnlC5JOtxNnd2nMACnA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739924781; x=1740529581; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fjj+IpI8XLPpxvRHICEn5KoIEt2tfZVRuk+n8D88sxs=; b=koEi1MvfXdvP5dMkLafM8Ne6xQ5s9yIN+A1qUBUgc58R603PDLs06BY5dBldFFtIMT XkhBv4YHA4gZ71UjjCsApXmjmskZYo4o4bdPjJ0LBYuyxTCHFW7ZVVxczmVqq/9bxBVY y3K948bRPMGOV8Apw+/04GavCbnzUVNZ9Mluga3TTJVdCiL2wm99ONgntFoHjvCPV67D MQfMj8gVqr1jWZmKPUfjSlOuA+qh/7V2RbGhJWBExT+dvRrm/cPshjEVd+UanmounzkV 3HKxuzQ8wO8ZcU2Zpr84UrfGnFZv7LGrVQVlA/6bigUvUCiOOF8nN3R03lF6HhikK+ol K3dw== X-Gm-Message-State: AOJu0Yws15uao8rxf1VKjw4OagoKx+zntY8jKjzcQ3jlx48oDahNZOAY vA1QaJ1qQ/RfR9zhs9azqr29YN+8h+Busjj+s+PA0om5fPNqzV00nvYR8B086Ho= X-Gm-Gg: ASbGnctlybnD3FNxiPcZz6ouclGIxJFY3pGlB5VGvk9dig9/10VMB5FZzkMmiJNzE9y Lw7W2tHHyP3t0wV0v5zx6vwUC7aeJ1EK+UYUkOryA7wUa20cr1BYSAIxy1HBQ6+1fCu4uLy1IEb c1DPw1AvKgybPDOnFjryZhMJFaPr/x/HoXAsMnHbgSdyaTEEajgedYRacmLM7yiHSB+3O3Qxg/l YMBcidIxQ2+GQW3NcPANI6EkDQzRWtuSWXPjXali3+YCOfBgWaybNv3dwcJ1NPgRtNcMqdd8N0C eo9tMu0jTT9171OaWubwDctrvw== X-Google-Smtp-Source: AGHT+IGBtjCwi/pMAyxQDfD2N7tzHmX/V8YYMgyBPiwCm/1lyGQajHdbwZUK6F3MOWSk64oBzhQRLQ== X-Received: by 2002:a05:6e02:1d04:b0:3cf:b87b:8fd4 with SMTP id e9e14a558f8ab-3d2808d7ac6mr109126855ab.15.1739924781205; Tue, 18 Feb 2025 16:26:21 -0800 (PST) Received: from [192.168.1.14] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-3d18fb56f99sm26039815ab.50.2025.02.18.16.26.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Feb 2025 16:26:20 -0800 (PST) Message-ID: Date: Tue, 18 Feb 2025 17:26:19 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests: pid_namespace and pidfd missing include To: Alessandro Zanni , brauner@kernel.org, shuah@kernel.org Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Shuah Khan References: <20250128170447.12918-1-alessandro.zanni87@gmail.com> Content-Language: en-US From: Shuah Khan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2/12/25 17:24, Alessandro Zanni wrote: >> Running "make kselftest" results in several errors like these: >> >> pidfd_fdinfo_test.c:231:36: error: ‘MS_REC’ undeclared (first use in >> this function) >> 231 | r = mount(NULL, "/", NULL, MS_REC | MS_PRIVATE, 0); >> >> pidfd_fdinfo_test.c:231:45: error: ‘MS_PRIVATE’ undeclared (first use >> in this function); did you mean ‘MAP_PRIVATE’? >> 231 | r = mount(NULL, "/", NULL, MS_REC | MS_PRIVATE, 0); >> >> pid_max.c:48:9: warning: implicit declaration of function ‘umount2’; >> did you mean ‘SYS_umount2’? [-Wimplicit-function-declaration] >> 48 | umount2("/proc", MNT_DETACH); >> >> This patch adds the include in pidfd_fdinfo_test.c and >> pid_max.c files to find the variables MS_REC, MS_PRIVATE, MNT_DETACH. >> >> Signed-off-by: Alessandro Zanni >> --- >> tools/testing/selftests/pid_namespace/pid_max.c | 1 + >> tools/testing/selftests/pidfd/pidfd_fdinfo_test.c | 1 + >> 2 files changed, 2 insertions(+) >> >> diff --git a/tools/testing/selftests/pid_namespace/pid_max.c b/tools/testing/selftests/pid_namespace/pid_max.c >> index 51c414faabb0..972bedc475f1 100644 >> --- a/tools/testing/selftests/pid_namespace/pid_max.c >> +++ b/tools/testing/selftests/pid_namespace/pid_max.c >> @@ -11,6 +11,7 @@ >> #include >> #include >> #include >> +#include >> >> #include "../kselftest_harness.h" >> #include "../pidfd/pidfd.h" >> diff --git a/tools/testing/selftests/pidfd/pidfd_fdinfo_test.c b/tools/testing/selftests/pidfd/pidfd_fdinfo_test.c >> index f062a986e382..f718aac75068 100644 >> --- a/tools/testing/selftests/pidfd/pidfd_fdinfo_test.c >> +++ b/tools/testing/selftests/pidfd/pidfd_fdinfo_test.c >> @@ -13,6 +13,7 @@ >> #include >> #include >> #include >> +#include >> >> #include "pidfd.h" >> #include "../kselftest.h" >> -- >> 2.43.0 > > Hello, > > I'm reaching out to know if you have any comments or > feedbacks about this patch. > Christian, would you like me to pick this patch up? thanks, -- Shuah