From: Andrew Lunn <andrew@lunn.ch>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next v3 3/3] phy: dp83tg720: Add statistics support
Date: Thu, 22 Aug 2024 17:49:50 +0200 [thread overview]
Message-ID: <f18ac2ce-3bbf-4f12-8d0c-14429aaf9e40@lunn.ch> (raw)
In-Reply-To: <20240822115939.1387015-4-o.rempel@pengutronix.de>
On Thu, Aug 22, 2024 at 01:59:39PM +0200, Oleksij Rempel wrote:
> Introduce statistics support for the DP83TG720 PHY driver, enabling
> detailed monitoring and reporting of link quality and packet-related
> metrics.
>
> To avoid double reading of certain registers, the implementation caches
> all relevant register values in a single operation. This approach
> ensures accurate and consistent data retrieval, particularly for
> registers that clear upon reading or require special handling.
>
> Some of the statistics, such as link training times, do not increment
> and therefore require special handling during the extraction process.
>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
prev parent reply other threads:[~2024-08-22 15:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-22 11:59 [PATCH net-next v3 0/3] Add Statistics Support for DP83TG720 PHY Oleksij Rempel
2024-08-22 11:59 ` [PATCH net-next v3 1/3] phy: open_alliance_helpers: Add defines for link quality metrics Oleksij Rempel
2024-08-22 15:48 ` Andrew Lunn
2024-08-26 16:32 ` Jakub Kicinski
2024-08-26 17:12 ` Andrew Lunn
2024-08-26 19:57 ` Jakub Kicinski
2024-08-27 4:51 ` Oleksij Rempel
2024-08-27 18:33 ` Jakub Kicinski
2024-08-28 4:50 ` Oleksij Rempel
2024-08-28 20:34 ` Jakub Kicinski
2024-08-28 20:45 ` Andrew Lunn
2024-08-29 4:41 ` Oleksij Rempel
2024-08-22 11:59 ` [PATCH net-next v3 2/3] phy: Add defines for standardized PHY generic counters Oleksij Rempel
2024-08-22 15:49 ` Andrew Lunn
2024-08-22 11:59 ` [PATCH net-next v3 3/3] phy: dp83tg720: Add statistics support Oleksij Rempel
2024-08-22 15:49 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f18ac2ce-3bbf-4f12-8d0c-14429aaf9e40@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®