From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1DBD48632A for ; Thu, 12 Feb 2026 20:33:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770928413; cv=none; b=tLtrVKIGWDt6HAtrDzo+SQ9nOZ6YE5rXnr+VchluHur35jQIltm0oB4hu9MZIMKRAVEDyJS5bCHGbm9p6wemh0CTGrJZYmIIlbcP2e4KgzF+2Yj6o2xcA7g8TNKzBKaFM+p5LowmMYNkKLo5IRkV0zZqpHvybgJqsclgz6zBJgI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770928413; c=relaxed/simple; bh=GnVOYFS1dOs4ytjskGYRNbag345ulKuZ+IaQUN3bwJk=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=tjlMA/VQmF1HGlkAMkYEGUr2N++Ji9+WaseB4hXujQyx03nSK+zOp/4rGnxNducVlH92jIYlcA1UX2CGYyKCRKoS4/CUsMAHMfWMEWftJZSn8pYP0gdNhKXEU4t88/XjHItxWVRiRwgSov0GbOI+CfXuIHwct3qpY6LspJsrvsQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=irfRbt7K; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="irfRbt7K" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-436317c80f7so1552800f8f.1 for ; Thu, 12 Feb 2026 12:33:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770928410; x=1771533210; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=GnVOYFS1dOs4ytjskGYRNbag345ulKuZ+IaQUN3bwJk=; b=irfRbt7KDGQMMfULLyinfvoxkP/hz+aooshWz3GdSJHtAnlDu1FHGnHxAuOUqbTz+k m3bePX4J2eKz0Xdi2WFWc+s9uXzdzZk6E0O4CX+VaI/M6SXRPwt5P/BO0F84JLLDpEen Lmz7s9Wq8G71G0MFVKUg04VgfTOWEsAMnmGETOPAjhYnBWrFku4zvuv1YWBWXcmJYkGW ZHss5nV+gnmW+knAaVTX0+8z9SBpPWU3k0nvj/9NFqVLUb3sGBmXu4R4608KAXyfv9Dc qY6HzyBDELOwu/MCdwtaHhGy+d64ZhRNqwiQuTNSn+X0diclK5SEJ8wW8iERbYgJepsf qKuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770928410; x=1771533210; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GnVOYFS1dOs4ytjskGYRNbag345ulKuZ+IaQUN3bwJk=; b=Jb4wGs6Whd5HxhRtSGmsDmRb90RHf5/Xr61kRLlPN2OzKR799o0q+rN08Tkox4vzON E4tr1dOZF/Ic7yfEIYHkjKh4lP2PP/1QLhsZihH1cDkusuDANh3NZrxI7+qv4KDpanpA 1v/pSXdo2DNNzVBXexVtmxxbIFie4c2TzpibYdyCGACIacXcWa3mdKNDyWnqqLgUR9uH FDTUyNgYuhyhpZjitTpwkTDHowyAAptXkKC4JvZklOBa6uUV4AW83RBEZWHtABGFrCAc qsTJDsPicg8KpLhV3Ne1fNZY//zQlbn5GB7K9zDki8xKDGLNNcdoIEp7fallcvV/GurV lsvA== X-Forwarded-Encrypted: i=1; AJvYcCUKMPAs3GFCZQZ96P6o4zk0FNvXGF0IVJFs9osUTz6rhU8vKOGif8cIGDCSyRIItalY8jZXALJKR4OPxw4=@vger.kernel.org X-Gm-Message-State: AOJu0YyQWLdHW0YPUyehchvxuK0jgOU3Dt3CqrQAKfNl1lLp8HncrMjQ zX1EDNgbb90Mti7xjl4udmPlb0NvhsiqcCb1wdJSwarWfp/Rhllw70pE4986JzjIheg= X-Gm-Gg: AZuq6aK6UbSdt7Zxh20bUNkJbJP3EUqJEcj0HRJkte4Yztcf09t8htuqMG49bN6n4Km 0nERA/XE1UzFudvbXouXwlsH+qrp5wDUWZ9cSBp5fDgxS6jqP61LUtE+Yp7qqpdollQUuOOPsce 6ewj2+WQiP2LErC9YZb/pPHygwk91/E2ukvqBtWwJ/FQBApavgY0RJ2OC1UmdlWx2mTTQZYg6j+ FGHHZcUbLG9ZPmHHHovBFF2/Jyudma/Kdcrwd9N2XbLSixz6qcs7q+Lx4pgXYIU0uuIOvWGz/9G D4j9qGWh8l+I8xZjD7Nn48Qz5Hjvp/lL9/VsLKMmIyZbLM3ucOTMyz9wN9fXO/miLAAgRLZ+r7D RoIWPjHlYqTe1XIH2pZD8/wtkuMbr4xLXxYNFHFmTxmnHAlFxPlwyzhiwNxWMMfaCHmjrQ+PmDk FV5X3NQC9E8EbbMNfVVP2cHoFqhOPnkUZow7KnFSNR X-Received: by 2002:a05:6000:3113:b0:435:9e81:105e with SMTP id ffacd0b85a97d-43796b22389mr268014f8f.19.1770928410444; Thu, 12 Feb 2026 12:33:30 -0800 (PST) Received: from draszik.lan ([212.129.82.233]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43796ac9d77sm419495f8f.33.2026.02.12.12.33.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Feb 2026 12:33:30 -0800 (PST) Message-ID: Subject: Re: [PATCH v5 04/10] dt-bindings: soc: google: gs101-pmu: allow power domains as children From: =?ISO-8859-1?Q?Andr=E9?= Draszik To: Rob Herring Cc: Krzysztof Kozlowski , Alim Akhtar , Conor Dooley , Krzysztof Kozlowski , Ulf Hansson , Liam Girdwood , Mark Brown , Peter Griffin , Tudor Ambarus , Juan Yescas , Will McVicker , kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Marek Szyprowski Date: Thu, 12 Feb 2026 20:33:33 +0000 In-Reply-To: References: <20260205-gs101-pd-v5-0-ede49cdb57a6@linaro.org> <20260205-gs101-pd-v5-4-ede49cdb57a6@linaro.org> <20260211211229.GA3882182-robh@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-2+build4 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi Rob, On Thu, 2026-02-12 at 14:06 -0600, Rob Herring wrote: > On Thu, Feb 12, 2026 at 6:03=E2=80=AFAM Andr=C3=A9 Draszik wrote: >=20 >=20 > "google,gs101-pmu" represents some specific h/w. That h/w either has > power domains or it doesn't. So which is it? It does have power domains, they were missing during the initial submission= of bindings and DTS. >=20 > > The compatible doesn't change with these patches. So I'm not sure how t= o make > > your suggestion work without causing warnings for existing DTs. We can = either > > have an old incomplete DT+binding: >=20 > If this is considered incomplete, then you are going to complete it > and add the child nodes? If so, then the warnings are appropriate. Yes, I'm going to update the relevant DTS to include power domains. > If you were going to maintain both bindings forever, then you would > probably want a new compatible. Or just drop the properties from > required. Note that if you have child nodes with 'reg' and parent > missing #address-cells or #size-cells, then dtc will warn about that. > So it's not too important if the schema doesn't. Maybe the commit message or footer comment was clear enough, sorry for that= . I never intended to support both old (incomplete) and new DT. Dropping from required did cross my mind, as I also saw the warning about missing #address-cells or #size-cells in that case. Missing 'ranges' would still not trigger a warning, though. So does my above explanation mean you're OK with the patch as such? I can reword the commit message a bit to point out that while this binding update breaks existing DTS, I will update them as they're simply incomplete. Cheers, Andre'