From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA03AC4167B for ; Mon, 11 Dec 2023 08:31:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234022AbjLKIax (ORCPT ); Mon, 11 Dec 2023 03:30:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40212 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231668AbjLKIat (ORCPT ); Mon, 11 Dec 2023 03:30:49 -0500 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1293ED for ; Mon, 11 Dec 2023 00:30:53 -0800 (PST) Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-33340c50af9so4351756f8f.3 for ; Mon, 11 Dec 2023 00:30:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702283452; x=1702888252; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :references:cc:to:content-language:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=aa50lg1f1L1j1Qu85ixh6XDRwQUTw92mLWoqhKYIANY=; b=y3BIspGzKDS5Rv/iqi8Q5WEc7sxax6UV8i8fbRJ0jmoEkxbESiu1Z1/XSeuOa9osUj 2EioQiRK7ZX3ZBuT3won9jJAj1XyobR4YPJyfAbph+X27vlt5AhAuLayKy4k8memyJZe 0iW73mOXgcsxFPR2Vg3EIDHr6FxX//6wmpznqRm7Ix93rRZOLbWkXGUmGZ0Qb2DrZF9u zJcZi0Z0H+zThdTfPlj2jc5XP2o/JRYnS7GS9tYBo1c1CKphhx1N2sYaygAs1jSMbFDC V4oxT2Y67pZhGFFWYzxpBtvTACNvDaC7j2n8LtIP3hHUpCX5dn+GsVgFIIjWZA3FRjFg uXLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702283452; x=1702888252; h=content-transfer-encoding:in-reply-to:organization:autocrypt :references:cc:to:content-language:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=aa50lg1f1L1j1Qu85ixh6XDRwQUTw92mLWoqhKYIANY=; b=HZq2dqJj2i8cKo4uTPjAJA7avB2U/y/2V5brzx4PSf4dbiR3poAfL6o0yIxalNy12Q pwHaanRkUWElOloBnBscqyI77NrAkyUAhgTzR+hD2MqHh8lWPO5b5dWD7yFuGVJcZ9Ud hNG1NkBLkQm0x0qiz6dO3gss1P+Z87bb2coS735s+Lcu68PX6e68XV0HcGNxkx2vT2PG SDmER4PjL3y1/QCuBnaX23O6P6P1l6briB9/Dr0ufE/bsfyHJP40CQH9A1m+KzLC7xJS P4Y9a1xkQTVUJldNK0FA+lUc42LqRF1I4h7A9i4kT2ZrJk+rD+3aFDvU84+4mdJCRxH+ rJgg== X-Gm-Message-State: AOJu0YzUiXTjR0R4ofLSzqfHQqCq03jFVW0xVBcRkAirC1G+LJ8bwHSD Ba2YdgQ5YqHOl0HyFINSxJqG9Q== X-Google-Smtp-Source: AGHT+IEqGQDp5V3C58U8REJc2ghTmoyIHSfqVVl5gK8W9D+qbMUNHM1hrmw50DeNqGJeG57kLhR+tQ== X-Received: by 2002:a05:6000:111:b0:333:16:7a85 with SMTP id o17-20020a056000011100b0033300167a85mr1492063wrx.11.1702283452336; Mon, 11 Dec 2023 00:30:52 -0800 (PST) Received: from ?IPV6:2a01:e0a:982:cbb0:302e:e0c2:d42c:cb23? ([2a01:e0a:982:cbb0:302e:e0c2:d42c:cb23]) by smtp.gmail.com with ESMTPSA id g13-20020a056000118d00b003333d46a9e8sm7955435wrx.56.2023.12.11.00.30.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Dec 2023 00:30:51 -0800 (PST) Message-ID: Date: Mon, 11 Dec 2023 09:30:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH v5 06/10] drm/panel: Add Synaptics R63353 panel driver Content-Language: en-US, fr To: Dario Binacchi , linux-kernel@vger.kernel.org Cc: Amarula patchwork , michael@amarulasolutions.com, Daniel Vetter , David Airlie , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Sam Ravnborg , Thomas Zimmermann , dri-devel@lists.freedesktop.org References: <20231207141723.108004-1-dario.binacchi@amarulasolutions.com> <20231207141723.108004-7-dario.binacchi@amarulasolutions.com> Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro Developer Services In-Reply-To: <20231207141723.108004-7-dario.binacchi@amarulasolutions.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/12/2023 15:16, Dario Binacchi wrote: > From: Michael Trimarchi > > The LS068B3SX02 panel is based on the Synaptics R63353 Controller. > Add a driver for it. > > Signed-off-by: Michael Trimarchi > Signed-off-by: Dario Binacchi > > --- > > Changes in v5: > - Replace a 'return ret' with a 'goto fail' in the r63353_panel_activate() > > Changes in v4: > - Set the reset gpio to low in a single operation > - Remove duplicated code for prepare/unprepare callbacks > > Changes in v2: > - Adjust the timings of the panel reset > > MAINTAINERS | 6 + > drivers/gpu/drm/panel/Kconfig | 9 + > drivers/gpu/drm/panel/Makefile | 1 + > .../gpu/drm/panel/panel-synaptics-r63353.c | 363 ++++++++++++++++++ > 4 files changed, 379 insertions(+) > create mode 100644 drivers/gpu/drm/panel/panel-synaptics-r63353.c > > diff --git a/MAINTAINERS b/MAINTAINERS > index 788be9ab5b73..b82dc141d209 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -6874,6 +6874,12 @@ T: git git://anongit.freedesktop.org/drm/drm-misc > F: Documentation/devicetree/bindings/display/ste,mcde.yaml > F: drivers/gpu/drm/mcde/ > > +DRM DRIVER FOR SYNAPTICS R63353 PANELS > +M: Michael Trimarchi > +S: Maintained > +F: Documentation/devicetree/bindings/display/panel/synaptics,r63353.yaml > +F: drivers/gpu/drm/panel/panel-synaptics-r63353.c > + > DRM DRIVER FOR TI DLPC3433 MIPI DSI TO DMD BRIDGE > M: Jagan Teki > S: Maintained > diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig > index 99e14dc212ec..d018702be3dc 100644 > --- a/drivers/gpu/drm/panel/Kconfig > +++ b/drivers/gpu/drm/panel/Kconfig > @@ -735,6 +735,15 @@ config DRM_PANEL_SITRONIX_ST7789V > Say Y here if you want to enable support for the Sitronix > ST7789V controller for 240x320 LCD panels > > +config DRM_PANEL_SYNAPTICS_R63353 > + tristate "Synaptics R63353-based panels" > + depends on OF > + depends on DRM_MIPI_DSI > + depends on BACKLIGHT_CLASS_DEVICE > + help > + Say Y if you want to enable support for panels based on the > + Synaptics R63353 controller. > + > config DRM_PANEL_SONY_ACX565AKM > tristate "Sony ACX565AKM panel" > depends on GPIOLIB && OF && SPI > diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile > index d10c3de51c6d..f267d932c2b5 100644 > --- a/drivers/gpu/drm/panel/Makefile > +++ b/drivers/gpu/drm/panel/Makefile > @@ -74,6 +74,7 @@ obj-$(CONFIG_DRM_PANEL_SHARP_LS060T1SX01) += panel-sharp-ls060t1sx01.o > obj-$(CONFIG_DRM_PANEL_SITRONIX_ST7701) += panel-sitronix-st7701.o > obj-$(CONFIG_DRM_PANEL_SITRONIX_ST7703) += panel-sitronix-st7703.o > obj-$(CONFIG_DRM_PANEL_SITRONIX_ST7789V) += panel-sitronix-st7789v.o > +obj-$(CONFIG_DRM_PANEL_SYNAPTICS_R63353) += panel-synaptics-r63353.o > obj-$(CONFIG_DRM_PANEL_SONY_ACX565AKM) += panel-sony-acx565akm.o > obj-$(CONFIG_DRM_PANEL_SONY_TD4353_JDI) += panel-sony-td4353-jdi.o > obj-$(CONFIG_DRM_PANEL_SONY_TULIP_TRULY_NT35521) += panel-sony-tulip-truly-nt35521.o > diff --git a/drivers/gpu/drm/panel/panel-synaptics-r63353.c b/drivers/gpu/drm/panel/panel-synaptics-r63353.c > new file mode 100644 > index 000000000000..3f61fcdc550b > --- /dev/null > +++ b/drivers/gpu/drm/panel/panel-synaptics-r63353.c > @@ -0,0 +1,363 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Synaptics R63353 Controller driver > + * > + * Copyright (C) 2020 BSH Hausgerate GmbH > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include > +#include > + > +#include > +#include > +#include > + > +#include