From: "Lin Ma" <linma@zju.edu.cn>
To: "Duoming Zhou" <duoming@zju.edu.cn>
Cc: krzk@kernel.org, linux-kernel@vger.kernel.org,
davem@davemloft.net, gregkh@linuxfoundation.org,
alexander.deucher@amd.com, akpm@linux-foundation.org,
broonie@kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH V3 1/3] drivers: nfc: nfcmrvl: fix double free bugs caused by fw_dnld_over()
Date: Thu, 14 Apr 2022 13:50:28 +0800 (GMT+08:00) [thread overview]
Message-ID: <f198a12.102db.180269f7d00.Coremail.linma@zju.edu.cn> (raw)
In-Reply-To: <1d34425a0ea8a553a66dcf4f22ca55cc920dbb42.1649913521.git.duoming@zju.edu.cn>
Hello there,
Sorry here but actually I didn't "review" this patch but only offer some suggestions.
It seems that the current version of patch mainly focus on solving the data race. However, I'd prefer to make sure this function
> static void fw_dnld_over(struct nfcmrvl_private *priv, u32 error)
never be able to be called more than once. Maybe add some additional flag with lock is more appropriate.
Regards
Lin
next prev parent reply other threads:[~2022-04-14 5:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-14 5:31 [PATCH 0/3] Fix double free bugs and UAF bug in nfcmrvl module Duoming Zhou
2022-04-14 5:31 ` [PATCH V3 1/3] drivers: nfc: nfcmrvl: fix double free bugs caused by fw_dnld_over() Duoming Zhou
2022-04-14 5:50 ` Lin Ma [this message]
2022-04-14 5:31 ` [PATCH V2 2/3] drivers: nfc: nfcmrvl: fix double free bug in nfc_fw_download_done() Duoming Zhou
2022-04-14 5:47 ` Lin Ma
2022-04-14 5:31 ` [PATCH 3/3] drivers: nfc: nfcmrvl: fix use-after-free bug in nfcmrvl_fw_dnld_start() Duoming Zhou
2022-04-14 9:37 ` [PATCH 0/3] Fix double free bugs and UAF bug in nfcmrvl module Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f198a12.102db.180269f7d00.Coremail.linma@zju.edu.cn \
--to=linma@zju.edu.cn \
--cc=akpm@linux-foundation.org \
--cc=alexander.deucher@amd.com \
--cc=broonie@kernel.org \
--cc=davem@davemloft.net \
--cc=duoming@zju.edu.cn \
--cc=gregkh@linuxfoundation.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®