From: Nicolas Ferre <nicolas.ferre@microchip.com>
To: Horatiu Vultur <horatiu.vultur@microchip.com>,
<devicetree@vger.kernel.org>, <claudiu.beznea@microchip.com>,
<linux-kernel@vger.kernel.org>
Cc: <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
<UNGLinuxDriver@microchip.com>
Subject: Re: [PATCH] ARM: dts: lan966x: Add interrupt support for PHYs on pcb8290
Date: Fri, 30 Sep 2022 13:33:50 +0200 [thread overview]
Message-ID: <f19fa481-334b-4145-d49e-1260d3fde810@microchip.com> (raw)
In-Reply-To: <20220915064112.1935051-1-horatiu.vultur@microchip.com>
On 15/09/2022 at 08:41, Horatiu Vultur wrote:
> Add interrupt support for the PHYs found on pcb8290. They are all
> sharing the same interrupt line towards lan966x.
>
> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
Looks good to me:
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
> ---
> arch/arm/boot/dts/lan966x-pcb8290.dts | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/arch/arm/boot/dts/lan966x-pcb8290.dts b/arch/arm/boot/dts/lan966x-pcb8290.dts
> index af92bb12bc6cd..2ed53da914acb 100644
> --- a/arch/arm/boot/dts/lan966x-pcb8290.dts
> +++ b/arch/arm/boot/dts/lan966x-pcb8290.dts
> @@ -68,41 +68,57 @@ &mdio0 {
>
> ext_phy0: ethernet-phy@7 {
> reg = <7>;
> + interrupts = <24 IRQ_TYPE_LEVEL_LOW>;
> + interrupt-parent = <&gpio>;
> coma-mode-gpios = <&gpio 60 GPIO_OPEN_DRAIN>;
> };
>
> ext_phy1: ethernet-phy@8 {
> reg = <8>;
> + interrupts = <24 IRQ_TYPE_LEVEL_LOW>;
> + interrupt-parent = <&gpio>;
> coma-mode-gpios = <&gpio 60 GPIO_OPEN_DRAIN>;
> };
>
> ext_phy2: ethernet-phy@9 {
> reg = <9>;
> + interrupts = <24 IRQ_TYPE_LEVEL_LOW>;
> + interrupt-parent = <&gpio>;
> coma-mode-gpios = <&gpio 60 GPIO_OPEN_DRAIN>;
> };
>
> ext_phy3: ethernet-phy@10 {
> reg = <10>;
> + interrupts = <24 IRQ_TYPE_LEVEL_LOW>;
> + interrupt-parent = <&gpio>;
> coma-mode-gpios = <&gpio 60 GPIO_OPEN_DRAIN>;
> };
>
> ext_phy4: ethernet-phy@15 {
> reg = <15>;
> + interrupts = <24 IRQ_TYPE_LEVEL_LOW>;
> + interrupt-parent = <&gpio>;
> coma-mode-gpios = <&gpio 60 GPIO_OPEN_DRAIN>;
> };
>
> ext_phy5: ethernet-phy@16 {
> reg = <16>;
> + interrupts = <24 IRQ_TYPE_LEVEL_LOW>;
> + interrupt-parent = <&gpio>;
> coma-mode-gpios = <&gpio 60 GPIO_OPEN_DRAIN>;
> };
>
> ext_phy6: ethernet-phy@17 {
> reg = <17>;
> + interrupts = <24 IRQ_TYPE_LEVEL_LOW>;
> + interrupt-parent = <&gpio>;
> coma-mode-gpios = <&gpio 60 GPIO_OPEN_DRAIN>;
> };
>
> ext_phy7: ethernet-phy@18 {
> reg = <18>;
> + interrupts = <24 IRQ_TYPE_LEVEL_LOW>;
> + interrupt-parent = <&gpio>;
> coma-mode-gpios = <&gpio 60 GPIO_OPEN_DRAIN>;
> };
> };
--
Nicolas Ferre
next prev parent reply other threads:[~2022-09-30 11:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-15 6:41 Horatiu Vultur
2022-09-30 11:33 ` Nicolas Ferre [this message]
2022-10-26 7:39 ` Claudiu.Beznea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f19fa481-334b-4145-d49e-1260d3fde810@microchip.com \
--to=nicolas.ferre@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=claudiu.beznea@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=horatiu.vultur@microchip.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®