From: Markus Elfring <Markus.Elfring@web.de>
To: linux-clk@vger.kernel.org,
Michael Turquette <mturquette@baylibre.com>,
Santosh Shilimkar <ssantosh@kernel.org>,
Stephen Boyd <sboyd@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: clk: keystone: Clarification for a return value check in _of_pll_clk_init()
Date: Sat, 2 May 2020 18:48:16 +0200 [thread overview]
Message-ID: <f1a2a717-f89b-d4c4-02aa-dd106eaed0a9@web.de> (raw)
Hello,
I have tried another small script out for the semantic patch language.
This source code analysis approach points out that the function “clk_register_pll”
is called by the function “_of_pll_clk_init”.
https://elixir.bootlin.com/linux/v5.7-rc3/source/drivers/clk/keystone/pll.c#L153
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/clk/keystone/pll.c?id=690e2aba7beb1ef06352803bea41a68a3c695015#n153
A null pointer check is performed at this place.
The function “clk_register_pll” (from the same source file) can eventually
return the pointer “ERR_PTR(-ENOMEM)”.
Is there a need to take this special case also into account?
Regards,
Markus
reply other threads:[~2020-05-02 16:48 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1a2a717-f89b-d4c4-02aa-dd106eaed0a9@web.de \
--to=markus.elfring@web.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=ssantosh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®