From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C0BCEB64DD for ; Fri, 23 Jun 2023 05:27:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231501AbjFWF1W (ORCPT ); Fri, 23 Jun 2023 01:27:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230050AbjFWF1S (ORCPT ); Fri, 23 Jun 2023 01:27:18 -0400 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8089A1FF7; Thu, 22 Jun 2023 22:27:16 -0700 (PDT) Received: from kwepemm600003.china.huawei.com (unknown [172.30.72.53]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4QnQj372FRz1GF2P; Fri, 23 Jun 2023 13:27:03 +0800 (CST) Received: from [10.67.111.205] (10.67.111.205) by kwepemm600003.china.huawei.com (7.193.23.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 23 Jun 2023 13:27:12 +0800 Subject: Re: [PATCH RESEND v4 1/4] perf trace-event-info: Add tracepoint_id_to_name() helper To: Namhyung Kim CC: , , , , , , , , , , , References: <20230613033946.103515-1-yangjihong1@huawei.com> <20230613033946.103515-2-yangjihong1@huawei.com> From: Yang Jihong Message-ID: Date: Fri, 23 Jun 2023 13:27:12 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.111.205] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemm600003.china.huawei.com (7.193.23.202) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On 2023/6/21 6:35, Namhyung Kim wrote: > Hello, > > On Mon, Jun 12, 2023 at 8:41 PM Yang Jihong wrote: >> >> Add tracepoint_id_to_name() helper to search for the trace events directory >> by given event id and return the corresponding tracepoint. >> >> Signed-off-by: Yang Jihong >> Acked-by: Adrian Hunter >> --- >> tools/perf/util/trace-event-info.c | 11 +++++++++++ >> tools/perf/util/trace-event.h | 6 ++++++ >> 2 files changed, 17 insertions(+) >> >> diff --git a/tools/perf/util/trace-event-info.c b/tools/perf/util/trace-event-info.c >> index c24b3a15e319..a7901f4a6654 100644 >> --- a/tools/perf/util/trace-event-info.c >> +++ b/tools/perf/util/trace-event-info.c >> @@ -466,6 +466,17 @@ static struct tracepoint_path *tracepoint_id_to_path(u64 config) >> return NULL; >> } >> >> +char *tracepoint_id_to_name(u64 config) >> +{ >> + struct tracepoint_path *path = tracepoint_id_to_path(config); >> + char *buf = NULL; >> + >> + if (path && asprintf(&buf, "%s:%s", path->system, path->name) > 0) >> + return buf; > > I think we need to call put_tracepoints_path() before return. Yes, here need to free tracepoints path, will fix in next version. Thanks, Yang