mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Jain, Ayush" <ayushjai@amd.com>
To: Ayush Jain <Ayush.jain3@amd.com>,
	rostedt@goodmis.org, warthog9@eaglescrag.net
Cc: linux-kernel@vger.kernel.org, srikanth.aithal@amd.com,
	kalpana.shetty@amd.com
Subject: Re: [PATCH v3] ktest: Fix Test Failures Due to Missing LOG_FILE Directories
Date: Thu, 27 Mar 2025 15:46:37 +0530	[thread overview]
Message-ID: <f1a7c98a-9aeb-4e58-8d8f-d4e5c0e305d4@amd.com> (raw)
In-Reply-To: <20250307043854.2518539-1-Ayush.jain3@amd.com>

Hello Steven,

Hope you're doing well! Just a quick follow-up on this,
would appreciate your feedback when you get a chance. Let me know if you
need anything from me.

TiA,
Ayush

On 3/7/2025 10:08 AM, Ayush Jain wrote:
> Handle missing parent directories for LOG_FILE path to prevent test
> failures. If the parent directories don't exist, create them to ensure
> the tests proceed successfully.
>
> Signed-off-by: Ayush Jain <Ayush.jain3@amd.com>
> ---
>  tools/testing/ktest/ktest.pl | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/tools/testing/ktest/ktest.pl b/tools/testing/ktest/ktest.pl
> index 8c8da966c641..a5f7fdd0c1fb 100755
> --- a/tools/testing/ktest/ktest.pl
> +++ b/tools/testing/ktest/ktest.pl
> @@ -4303,6 +4303,14 @@ if (defined($opt{"LOG_FILE"})) {
>      if ($opt{"CLEAR_LOG"}) {
>  	unlink $opt{"LOG_FILE"};
>      }
> +
> +    if (! -e $opt{"LOG_FILE"} && $opt{"LOG_FILE"} =~ m,^(.*/),) {
> +        my $dir = $1;
> +        if (! -d $dir) {
> +            mkpath($dir) or die "Failed to create directories '$dir': $!";
> +            print "\nThe log directory $dir did not exist, so it was created.\n";
> +        }
> +    }
>      open(LOG, ">> $opt{LOG_FILE}") or die "Can't write to $opt{LOG_FILE}";
>      LOG->autoflush(1);
>  }


  reply	other threads:[~2025-03-27 10:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-07  4:38 Ayush Jain
2025-03-27 10:16 ` Jain, Ayush [this message]
2025-03-27 13:18   ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f1a7c98a-9aeb-4e58-8d8f-d4e5c0e305d4@amd.com \
    --to=ayushjai@amd.com \
    --cc=Ayush.jain3@amd.com \
    --cc=kalpana.shetty@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=srikanth.aithal@amd.com \
    --cc=warthog9@eaglescrag.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®