From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
rfoss@kernel.org, todor.too@gmail.com, agross@kernel.org,
andersson@kernel.org, mchehab@kernel.org,
hverkuil-cisco@xs4all.nl, laurent.pinchart@ideasonboard.com,
sakari.ailus@linux.intel.com, andrey.konovalov@linaro.org
Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 07/13] media: qcom: camss: Use >= CAMSS_SDM845 for vfe_get/vfe_put
Date: Fri, 18 Aug 2023 14:28:48 +0200 [thread overview]
Message-ID: <f1a8e7db-ce26-4bdc-beb6-00ae4f0baa78@linaro.org> (raw)
In-Reply-To: <20230817143812.677554-8-bryan.odonoghue@linaro.org>
On 17.08.2023 16:38, Bryan O'Donoghue wrote:
> From sdm845 onwards we need to ensure the VFE is powered on prior to
> switching on the CSID.
>
> Alternatively we could model up the GDSCs and clocks the CSID needs
> without the VFE but, there's a real question of the legitimacy of such a
> use-case.
>
> For now drawing a line at sdm845 and switching on the associated VFEs is
> a perfectly valid thing to do.
>
> Rather than continually extend out this clause for at least two new SoCs
> with this same model - making the vfe_get/vfe_put path start to look
> like spaghetti we can simply test for >= sdm845 here.
>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
Using >= here is veeery arbitrary and depends on the next person
adding a SoC in chronological, or used-tech-chronological order
correctly.. Not a fan!
Konrad
next prev parent reply other threads:[~2023-08-18 12:29 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-17 14:37 [PATCH v2 00/13] media: qcom: camss: Add parameter passing to remove several outstanding bugs Bryan O'Donoghue
2023-08-17 14:38 ` [PATCH v2 01/13] media: qcom: camss: Amalgamate struct resource with struct resource_ispif Bryan O'Donoghue
2023-08-17 14:38 ` [PATCH v2 02/13] media: qcom: camss: Start to move to module compat matched resources Bryan O'Donoghue
2023-08-18 12:22 ` Konrad Dybcio
2023-08-17 14:38 ` [PATCH v2 03/13] media: qcom: camss: Pass icc bandwidth table as a platform parameter Bryan O'Donoghue
2023-08-18 12:22 ` Konrad Dybcio
2023-08-17 14:38 ` [PATCH v2 04/13] media: qcom: camss: Pass remainder of variables as resources Bryan O'Donoghue
2023-08-17 14:38 ` [PATCH v2 05/13] media: qcom: camss: Pass line_num from compat resources Bryan O'Donoghue
2023-08-18 12:27 ` Konrad Dybcio
2023-08-17 14:38 ` [PATCH v2 06/13] media: qcom: camss: Assign the correct number of RDIs per VFE Bryan O'Donoghue
2023-08-18 12:26 ` Konrad Dybcio
2023-08-17 14:38 ` [PATCH v2 07/13] media: qcom: camss: Use >= CAMSS_SDM845 for vfe_get/vfe_put Bryan O'Donoghue
2023-08-18 12:28 ` Konrad Dybcio [this message]
2023-08-18 12:29 ` Konrad Dybcio
2023-08-19 14:56 ` Bryan O'Donoghue
2023-08-17 14:38 ` [PATCH v2 08/13] media: qcom: camss: Untangle if/else spaghetti in camss Bryan O'Donoghue
2023-08-17 14:38 ` [PATCH v2 09/13] media: qcom: camss: Improve error printout on icc_get fail Bryan O'Donoghue
2023-08-17 14:38 ` [PATCH v2 10/13] media: qcom: camss: Allow clocks vfeN vfe_liteN or vfe_lite Bryan O'Donoghue
2023-08-18 12:30 ` Konrad Dybcio
2023-08-19 14:49 ` Bryan O'Donoghue
2023-08-17 14:38 ` [PATCH v2 11/13] media: qcom: camss: Functionally decompose CSIPHY clock lookups Bryan O'Donoghue
2023-08-17 14:38 ` [PATCH v2 12/13] media: qcom: camss: Add support for setting CSIPHY clock name csiphyX Bryan O'Donoghue
2023-08-18 12:32 ` Konrad Dybcio
2023-08-19 14:21 ` Bryan O'Donoghue
2023-08-17 14:38 ` [PATCH v2 13/13] media: qcom: camss: Support RDI3 for VFE 17x Bryan O'Donoghue
2023-08-18 12:32 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1a8e7db-ce26-4bdc-beb6-00ae4f0baa78@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=andrey.konovalov@linaro.org \
--cc=bryan.odonoghue@linaro.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rfoss@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=todor.too@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®