From: Vasant Hegde <vasant.hegde@amd.com>
To: Dheeraj Kumar Srivastava <dheerajkumar.srivastava@amd.com>,
joro@8bytes.org, will@kernel.org, robin.murphy@arm.com,
linux-kernel@vger.kernel.org, iommu@lists.linux.dev
Cc: suravee.suthikulpanit@amd.com
Subject: Re: [PATCH v4 2/8] iommu/amd: Add debugfs support to dump IOMMU MMIO registers
Date: Wed, 19 Mar 2025 22:20:54 +0530 [thread overview]
Message-ID: <f1b0721c-b518-4bf6-9de9-f09369b85d0c@amd.com> (raw)
In-Reply-To: <20250317115830.3416-3-dheerajkumar.srivastava@amd.com>
Dheeraj,
On 3/17/2025 5:28 PM, Dheeraj Kumar Srivastava wrote:
> Analyzing IOMMU MMIO registers gives a view of what IOMMU is
> configured with on the system and is helpful to debug issues
> with IOMMU.
>
> eg.
> -> To get mmio registers value at offset 0x18 for iommu<x> (say, iommu00)
> # echo "0x18" > /sys/kernel/debug/iommu/amd/iommu00/mmio
> # cat /sys/kernel/debug/iommu/amd/iommu00/mmio
>
> Signed-off-by: Dheeraj Kumar Srivastava <dheerajkumar.srivastava@amd.com>
> ---
> drivers/iommu/amd/debugfs.c | 47 +++++++++++++++++++++++++++++++++++++
> 1 file changed, 47 insertions(+)
>
> diff --git a/drivers/iommu/amd/debugfs.c b/drivers/iommu/amd/debugfs.c
> index ff9520e002be..c61d52420c5f 100644
> --- a/drivers/iommu/amd/debugfs.c
> +++ b/drivers/iommu/amd/debugfs.c
> @@ -15,6 +15,50 @@
> static struct dentry *amd_iommu_debugfs;
>
> #define MAX_NAME_LEN 20
> +#define OFS_IN_SZ 8
> +
> +static int mmio_offset = -1;
Somehow I missed to catch this earlier. Here you have global variable but mmio
is defined per IOMMU. Shouldn't we track it per IOMMU ?
-Vasant
next prev parent reply other threads:[~2025-03-19 16:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-17 11:58 [PATCH v4 0/8] Introduce debugfs support in IOMMU Dheeraj Kumar Srivastava
2025-03-17 11:58 ` [PATCH v4 1/8] iommu/amd: Refactor AMD IOMMU debugfs initial setup Dheeraj Kumar Srivastava
2025-03-17 11:58 ` [PATCH v4 2/8] iommu/amd: Add debugfs support to dump IOMMU MMIO registers Dheeraj Kumar Srivastava
2025-03-19 16:50 ` Vasant Hegde [this message]
2025-04-08 5:41 ` Dheeraj Kumar Srivastava
2025-03-17 11:58 ` [PATCH v4 3/8] iommu/amd: Add debugfs support to dump IOMMU Capability registers Dheeraj Kumar Srivastava
2025-03-17 11:58 ` [PATCH v4 4/8] iommu/amd: Add debugfs support to dump IOMMU command buffer Dheeraj Kumar Srivastava
2025-03-17 11:58 ` [PATCH v4 5/8] iommu/amd: Add support for device id user input Dheeraj Kumar Srivastava
2025-03-17 11:58 ` [PATCH v4 6/8] iommu/amd: Add debugfs support to dump device table Dheeraj Kumar Srivastava
2025-03-17 11:58 ` [PATCH v4 7/8] iommu/amd: Add debugfs support to dump IRT Table Dheeraj Kumar Srivastava
2025-03-17 11:58 ` [PATCH v4 8/8] iommu/amd: Add documentation for AMD IOMMU debugfs support Dheeraj Kumar Srivastava
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1b0721c-b518-4bf6-9de9-f09369b85d0c@amd.com \
--to=vasant.hegde@amd.com \
--cc=dheerajkumar.srivastava@amd.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®