From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752192AbdLEU3Z (ORCPT ); Tue, 5 Dec 2017 15:29:25 -0500 Received: from mout.web.de ([212.227.15.14]:63631 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751809AbdLEU3U (ORCPT ); Tue, 5 Dec 2017 15:29:20 -0500 Subject: [PATCH 3/4] uwb/i1480/dfu/mac: Delete an error message for a failed memory allocation in fw_hdrs_load() From: SF Markus Elfring To: linux-usb@vger.kernel.org, Andrey Konovalov , Greg Kroah-Hartman , Johan Hovold Cc: LKML , kernel-janitors@vger.kernel.org References: <994a4a57-cfe6-91b5-5fc1-d4153cc5b0e6@users.sourceforge.net> Message-ID: Date: Tue, 5 Dec 2017 21:29:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <994a4a57-cfe6-91b5-5fc1-d4153cc5b0e6@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:hvRKNXjLo9u8wVikrMsIg4gN+tiE0fE29+Oktv1TQp/yutwroak iiE647XQem2PnPHomhtvYh0OwwvBv8DfwATflMyysorjgZPCAN1jBncl+KN1gW8UyHOzwyS GcEUjesDHF27jkjwFYQld8vnPRba7EIgsj4SBLM8RSMbZdPuV2ZBfmm5ubwQy2LnCHkkD5S 88lKx+uIZNmc+KANaXvXA== X-UI-Out-Filterresults: notjunk:1;V01:K0:qcfOC8t4WD4=:tWgIky6Hy0UTq45T2Z/5CM EeF4H/utzrQtuWnk4Qm7Wzk4VIWVQu4Fvj4Y9/tL5HrGHfl7P2XuT2I41JqRjsKgoLMeDA7GS C/4RDwNPdVV3LDcg6HMvcyDI1ZoiYGMe03k4VFeunyTJT7UQG63aoGfCzXMvcCtYWAfVw8XCQ FrZQVMw2SVzvrUZ8vLOKBnnHCoW+aB0qZWvLsT0RztSVGvcgxZvjE+zDyDxnCPj1lzAo/4WSP fe9SaYCJvzMyHCmbB+ZdZdNEKoXjNkhofgc7yQlvDNyfkcnK36+RpC3mLsP83d2K/88+ki/54 Z2Q/PxtWt7dGidUbY8TobiSoY0zPl+EYfRrJoSgrk4dezBlto93FphpADJ+3n/1s/1iuEJqcq e3Ws3JhMJVAuH0hk7IHIOBEf+FQv8fR7hUl2XGh1lG36kOh56HwBDVdNrWv1xHjuibEauvAl0 /2Pf4bHGFZSGsDAY77zbIcVHO8677+LAzAB+YD/ox1YCy1Q/tdvZigFc56pODE5+LWOlRQ31c h0oybTa7G+hyjxC2iLhArZ6K5TVXAMGlL5H+fKLKAr5+vMK/DfdbNhnm/oLX8//QDYy9OqXax 7fEMUQy7QGO+KAPpvhN0rYfFNW+Kvdt+EZkny0H9CzQT6MHBOOk4YiW05FZtOiTzA8vXMyCNs MdeGXDwCcHlA705z1p7Cj9LIme7EX8wxvyczK9aOZaAKMMDaMHnO1p1lpzS3ykc6cxHVfn3K6 VKIzNJm0XLpGkebiE+laOiLHn5wqXgIZ9UbtxBDdjiD8UnEW62VcBgftrX0Vb2GhoT/3IffWL xDICHNgQ0GDghbII/muRkapUgUKeBa+53B6yQnviSf8fEy2Hn8= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Tue, 5 Dec 2017 21:00:03 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/uwb/i1480/dfu/mac.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/uwb/i1480/dfu/mac.c b/drivers/uwb/i1480/dfu/mac.c index 6ec14f5fcde4..ee71973f47ad 100644 --- a/drivers/uwb/i1480/dfu/mac.c +++ b/drivers/uwb/i1480/dfu/mac.c @@ -123,11 +123,9 @@ int fw_hdrs_load(struct i1480 *i1480, struct fw_hdr **phdr, data_itr = data; data_top = (u32 *) (_data + data_size); while (data_itr < data_top) { - result = -ENOMEM; hdr = kmalloc(sizeof(*hdr), GFP_KERNEL); if (hdr == NULL) { - dev_err(i1480->dev, "Cannot allocate fw header " - "for chunk #%u\n", hdr_cnt); + result = -ENOMEM; goto error_alloc; } result = fw_hdr_load(i1480, hdr, hdr_cnt, -- 2.15.1