From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96EE727B4FA for ; Wed, 4 Feb 2026 13:24:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770211469; cv=none; b=iAbJlUWn8b7uQx61+i6XCXKUXAPx9CK2rSyW8uCPgm+oxMgEM8+RxGSzLB7FG8I7OWaIGd8Hn8q9EQqTeJto1/+NbvO1bwSm2NNdLBV1AwIEJsP4Cngbu/eFLzARtnSHOZMv1jLb/g/hDVvoR8uscs7xj6ZKM46ay83ZPcbFt5k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770211469; c=relaxed/simple; bh=IJJcghbJp7W5Sbr6vQDJGx2kFkXqXHDiyIdWsZbQ/Wc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=eBDVL7dWsLk7WwxfoQ2DSxw7TzgG1P0fNDkl6ujLvvfatI4L0uC+oSMS2DNiYWrwq2+yDSdZC8BdjULN0s0Jlt68DZbwan2LKuErV57YUv7shac6pLm8X89XBlVUTbtob9zTLt63DQqDoabCqMhYaFq52kUUF0hTm6jClfkFcOs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=CCRuGs/n; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=aF1959ga; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="CCRuGs/n"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="aF1959ga" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 614CIVkm096187 for ; Wed, 4 Feb 2026 13:24:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= WuO77aIUfSKWOvBwLlg7xgpIE0DC+kxmXo59U8JAZYQ=; b=CCRuGs/nTA00CNiu wmmkwe1Ng5FIwZQMGSu99HRzO4rgETVWk8R56YdFrsLWprwkbkGRtOwJ793ewEku F+1qIRYE4C0fFbpHkbDXJHgGwptxewFsJfRFj7KAByyZxfZOwHdMUVIi4fKvdjme Ak8vJvlpWNAuzkfulqoKgh3ctbtTSU4rdLtTO6me5jOE36H8XPIhYQSdUyDRd+SK 1O9+fYzlwPs3VBREI5Ta7SS01GNQ7ZbEh9ryskkP1GmeKloJStt+2sQtMUew92Fj Bld7QlJSWO65eoNLGHsqRout/zG3TIH2B93PwHDJG0TcnVo0MiZw/4nJj6XpZOVs vYHP+g== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c44kbge66-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 04 Feb 2026 13:24:28 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8c533f07450so180654185a.0 for ; Wed, 04 Feb 2026 05:24:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770211468; x=1770816268; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WuO77aIUfSKWOvBwLlg7xgpIE0DC+kxmXo59U8JAZYQ=; b=aF1959gauncYWrH8EbfrqEAY5Ui4/VUYCGJQJi7f39h4dmUcFZiupjtB9+Whu6rf46 k1QgyiufzJzBPW9086+LRocUD5OUy0UisfhcFASflUmgK5Tdx0cvMqOqVfwFPzl8e05s syDCOtXApr03HJ0f4WHUoPsVOMZADKYr57apa+mY6wy/GkWpFGThJ2cCkLg6g/KBZPN1 /pS3S52m0g3tPFJVE4oYLLs9hkhxcDK5qc5VWBbg7hsuGk5ECmr6RquEKjv2LhIqE2o+ XhtWuUPcL+ql15B6hhZrcl4bhnXdo486vn3s8JgVoJOg3cI+pkWilg0h+Ri4YTt5waER VlZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770211468; x=1770816268; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WuO77aIUfSKWOvBwLlg7xgpIE0DC+kxmXo59U8JAZYQ=; b=egiAtuuljA+CpORioXNILOGrP6gWdOHKSX3wwybwED0UqAtl/mcSkjEbijduz2hD8C k++6fANKqHJWyuAFjiDVLLJi7cvSUNjdwuK9fb8qC9FHrVXxOSdbolr0aAuvdG3sLkoN t9JysH1u3uwxqkYL8WgQq4u8LuwexOUehyqjfJpuIox8Eb/s4PTEe4c9f94cf0ayJpkS wZjMy4msdGkuFuBxcY0nY38kdii+pmQ9sqZ42wrvc7O9jG3PhUc44nodRT7GB14Ig+FF SBEJf0F9MKQTt+a/j+9OF0q4xiZZS+TmsIrUjmB/C3lSQHi7X1AMsyvHhReigaRmzls6 umuw== X-Forwarded-Encrypted: i=1; AJvYcCViH7depn/GsklxnGQF3bqGZ1dHcIiV8+J6nQPSn1MkfRMYeBabLoUIX20mVxtTg//5RNwNvRJq4fJANM0=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1tapUeP8GAw6CoVvWvoALQoDTEy4UCIJegCHKMwefrOXtI6G6 ZXBUxMtfYGxO2c3p0tKdi6VoLIP2ChgCtDWMhG+T5s9+5rJXweF9b/n4IDcE7BZM13ievOvXbKK /3+f/7Mooil08chGa1sWhQgL2e2zyHFVOdWNJqQvjd73AYlfka6zOd1jFqVSxXSwtkMg= X-Gm-Gg: AZuq6aL/ne4lLZLZHbcbVr1tZZ1/Gtw+BDU1+fTDgllE469s2pH0QySCQrgtUgfUvkk P9ki92oxk6DaqICo7ReqGTACvIKAkLSNWbOXKRlbsTQ+XpGWKs6FqUzQ6/4LVG2VFwA9Ps3dPmS ZHe8ZGWvcry7unIbo7BZCydUsz6CkckhUaytmH01v0xvIv2MIC5Y+k1SxeO3TW/UNI0Y1ngrGHv br5NdopnUxpWf+nwpXnjPwVoIc9e2vDEAr1RG+XyEUYvuO/HxU0hpSlouDnirK6xCXaO8bG0tUr y+wFBdqTSnksw7uQ3Z5ehNwrx7YLk/+VcVxus8frrKbzkyJVJzg/QAIZjk2vqtp1nN861CCEnOz eaak/1/8gxcmDOVoG2pNtQdUHg6F9f0ExAIpXSYk9+L8BI1uIrEz3yGsz2Z3m0iD7i0g= X-Received: by 2002:a05:620a:462c:b0:8c6:a707:dae7 with SMTP id af79cd13be357-8ca2f824267mr295290885a.1.1770211467915; Wed, 04 Feb 2026 05:24:27 -0800 (PST) X-Received: by 2002:a05:620a:462c:b0:8c6:a707:dae7 with SMTP id af79cd13be357-8ca2f824267mr295287485a.1.1770211467448; Wed, 04 Feb 2026 05:24:27 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8e9fd12380sm121795866b.21.2026.02.04.05.24.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Feb 2026 05:24:26 -0800 (PST) Message-ID: Date: Wed, 4 Feb 2026 14:24:24 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/9] usb: misc: qcom_eud: improve enable_store API To: Elson Serrao , Greg Kroah-Hartman , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Souradeep Chowdhury Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260126233830.2193816-1-elson.serrao@oss.qualcomm.com> <20260126233830.2193816-6-elson.serrao@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260126233830.2193816-6-elson.serrao@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: 0cO2uaTqDmbwFGQjBCS6iHD9QBQC7k5p X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjA0MDEwMSBTYWx0ZWRfX6C8ENPu4nRko /FMtF/V92QboIyG5D+UHdhHEGNXQysBsY3r+pvJXHxnj/W/Nct3NOlZ3O8LHQ7skwqSD+re3v7A oQFbCaEQbMENclbtu5qJH1/p5OyYVRccExC50Q4KHvX4GTTgZD99IYNUeeGA3Dn62iFKzLKmZD8 pku51ZakNVXUcJF2GlrqEz50SK/qGnsI9OjEmNCcj+K15llY64RPMscBqDmGguPrP2ITK3Aa12Y upyLrY1k4zGi886BxwlH30vUCOiPWBUKynGSq0yp1p+QHO+Yjq2fAnZfCv579nj39Heo4rJ04qd oJE/R+aD14rF9+KZB+QyuXHA5bo+BsSAOSKHsq7EoKA/N5gMk5m9qzaITqP3Q/Zk2M2tiAI9CQo HC5iLH1GRjrtFvYsJ0f0ECnyOLdzezCcG7Aw67VTr7AHpCZHOGoJl0bZo1TF8yWJIRREv1p/cKn ZmnQmzDXQh2oQ7IlrJg== X-Proofpoint-GUID: 0cO2uaTqDmbwFGQjBCS6iHD9QBQC7k5p X-Authority-Analysis: v=2.4 cv=HN7O14tv c=1 sm=1 tr=0 ts=6983488c cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=CZCQS8drd-N0E_F8xdgA:9 a=QEXdDO2ut3YA:10 a=zZCYzV9kfG8A:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-04_04,2026-02-04_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 phishscore=0 clxscore=1015 bulkscore=0 spamscore=0 adultscore=0 malwarescore=0 priorityscore=1501 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602040101 On 1/27/26 12:38 AM, Elson Serrao wrote: > Currently enable_store() allows operations irrespective of the EUD state, > which can result in redundant operations. Avoid this by adding duplicate > state checks to skip requests when EUD is already in the desired state. > Additionally, improve error handling with explicit logging to provide > better feedback. > > Signed-off-by: Elson Serrao > --- Reviewed-by: Konrad Dybcio Konrad