From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f174.google.com (mail-dy1-f174.google.com [74.125.82.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC38E2D94B5 for ; Wed, 20 May 2026 13:39:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779284357; cv=none; b=pE2IBcPlcLc4DlSMdu07jJHT2dGWqvpHdY/D6vgqczQbvM3CDjh5cjyJ7tRHmG3oXvaWJiu3mRvTp0BI9P/42nBzxJ6rECQsPsCZ6j5sfYpBKPHz4YQRUFXmNC/bdsdUdoiunmiyROlKpHFJZ8us3UcZc1UeInqNIROvE8lfA5I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779284357; c=relaxed/simple; bh=oaFdq8z1elXJ2kvvKaYfJ7RYMi53L4i1xZbiNUaix60=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mZ3sgxecRwSbJkUcTqgOYg00a6URfYIV+16qMROdiFy7POx34Pkpd5368Vwl18CGcd2O2sKpNJTvqmkMU5dv8KebEzpZ3ucvFMRe7HFvt2EwvkkdDoGEAvpinxspa6zmO/t4xE/XXtDU/xIOnnPOd0vNMnsZgYIoND8wNvAIB9s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LcA1+J23; arc=none smtp.client-ip=74.125.82.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LcA1+J23" Received: by mail-dy1-f174.google.com with SMTP id 5a478bee46e88-304106b1204so1292532eec.0 for ; Wed, 20 May 2026 06:39:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779284356; x=1779889156; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=XydIKcKEN1f8CDYCbBpZkqLXM7ghEeBzqIONwAcRzBw=; b=LcA1+J23VlhZIvCQK/z/UPJhLlLioKWNlYnB0G8F/sOzOvAE5gZyNeQrPHBQEDJGbN Kd5DaUcfnVSUvehSXP+qWmfLz2C0Krom4oFIzxJGXDeIpp0PRM8PwZ6Ym/wFwQBzycYd Pbwt1RXpGNj95YSbr8jh93T8KLDhfdhsU91HGiRmQY6oIR89y7clxLKm/Y1v1HmjUyhj QA7yw5FUW5kVVc4+zlRYX4ZQDHf+nVkJfnVO0Zlf/T9InwoGGl+4RX9t4BKZqRkDyGH4 /8JyDbXPXWAosHeUANAx6xvzrKYN8RLDOhqpymdciQZjCOmwepfYkI+ra+yxlAirvM3Q tPEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779284356; x=1779889156; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=XydIKcKEN1f8CDYCbBpZkqLXM7ghEeBzqIONwAcRzBw=; b=k0iX8Vn0dV+wQ3e068TDyshPzJL/FmnJAqERJsOiDYwaLpM6ae2VxI/sZGTSgkyOVy zlBA+Ho5OPu0jyTVxreRHZ82pf7e71OA//6o1K1NRyh1E0+308pVA9MHkPHpxY+6lbXC 39TS3+yBl3WLx6Dp3s7mh/kJXDcXHSxRWv3S8qvM5e08Zd6gaKa+jw7wdqC7Kq8AVFH9 peLK1+fXS6b9e7DfzgrJwgZ6Uoda3A2mcvlDxaishAM9VllSlN9xkm6UrBtpt6CML5ar BkVhrJQEwxysCO90JIONpWQVsTsOjmaZNO5xmGAvOqLF/gW8LyuHy7Mt8YyD/x0ERMXu Z1ew== X-Forwarded-Encrypted: i=1; AFNElJ/xk/eW1MSaLn6zACHHhNQ+L4iV0aM3cimfp+fDd/NnneaEOGVYrJy2Rlmw/3uOiRYIkYhuJ0e0AmuINFs=@vger.kernel.org X-Gm-Message-State: AOJu0YzYS0rFxwSqwuPue1LQb5KrkBegue+y8EBGQM8htZvjaIW1g1km Akgd4BXPPwlpLCWSOffP/zWf7Kw4+QdZqWXF7vBEbwmllBouPZ5RfbUS X-Gm-Gg: Acq92OG7nPXRxudoyEeDUPo4gftjXMogretxWfCaFz5Z79zp/aD/ea707tw0vlePSP5 XmGVgR0R2OSfzlZHMC2gUzBiEbqQ5fD6iA2zYRcgG9poeL78v3ybhnj6yOKga/LBDxS8zO4GsT3 BtRVyxO4fU81A5Yf+mYhNpFBK5yuWMQo8iNdNOImuNlUvrXhJ3H+P5W7dXDUleX8SefItl0PTal BNheh6u4W70uG2oswFKoNd7kv1eGFYT+KZT4IMADb2t5sCAfX3sfTeuYMmzixkKDIj2k/ZGQ/Hi 2LfKT1ABk477AZRbkrt/KpdZjKqfHgVD2duiDMpvWiUK7VDz3C+v2Mma0gRF18sEMQfx/G1PP1V XfafXF1ZkR6JnjYR93PAaYUDOai43w7dXMZ/ax2KL334fPSqrk9fIoIG7G7uGF1cj0GC+z3jETJ yQsLb/q84ND0TgOAp4z5EiBnyxn8CLY7mHDCIf X-Received: by 2002:a05:7300:a907:b0:2c5:220c:5670 with SMTP id 5a478bee46e88-3039818eec3mr9988056eec.2.1779284355819; Wed, 20 May 2026 06:39:15 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-302978ad18asm18456851eec.26.2026.05.20.06.39.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2026 06:39:15 -0700 (PDT) Sender: Guenter Roeck Date: Wed, 20 May 2026 06:39:14 -0700 From: Guenter Roeck To: Shubham Chakraborty Cc: Florian Fainelli , Jonathan Corbet , Shuah Khan , Broadcom internal kernel review list , Ray Jui , Scott Branden , linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 3/3] hwmon: raspberrypi: Fix delayed-work teardown race Message-ID: References: <20260516164407.25255-1-chakrabortyshubham66@gmail.com> <20260517080445.103962-1-chakrabortyshubham66@gmail.com> <20260517080445.103962-4-chakrabortyshubham66@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260517080445.103962-4-chakrabortyshubham66@gmail.com> On Sun, May 17, 2026 at 01:34:45PM +0530, Shubham Chakraborty wrote: > The delayed polling work rearms itself from the work function, so use > explicit delayed-work setup and cleanup instead of > devm_delayed_work_autocancel(). > > Initialize the delayed work with INIT_DELAYED_WORK() and register a > devres cleanup action that calls disable_delayed_work_sync() during > teardown. > > This addresses the concern raised during review about the polling work > being able to requeue itself while the driver is being removed. > > Signed-off-by: Shubham Chakraborty Applied. Thanks, Guenter