mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Laura Abbott <labbott@redhat.com>
To: "Zengtao (B)" <prime.zeng@hisilicon.com>,
	Dan Carpenter <dan.carpenter@oracle.com>,
	"Chenfeng (puck)" <puck.chen@hisilicon.com>
Cc: "sumit.semwal@linaro.org" <sumit.semwal@linaro.org>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"arve@android.com" <arve@android.com>,
	"tkjos@android.com" <tkjos@android.com>,
	"maco@android.com" <maco@android.com>,
	"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: 答复: [PATCH] ION: Sys_heap: fix the incorrect pool->gfp_mask setting
Date: Wed, 10 Jan 2018 16:00:51 -0800	[thread overview]
Message-ID: <f1c7c53d-0c7f-e66e-2d0f-f5d12486c627@redhat.com> (raw)
In-Reply-To: <678F3D1BB717D949B966B68EAEB446ED0C83060D@DGGEMM506-MBX.china.huawei.com>

On 01/09/2018 04:06 AM, Zengtao (B) wrote:
>> -----邮件原件-----
>> 发件人: Dan Carpenter [mailto:dan.carpenter@oracle.com]
>> 发送时间: 2018年1月9日 17:14
>> 收件人: Chenfeng (puck) <puck.chen@hisilicon.com>
>> 抄送: Zengtao (B) <prime.zeng@hisilicon.com>; labbott@redhat.com;
>> sumit.semwal@linaro.org; gregkh@linuxfoundation.org; arve@android.com;
>> tkjos@android.com; maco@android.com; devel@driverdev.osuosl.org;
>> linux-kernel@vger.kernel.org
>> 主题: Re: [PATCH] ION: Sys_heap: fix the incorrect pool->gfp_mask setting
>>
>> On Tue, Jan 09, 2018 at 11:30:09AM +0800, Chen Feng wrote:
>>>
>>>
>>> On 2018/1/9 18:43, Zeng Tao wrote:
>>>> This issue is introduced by the commit <e7f63771b60e> ("ION: Sys_heap:
>>>> Add cached pool to spead up cached buffer alloc"),
>>
>> Use the Fixes tag.
>>
>> Fixes: e7f63771b60e ("ION: Sys_heap: Add cached pool to spead up cached
>> buffer alloc")
>>
> Agree, thanks.
> 

If you're going to be fixing this, it would be good to
fix the other problems pointed out (stop with the
#define of the flags).

Thanks,
Laura

  reply	other threads:[~2018-01-11  0:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-09 10:43 Zeng Tao
2018-01-09  3:30 ` Chen Feng
2018-01-09  9:14   ` Dan Carpenter
2018-01-09 12:06     ` 答复: " Zengtao (B)
2018-01-11  0:00       ` Laura Abbott [this message]
2018-01-11  2:06         ` 答复: " Zengtao (B)
2018-01-11 18:29           ` Laura Abbott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f1c7c53d-0c7f-e66e-2d0f-f5d12486c627@redhat.com \
    --to=labbott@redhat.com \
    --cc=arve@android.com \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maco@android.com \
    --cc=prime.zeng@hisilicon.com \
    --cc=puck.chen@hisilicon.com \
    --cc=sumit.semwal@linaro.org \
    --cc=tkjos@android.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®