From: Ivan Orlov <ivan.orlov0322@gmail.com>
To: Javier Carrasco <javier.carrasco.cruz@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>, Shuah Khan <shuah@kernel.org>
Cc: alsa-devel@alsa-project.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests: ALSA: fix warnings in 'test-pcmtest-driver'
Date: Sat, 16 Sep 2023 23:16:26 +0400 [thread overview]
Message-ID: <f1c8d747-dcf6-a913-f6d5-37fdfe3e2be6@gmail.com> (raw)
In-Reply-To: <128d057c-0d60-418d-7129-093ea59b8870@gmail.com>
On 9/16/23 22:25, Javier Carrasco wrote:
> Removing an unused variable is actually removing a blank line from a
> logical point of view. Is an extra patch not overkill considering that
> it cannot affect the code behavior?
Well, no, it is not, as the line is not blank (nothing except removing a
blank line could be considered as blank line removal) :) And an extra
patch is not an overkill in case if you are separating logical changes.
However, rules may vary from one subsystem to another, so it is up to
Shuah to decide take this patch or not. My opinion is that such changes
should be separated into different patches.
prev parent reply other threads:[~2023-09-16 19:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-16 15:22 Javier Carrasco
2023-09-16 18:05 ` Ivan Orlov
2023-09-16 18:25 ` Javier Carrasco
2023-09-16 19:16 ` Ivan Orlov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1c8d747-dcf6-a913-f6d5-37fdfe3e2be6@gmail.com \
--to=ivan.orlov0322@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=javier.carrasco.cruz@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=perex@perex.cz \
--cc=shuah@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®