From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E398BCDB47E for ; Fri, 20 Oct 2023 11:23:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377056AbjJTLXu (ORCPT ); Fri, 20 Oct 2023 07:23:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376988AbjJTLXt (ORCPT ); Fri, 20 Oct 2023 07:23:49 -0400 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D08AC2; Fri, 20 Oct 2023 04:23:47 -0700 (PDT) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id E55A15C0C3D; Fri, 20 Oct 2023 07:23:44 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute5.internal (MEProxy); Fri, 20 Oct 2023 07:23:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1697801024; x=1697887424; bh=wp E9zAbVzd//8TsG30moNfOnsvMj+EYkAkZbMvhvoao=; b=hk1zlwoa5Jk84W10dt zWmZx4aJpGDQ6xaymLZL3MOxO4FNGDGJHVFPcx5aMJLVJn5cXz4Ay/i7yhCiWACh 86OVeuIb8x0O1Iuiv/qil1ttasrCaSCggTDvdhJnn4ZpeH8h7wbU0ae89n7WxxhF vlb/ssQbXaVcrG5Zl369oT05fONGRaNwoCDjDTOJtXxamyWsImti6cuyD7ziK9D1 1nv/7sodihqIx3kMnBkZ4L8D18yz3oKzV/crHIZkJYUQwkoMv2R+iPcHCzCD+AZl r8gyfvnCmUQQn9Zb0DjFognLtuh3TZkRyLBgP4ytj792YpaeYZP3ajgtuW4/bA6L BmJg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1697801024; x=1697887424; bh=wpE9zAbVzd//8 TsG30moNfOnsvMj+EYkAkZbMvhvoao=; b=XXMigayBs9CwyZww9675DooC525/F BuG4C2qbxz+qV42S38RoHo4+BBOweEo0fu3MIaIJ2XdlU3DZ72GJB38HIDW5iAwF f5+sBW5mgP9YXTw0+bLYSlF1L6mDwVvVt5wcHwY4mmEc7lltTlYHKDmEGoql3CAe pa9g+gV36ak+eddzmLkiEBBaWy7/t0LOMBNErYTiJru4uLZ0grneiWqK5EQkWiwW yb0755gtwFpradsNao75i3U9xoZCkngrnC3bQ4vk+nc8vO4yAApGZP1nLVnLyiZT oHQ73Cs2FdRFMKrh1d3Djhrv9tb0yTe15THfEtY29XJiLJdYC+heePZVQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrjeekgdefkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdetrhhn ugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrghtth gvrhhnpeffheeugeetiefhgeethfejgfdtuefggeejleehjeeutefhfeeggefhkedtkeet ffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrrh hnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id A322DB60089; Fri, 20 Oct 2023 07:23:44 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-1048-g9229b632c5-fm-20231019.001-g9229b632 MIME-Version: 1.0 Message-Id: In-Reply-To: <432f1c1c-2f77-4b1b-b3f8-28330fd6bac3@kadam.mountain> References: <71adfca4-4e80-4a93-b480-3031e26db409@app.fastmail.com> <432f1c1c-2f77-4b1b-b3f8-28330fd6bac3@kadam.mountain> Date: Fri, 20 Oct 2023 13:23:22 +0200 From: "Arnd Bergmann" To: "Dan Carpenter" , "Anders Roxell" Cc: "Naresh Kamboju" , "open list" , lkft-triage@lists.linaro.org, linux-fsdevel@vger.kernel.org, autofs@vger.kernel.org, "Ian Kent" , "Bill O'Donnell" , "Christian Brauner" Subject: Re: autofs: add autofs_parse_fd() Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 20, 2023, at 12:45, Dan Carpenter wrote: > On Fri, Oct 20, 2023 at 11:55:57AM +0200, Anders Roxell wrote: >> On Fri, 20 Oct 2023 at 08:37, Arnd Bergmann wrote: >> > >> > On Thu, Oct 19, 2023, at 17:27, Naresh Kamboju wrote: >> > > The qemu-x86_64 and x86_64 booting with 64bit kernel and 32bit rootfs we call >> > > it as compat mode boot testing. Recently it started to failed to get login >> > > prompt. >> > > >> > > We have not seen any kernel crash logs. >> > > >> > > Anders, bisection is pointing to first bad commit, >> > > 546694b8f658 autofs: add autofs_parse_fd() >> > > >> > > Reported-by: Linux Kernel Functional Testing >> > > Reported-by: Anders Roxell >> > >> > I tried to find something in that commit that would be different >> > in compat mode, but don't see anything at all -- this appears >> > to be just a simple refactoring of the code, unlike the commits >> > that immediately follow it and that do change the mount >> > interface. >> > >> > Unfortunately this makes it impossible to just revert the commit >> > on top of linux-next. Can you double-check your bisection by >> > testing 546694b8f658 and the commit before it again? >> >> I tried these two patches again: >> 546694b8f658 ("autofs: add autofs_parse_fd()") - doesn't boot >> bc69fdde0ae1 ("autofs: refactor autofs_prepare_pipe()") - boots >> > > One difference that I notice between those two patches is that we no > long call autofs_prepare_pipe(). We just call autofs_check_pipe(). Indeed, so some of the f_flags end up being different. I assumed this was done intentionally, but it might be worth checking if the patch below makes any difference when the flags get put back the way they were. This is probably not the correct fix, but may help figure out what is going on. It should apply to anything from 546694b8f658 ("autofs: add autofs_parse_fd()") to the current linux-next: --- a/fs/autofs/inode.c +++ b/fs/autofs/inode.c @@ -358,6 +358,11 @@ static int autofs_fill_super(struct super_block *s, struct fs_context *fc) pr_debug("pipe fd = %d, pgrp = %u\n", sbi->pipefd, pid_nr(sbi->oz_pgrp)); + /* We want a packet pipe */ + sbi->pipe->f_flags |= O_DIRECT; + /* We don't expect -EAGAIN */ + sbi->pipe->f_flags &= ~O_NONBLOCK; + sbi->flags &= ~AUTOFS_SBI_CATATONIC; /*