From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BA314CA276 for ; Mon, 6 Jul 2026 08:59:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783328376; cv=none; b=jnXsBxglH0pAp7Q/RmD3EnOKRlMQxYakZLyfI5A7Sy0/WkOLknUodzlvt4SW2n74ReZUajILPmpN+szYxufuNn0vZ3X5Z3SW3f1Dm1/wXP+bVMf2GoK4JMOmyBp3SVG2jH6IWhMSvl7ZmSDlBSEzFFamMhpOl7tfN7LkISViYe4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783328376; c=relaxed/simple; bh=VdMEYEfujKlTpTeNpLjtTw6Z44BxQKvYppPb1nAG52w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kpJCeLgfX8oqvV/FSDyQdxgzASL0zb0H2lMDmzflu7K9SZ1jcSdbjdVfhv/m9R9LeA3I9mvKLvlMqttlEoH5h4D/hglXcIhbtoN/7tz56nQF0g2LvBLbe8YNRIrUExejhfKlmsa2ZveT++kpFz8F+zexMG3HbX0sQIq0Ggr+Ca8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Axhgdy3T; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=gRZ1kbQH; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Axhgdy3T"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="gRZ1kbQH" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66683Zv84150737 for ; Mon, 6 Jul 2026 08:59:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ERl4wTZyWv1vQsjv06YEWQxA6mOQp5u853Smknj5ows=; b=Axhgdy3TrH2DtrJ8 weETRVwRSctUP3G+Iqa7U//pwX5JnIoG6vEPa5wrZuq0Wy3hmcKd6l8MXeOQj8bu WdMq9zkrIgNO66vIBa1vGQF1hlRBin/sFhk5w+wzn8LYN0PL0rD3yWNukq3C2IPI CG10qet/6xYlsfT0CyRbbPB5ZfRaXXfThWM7mQ7BnF31txQMtZ6dI/Chd51ZZIRM pILhbWV6PNLv3b9rQ8Fdm8Bia+o9612oGW/zVoCNVSAloq7tuMnCDl3YqDTjvPa0 6vEmuQfc43TMpZTsNxr0OrpJdtW9A+Gv/k31WFpv8Dw/2MVHGEVdiWp3CziEmTEV twlSKA== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f88h507de-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 06 Jul 2026 08:59:22 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-51c21be5bb4so20914841cf.0 for ; Mon, 06 Jul 2026 01:59:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783328362; x=1783933162; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ERl4wTZyWv1vQsjv06YEWQxA6mOQp5u853Smknj5ows=; b=gRZ1kbQHdlim31axhD/94OXzrAToTbYPL6UZikC7QpS4rqE4dIG1p5SpWTFtI3c62R oARqtJb49hmP+e65iDB2BAG6A3tHua84IU1WzDgw8x+kZQ3wrAdTq0X+uhhN1vMbrNgV 3oIIv9fCYAnshI4epOCXGId/ZLQsg6lSB4lyXfKCSmUmVBnbpVtQnsCemBoKXGEerL3S 7OiyuKqYkXHozaTkxgfKONa9GcIXgtwpu8Ui/DoKEdpSsKdYSFCLMXr4V4kbpcCH5qHm kIR1SraRQUBZ7UbpWvUAUw6I/Cji6RNru3NBmj2IoxFnsd+pNaK7Z9G2x2U93b9LO6Sz 7ESQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783328362; x=1783933162; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ERl4wTZyWv1vQsjv06YEWQxA6mOQp5u853Smknj5ows=; b=R5CsU5pvtWMKxuX1/urVYsz679VIAvc9lvVw4WxBcFxaDwp8kvcL8LqnmHiK2qjkD2 Ez+TAzX7XBaoyY/ktHVYOK/AmvlvEtha7rt40CmDKqjBiLYshRHFcOS18FIrHN/edm/D Pujx/O5/CaQfA+3iRzGjGmrcmVdbwIsIJzS//ouj536Frj9syC9XyKemkaagxFdEmVNw BA9VGSYO6n0uAFdRW+P25P9T0foarROg8oqFB7WLSQ4R6gu44WmwukIQ+mS01Nols3/A 20QQCjBfYHLDQx8AnbtEI5iXYPeEysHdh0tRWf18e1epXyj/NHkWyS2bGYVA+mQ/bbJA 5ZRg== X-Forwarded-Encrypted: i=1; AHgh+RrtpDBHHIHrGSKtiSMqzhOMNAMieIGf74w/Vv1Fgjq/WYU4zIaK+IFggk9BNUrnqjK3vc3h49fOCVTdnxk=@vger.kernel.org X-Gm-Message-State: AOJu0YwUpoWWJ+YRQhEo1VBTCQllsEskzyBcsd3PduOw4gS2YHJIc2ga t/gMI0WU4kseoUSBUjzJLgVaYJ6wreqy3AD6NCt6ll6MYJLleyQdWeN8sfRF+Rk0K5Zm7XlJuA0 mryhIp5UfO2B4S+JUrCvUyGo+obRwt0F5kpK+NoZEVZvrUO+nmJ0KzNM/w3MKWgroADs= X-Gm-Gg: AfdE7cmvhPSXGhbHjtdUqd1ZYuVi2ZKY5liNk8Pks/mtaZlirfRiI/P16IDkvIhHsCb zVFICYxCBxTSGCQQJ8htX9ZAOnX4Si+D+BKJ5Kz+5bKOOU/gAJBdEvaPT0vIbrngzZ6HnfsS6se nnqJ8zqmQW/1+Qb+LEFzum/YeOr1TSZgy7KTJloeIXVi5JmLgfh9sWWEsh4mV2um5jz2hrVVcCf spetbyBgzaXAH9GjFteKGLnJ66h9cWxbrbdWLPZhTBOHAMAE346PITD+m/W7Dch3x38UtJhg5Tq AumolKHj//FgvEJXJU2/eIeYJ43AdORTS/wUTkY9GuNUa2a3CM9RM9uCbkam76sm3flAEqhbNHn qIdwisExXCYiSOBO/jBqwOXdsKCPCbrW9GhQ= X-Received: by 2002:a05:620a:4405:b0:92b:7420:bd58 with SMTP id af79cd13be357-92e99e0f65bmr827908385a.0.1783328362398; Mon, 06 Jul 2026 01:59:22 -0700 (PDT) X-Received: by 2002:a05:620a:4405:b0:92b:7420:bd58 with SMTP id af79cd13be357-92e99e0f65bmr827904985a.0.1783328361880; Mon, 06 Jul 2026 01:59:21 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c12b60550desm702417466b.7.2026.07.06.01.59.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Jul 2026 01:59:21 -0700 (PDT) Message-ID: Date: Mon, 6 Jul 2026 10:59:17 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/8] drm/msm/a6xx: Add Adreno 722 support To: Akhil P Oommen , Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Will Deacon , Robin Murphy , "Joerg Roedel (AMD)" Cc: Puranam V G Tejaswi , Abel Vesa , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev References: <20260705-eliza-gpu-v1-0-c9f1354dbd29@oss.qualcomm.com> <20260705-eliza-gpu-v1-3-c9f1354dbd29@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260705-eliza-gpu-v1-3-c9f1354dbd29@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: bU8jWtI_yzW8YB49xd5l1fvWfroR9wDt X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA2MDA5MCBTYWx0ZWRfXzJK/7hSRSE43 1nFOdC7VdBtavPl/4oe4etT6FBq8Ho9B7GN2XZ5t+0b0niqHoktmQM9Gpzhltg96VkCEyjQdQUz dRx1eKCv+g67jfUotkdlXzOUb/LHJNs= X-Authority-Analysis: v=2.4 cv=EPU2FVZC c=1 sm=1 tr=0 ts=6a4b6e6b cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=ErYzCqf3RjAp607u9I4A:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA2MDA5MCBTYWx0ZWRfX7uHVdiMLfVdC Cpb0W2tyN9pCEVv28DQ/jvYxhSqGCSJ8ixUpr/DBI9nZaXIz7yRSKte2M7vJwiABCd2wT/7kVSC eG8L1u47z87NVb+AOjIc3eJSpJGuEp25Xs5nZNhJYNhywo8gJZNy4WgdI4yCImGdS0iO0+D5VzS DCBlM0JcZ81tZPU3uT8EpxTlVI+4A9ROlqjmcreblXxOklqqU6hwGzvbSMLjXNjn7B9AgQDpPO4 4wMAx9xsiPowTTl+QmFA3/XQ1m63FBRI1ltDNgjHFrihEyBd4WKElxxRZrQL3OPyDPxrclfRJO8 +0oMHbvQoCgH+uAS854N0lNhfgnu7O+K0+I/csrDZOj/ZUkGa++hvZw1L0JCiBrPWikcJXhdA7z JPKLXQLyUy/Dt0sRG6bFDZFJhyFxz/5Ci0mZxyeSQoid5dd+OGoKZdfhpy8wy1aJ35JtlRSrE2I 7/zfkzwSnmXpXAkALQw== X-Proofpoint-ORIG-GUID: bU8jWtI_yzW8YB49xd5l1fvWfroR9wDt X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-05_02,2026-07-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 malwarescore=0 spamscore=0 adultscore=0 suspectscore=0 phishscore=0 bulkscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607060090 On 7/5/26 10:14 AM, Akhil P Oommen wrote: > From: Puranam V G Tejaswi > > Add support for Adreno A722, a member of the GEN1 A7xx family. It is > derived from A730 and shares the same IP-level configurations: HWCG > registers, protected registers, GBIF CX registers and gmu_cgc_mode. > Major differences include lower cache/core counts, 1MB GMEM, no > Concurrent Binning & LPAC support. Some of the peripheral blocks like > RSCC are from A740 that resulted in updates to RSC layout. > > Add a new entry to the catalog to describe the usual configuration and > few additional fixup mainly due to missing CB/LPAC features and updated > RSC layout. > > Signed-off-by: Puranam V G Tejaswi > Signed-off-by: Akhil P Oommen > --- [...] > --- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c > +++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c > @@ -710,7 +710,8 @@ static void a6xx_gmu_rpmh_init(struct a6xx_gmu *gmu) > gmu_write_rscc(gmu, REG_A6XX_RSCC_HIDDEN_TCS_CMD0_DATA + 2, 0); > gmu_write_rscc(gmu, REG_A6XX_RSCC_HIDDEN_TCS_CMD0_ADDR + 2, 0); > gmu_write_rscc(gmu, REG_A6XX_RSCC_HIDDEN_TCS_CMD0_DATA + 4, > - adreno_is_a740_family(adreno_gpu) ? 0x80000021 : 0x80000000); > + (adreno_is_a740_family(adreno_gpu) || > + adreno_is_a722(adreno_gpu)) ? 0x80000021 : 0x80000000); This is a discrepancy vs kgsl (did you look at gen7_14 instead of gen7_17? did you test this on device?) [...] > /* The second spin of A7xx GPUs messed with some register offsets.. */ > - if (adreno_is_a740_family(adreno_gpu)) > + if (adreno_is_a740_family(adreno_gpu) || adreno_is_a722(adreno_gpu)) > seqmem0_drv0_reg = REG_A7XX_RSCC_SEQ_MEM_0_DRV0_A740; Likewise [...] > /* The second spin of A7xx GPUs messed with some register offsets.. */ > - if (adreno_is_a740_family(adreno_gpu) || adreno_is_a8xx(adreno_gpu)) > + if (adreno_is_a740_family(adreno_gpu) || adreno_is_a722(adreno_gpu) || > + adreno_is_a8xx(adreno_gpu)) > seqmem_off = 4; Likewise > > /* Make sure there are no outstanding RPMh votes */ > @@ -1100,7 +1104,8 @@ static void a6xx_gmu_rpmh_off(struct a6xx_gmu *gmu) > gmu_poll_timeout_rscc(gmu, REG_A6XX_RSCC_TCS3_DRV0_STATUS + seqmem_off, > val, (val & 1), 100, 1000); > > - if (!adreno_is_a740_family(adreno_gpu) && !adreno_is_a8xx(adreno_gpu)) > + if (!adreno_is_a740_family(adreno_gpu) && !adreno_is_a722(adreno_gpu) && > + !adreno_is_a8xx(adreno_gpu)) > return; Likewise You also need to if-out concurrent binning for this SKU Konrad