mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Rex-BC Chen <rex-bc.chen@mediatek.com>,
	AngeloGioacchino Del Regno 
	<angelogioacchino.delregno@collabora.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"krzysztof.kozlowski+dt@linaro.org" 
	<krzysztof.kozlowski+dt@linaro.org>,
	"chunkuang.hu@kernel.org" <chunkuang.hu@kernel.org>,
	"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>
Cc: "airlied@linux.ie" <airlied@linux.ie>,
	"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
	"Jason-JH Lin (林睿祥)" <Jason-JH.Lin@mediatek.com>,
	"Nancy Lin (林欣螢)" <Nancy.Lin@mediatek.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Project_Global_Chrome_Upstream_Group
	<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: Re: [PATCH v2 3/3] dt-bindings: mediatek: add ethdr definition for mt8195
Date: Tue, 10 May 2022 13:19:42 +0200	[thread overview]
Message-ID: <f1d477d2-13c4-2914-e520-4b2778e52e35@linaro.org> (raw)
In-Reply-To: <2a480ca0cf640e59a12d55435d02cb3892035a35.camel@mediatek.com>

On 10/05/2022 03:46, Rex-BC Chen wrote:
>>
>>
>> That's mediatek-drm, and this refers to the HDR block in the display
>> IP...
>>
>> Though, I have no idea of what "ET" stands for in "ETHDR", so, it
>> would be
>> definitely nice if MediaTek can write the meaning in the description,
>> like
>>
>> description:
>>    ETHDR (E??? T??? High Dynamic Range) is designed for HDR video and
>> ...blah
>>
>> Cheers,
>> Angelo
> 
> Hello Krzysztof and Angelo,
> 
> "ET" is actually meaningless.
> ET is one of mediatek departments and it's where the engine from.
> Therefore, I think we will add description like this:
>> ETHDR (ET High Dynamic Range) is a MediaTek internal HDR engine and
>> designed for HDR video...

Sure, sounds good, but then the node name should not have it. Please try
to find some more generic name (DT spec gives examples). Could be
display-controller, "hdr-engine", "isp".


Best regards,
Krzysztof

  reply	other threads:[~2022-05-10 11:19 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-09  4:42 [PATCH v2 0/3] MediaTek MT8195 display binding Rex-BC Chen
2022-05-09  4:43 ` [PATCH v2 1/3] dt-bindings: mediatek: add vdosys1 RDMA definition for mt8195 Rex-BC Chen
2022-05-09  7:31   ` Krzysztof Kozlowski
2022-05-09  8:45     ` Rex-BC Chen
2022-05-10  2:23       ` Rex-BC Chen
2022-05-10 10:28       ` Krzysztof Kozlowski
2022-05-10 10:37         ` Chen-Yu Tsai
2022-05-10 10:57           ` Krzysztof Kozlowski
2022-05-11  2:26             ` Rex-BC Chen
2022-05-11  7:21               ` Krzysztof Kozlowski
2022-05-09 12:20   ` Rob Herring
2022-05-30  7:06   ` Pavel Machek
2022-06-02  3:53     ` Rex-BC Chen
2022-05-09  4:43 ` [PATCH v2 2/3] dt-bindings: reset: mt8195: add vdosys1 reset control bit Rex-BC Chen
2022-05-09  4:43 ` [PATCH v2 3/3] dt-bindings: mediatek: add ethdr definition for mt8195 Rex-BC Chen
2022-05-09  7:35   ` Krzysztof Kozlowski
2022-05-09  8:54     ` Rex-BC Chen
2022-05-09 10:44       ` Krzysztof Kozlowski
2022-05-09 10:50         ` AngeloGioacchino Del Regno
2022-05-10  1:46           ` Rex-BC Chen
2022-05-10 11:19             ` Krzysztof Kozlowski [this message]
2022-05-11  2:29               ` Rex-BC Chen
2022-05-09 12:20   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f1d477d2-13c4-2914-e520-4b2778e52e35@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=Jason-JH.Lin@mediatek.com \
    --cc=Nancy.Lin@mediatek.com \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=airlied@linux.ie \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=chunkuang.hu@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=p.zabel@pengutronix.de \
    --cc=rex-bc.chen@mediatek.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®