From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933358AbcKIOrk (ORCPT ); Wed, 9 Nov 2016 09:47:40 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:56840 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932322AbcKIOrg (ORCPT ); Wed, 9 Nov 2016 09:47:36 -0500 Subject: Re: [watchdog] watchdog: mei_wdt: request stop on reboot to prevent false positive event To: Tomas Winkler , Wim Van Sebroeck References: <1478620552-30409-1-git-send-email-tomas.winkler@intel.com> Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, Alexander Usyskin , stable@vger.kernel.org From: Guenter Roeck Message-ID: Date: Wed, 9 Nov 2016 06:47:31 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1478620552-30409-1-git-send-email-tomas.winkler@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/08/2016 07:55 AM, Tomas Winkler wrote: > From: Alexander Usyskin > > Systemd on reboot enables shutdown watchdog that leaves the watchdog > device open to ensure that even if power down process get stuck the > platform reboots nonetheless. > The iamt_wdt is an alarm-only watchdog and can't reboot system, but the > FW will generate an alarm event reboot was completed in time, as the > watchdog is not automatically disabled during power cycle. > So we should request stop watchdog on reboot to eliminate wrong alarm > from the FW. > > Cc: > Signed-off-by: Alexander Usyskin > Signed-off-by: Tomas Winkler Reviewed-by: Guenter Roeck > --- > drivers/watchdog/mei_wdt.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/watchdog/mei_wdt.c b/drivers/watchdog/mei_wdt.c > index e0af52265511..40953fe4db86 100644 > --- a/drivers/watchdog/mei_wdt.c > +++ b/drivers/watchdog/mei_wdt.c > @@ -389,6 +389,8 @@ static int mei_wdt_register(struct mei_wdt *wdt) > wdt->wdd.max_timeout = MEI_WDT_MAX_TIMEOUT; > > watchdog_set_drvdata(&wdt->wdd, wdt); > + watchdog_stop_on_reboot(&wdt->wdd); > + > ret = watchdog_register_device(&wdt->wdd); > if (ret) { > dev_err(dev, "unable to register watchdog device = %d.\n", ret); >