From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7EC9338A2AF for ; Wed, 14 Jan 2026 10:13:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768385630; cv=none; b=lrQXwwK7QUVgaV0vj7GSjf6m+ZBuDTvm1W8Ot00PZA+diEXprksFWdYua8rXvlbUQKspDSwlxkxk2unn2n3XCw7mqHfXWNUSk5yxmTvV59yh7RZZ3vm6B0qk8uBvQpuMYG1bki+33rxUCp9VgfNXr2lebtECv4PYMw59aw8Tj6w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768385630; c=relaxed/simple; bh=gS6p3VPb8TgL1b84C2QzwQkRIIgF69omjemgWagmEfU=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=MCBmaJ8i2CEx8Zoc/A8JJsTew0vgBZRUF0+uTQJTM2W8WcbCLDctFsWavhgdRlXBNsNW/RJ3jXNRqwu0QOsJFoqWCbPJjARESPvnL53s9O7h0e8xu3L68Vc0dyftXOUrPviGBPfjTPFy9v8Inwo4TrxVgTd3Ertx5V82HWPLTB8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=mg+eXzpK; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="mg+eXzpK" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-430f5ecaa08so4066974f8f.3 for ; Wed, 14 Jan 2026 02:13:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1768385624; x=1768990424; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=3rWsPZP9GypSrCbApSvZEqf+XkVVNq8YSJJcRm2PJVg=; b=mg+eXzpKUFJRkrpZS3hJfdSdRR9RUhO36E+mPd4+CtcQknqTTU6ZyigI8M4vtBflVR uka32vu1Kh69Bk557KAZFitDFofeFkOisnLaYx+Wwjd7ZnKIBK9eWfbZ1GN5kAQap04f zsVxALPO+/uR9SYO6sRx5X4EpNewwjKzG+Yz/Nmxq9jIvJXCxAoHacsx64ms7LiNl2Uy 55HiBDgs35MHxLI16PumeZNp6B81Yc8aZrUBXZjcR6x+F53bsoKicxtQKjrtXVx7rJmz CQ4SwqKXy0VLiFK4IX6zhhYEEA5KK+ciFRybQu+MzjcQmlwpBjFIjc9dtf3MtBOHApd2 6IOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768385624; x=1768990424; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3rWsPZP9GypSrCbApSvZEqf+XkVVNq8YSJJcRm2PJVg=; b=px0+efvJpVRaVXIYMbVloL26YLSF0yu0S+k5xpyv3VbJ5d8A7/Fds25ic5BaKKHeBe EAUhtuSaNuNvHPAMc1t36Evbl7ng7ZI1RUkfcaoaQD4qrzDrWhr497hE1QubbSQIrUTn yw1t8TCdRG4OgirxiYZyczt2vdDouyVJ3SlI7tt5TTboM05sXDuMyuRJwTjZS1fifzCp vAR34qOMzNY8at3JiTiV6epZyWaqtY9ishV9vQvcvsNbOZvvXW8jvLIYkDBbb0St09Oq m8GFgNB8BxYFXoMXHv9ncPLHTkm4VDGN0LknX7u+kbYSD439V/hdgAU5pNb51LwrASX6 Zt6A== X-Forwarded-Encrypted: i=1; AJvYcCWCTisw/m/AyLbE5JP3LfEzBYHGHOq4BbO+6OkAhMV3x63oRC7UfpmyVhOxD+vVQX3Zcb/j+FVb3ohD2Vc=@vger.kernel.org X-Gm-Message-State: AOJu0YydgShek9V45DowCsT8+f/keOjcbyQorJ/pBZYcnc2RzoVmxtaw ibnxszGl41958lhlJnOBYl16X5SF5gz+P9lGbpRrDPjDDGvJmtvboNTH+Jn27EWPtRfsytSmr8k ncSDF X-Gm-Gg: AY/fxX4A1I3Wr4xudoCzefoYxXj7ApXhNX1xVz5LYyQoC+XkMB8IF8Pde2r+mppgDAi OEAdeOcek+9dvuFdaqaYPMimZxOaTxLfF7dabtwmYxLwg1qJ6r1p/AD35O8WD4T41p8nN5TbMpK bKgWow8QlCuJB/z4sVfDFxjF94GPeEoZBt4MraAkBMZM5QokzN+ePG0ATVIJRnX+zyomGzE8P2B HsmUEAKffAy03m2biMe4coVqYs3GL00bB6x25OqHpRYzC4UIJB0KzSoDKPDfNewNwGUZm3dua5r nK5MINboHxho+xopbc0t9/JX4kO80/n1rcxB4oEgwn51BKIjwGqG2C2wyNICz8Rexq6Z0M1uPWv ux4CwRy8U3N9xYOQjuRhmwtr28uAW7RM6qeNFE/jpOFyyRjmflXG86X9xz0omM641u13vpJVx52 50bn7RaR8Q3WcZohArutZ96+iZU8y6HozU3s4YrI7VKnSmzTfGCl+u3QYBEXCZLYs= X-Received: by 2002:a5d:64e5:0:b0:432:c37c:d840 with SMTP id ffacd0b85a97d-4342c4fc9afmr2140894f8f.20.1768385623587; Wed, 14 Jan 2026 02:13:43 -0800 (PST) Received: from ?IPV6:2a01:e0a:3d9:2080:b357:7e03:65d5:1450? ([2a01:e0a:3d9:2080:b357:7e03:65d5:1450]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd0e199bsm48795733f8f.16.2026.01.14.02.13.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Jan 2026 02:13:42 -0800 (PST) Message-ID: Date: Wed, 14 Jan 2026 11:13:41 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: neil.armstrong@linaro.org Reply-To: Neil Armstrong Subject: Re: [PATCH v2 1/2] dt-bindings: arm: amlogic: add Khadas VIM1S binding To: Nick Xie , Krzysztof Kozlowski Cc: khilman@baylibre.com, jbrunet@baylibre.com, martin.blumenstingl@googlemail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, xianwei.zhao@amlogic.com, christianshewitt@gmail.com, krzk+dt@kernel.org, robh@kernel.org, conor+dt@kernel.org, nick@khadas.com References: <20260114062549.68954-1-nick@khadas.com> <20260114062549.68954-2-nick@khadas.com> <20260114-slick-passionate-mink-216a3a@quoll> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 1/14/26 11:07, Nick Xie wrote: > Krzysztof Kozlowski 于2026年1月14日周三 16:51写道： >> >> On Wed, Jan 14, 2026 at 02:25:48PM +0800, Nick Xie wrote: >>> Add devicetree binding for Khadas VIM1S board based on >>> Amlogic S4 S905Y4 SoC. >>> >>> Signed-off-by: Nick Xie >> >> You still have the same From/SoB mismatch. > > OK, I will fix it in next version. > >> >>> --- >>> Documentation/devicetree/bindings/arm/amlogic.yaml | 6 ++++++ >>> 1 file changed, 6 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml b/Documentation/devicetree/bindings/arm/amlogic.yaml >>> index 08d9963fe9259..55663e0f7f915 100644 >>> --- a/Documentation/devicetree/bindings/arm/amlogic.yaml >>> +++ b/Documentation/devicetree/bindings/arm/amlogic.yaml >>> @@ -247,6 +247,12 @@ properties: >>> - amlogic,aq222 >>> - const: amlogic,s4 >>> >>> + - description: Boards with the Amlogic Meson S4 S905Y4 SoC >>> + items: >>> + - enum: >> >> Yopu already have exactly such enum with such description, so your >> compatible goes there. Look - it is called "Boards" - plural. > > The exist board aq222 is based on SoC S905X2, but the new board vim1s > is baed on S905Y4, > they are different SoC, so we need to put S905Y4 under S805X2 ? It depends, if the S805X2 and the S905Y4 are not compatible (different dies) and not the same die in 2 different but compatible packages, then a secondary compatible should be added like we did for amlogic,g12b or amlogic,meson-gxl. Neil > >> >>> + - khadas,vim1s >>> + - const: amlogic,s4 >> >> Best regards, >> Krzysztof >>