From: Joe Perches <joe@perches.com>
To: "Niklas Söderlund" <niklas.soderlund@corigine.com>,
"Dwaipayan Ray" <dwaipayanray1@gmail.com>,
"Lukas Bulwahn" <lukas.bulwahn@gmail.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"Andy Whitcroft" <apw@canonical.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
"Philippe Schenker" <philippe.schenker@toradex.com>,
"Stephen Rothwell" <sfr@canb.auug.org.au>
Cc: oss-drivers@corigine.com,
Simon Horman <simon.horman@corigine.com>,
Louis Peens <louis.peens@corigine.com>
Subject: Re: [PATCH v5] checkpatch: warn for non-standard fixes tag style
Date: Fri, 09 Sep 2022 19:52:31 -0700 [thread overview]
Message-ID: <f1d9e2953551455bdee615dbe84ce55efead1c39.camel@perches.com> (raw)
In-Reply-To: <20220909202534.1857709-1-niklas.soderlund@corigine.com>
On Fri, 2022-09-09 at 22:25 +0200, Niklas Söderlund wrote:
> Add a warning for fixes tags that does not fall in line with the
> standards specified by the community.
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -3140,6 +3140,47 @@ sub process {
[]
> + if ($ctitle ne $title || $tag_case || $tag_space ||
> + $id_length || $id_case || !$title_has_quotes) {
> + WARN("BAD_FIXES_TAG",
> + "Please use correct Fixes: style 'Fixes: <12 chars of sha1> (\"<title line>\")' - ie: 'Fixes: $cid (\"$ctitle\")'\n" . $herecurr);
BTW: Might as well add a --fix for Fixes:
if (WARN("...") &&
$fix) {
$fixed[$fixlinenr] = "Fixes: $cid (\"$ctitle\")";
}
prev parent reply other threads:[~2022-09-10 2:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 20:25 Niklas Söderlund
2022-09-10 2:52 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1d9e2953551455bdee615dbe84ce55efead1c39.camel@perches.com \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=corbet@lwn.net \
--cc=dwaipayanray1@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=louis.peens@corigine.com \
--cc=lukas.bulwahn@gmail.com \
--cc=niklas.soderlund@corigine.com \
--cc=oss-drivers@corigine.com \
--cc=philippe.schenker@toradex.com \
--cc=sfr@canb.auug.org.au \
--cc=simon.horman@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®