From: Krzysztof Kozlowski <krzk@kernel.org>
To: Roger Shimizu <rosh@debian.org>
Cc: Hongyang Zhao <hongyang.zhao@thundersoft.com>,
Andrzej Hajda <andrzej.hajda@intel.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Robert Foss <rfoss@kernel.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Vinod Koul <vkoul@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: display: lt9611: Support single Port B input
Date: Sat, 7 Feb 2026 10:35:36 +0100 [thread overview]
Message-ID: <f1e0d724-4d71-4003-b690-9bbab3a01cd0@kernel.org> (raw)
In-Reply-To: <CAEQ9gE=L3gsnyMtbVDbvHo-jhTSPw-8DJ7L2n9c=SKc6jOAHrg@mail.gmail.com>
On 07/02/2026 06:22, Roger Shimizu wrote:
> On Fri, Feb 6, 2026 at 2:56 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On 06/02/2026 10:49, Roger Shimizu wrote:
>>> On Thu, Feb 5, 2026 at 11:08 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>>>
>>>> On 05/02/2026 21:31, Roger Shimizu wrote:
>>>>> On Thu, Feb 5, 2026 at 5:07 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>>>>>
>>>>>> On Wed, Jan 28, 2026 at 07:15:45PM +0800, Hongyang Zhao wrote:
>>>>>>> The LT9611 has two DSI input ports (Port A and Port B). Update the
>>>>>>> binding to clearly document the port mapping and allow using Port B
>>>>>>> alone when DSI is physically connected to Port B only.
>>>>>>>
>>>>>>> Changes:
>>>>>>> - Clarify port@0 corresponds to DSI Port A input
>>>>>>> - Clarify port@1 corresponds to DSI Port B input
>>>>>>> - Change port requirement from mandatory port@0 to anyOf port@0/port@1,
>>>>>>> allowing either port to be used independently
>>>>>>>
>>>>>>> Signed-off-by: Hongyang Zhao <hongyang.zhao@thundersoft.com>
>>>>>>> Reviewed-by: Roger Shimizu <rosh@debian.org>
>>>>>>
>>>>>> Where did this review happen? V1 had this tag, but the patch was
>>>>>> completely different, which means you were supposed to drop the tag.
>>>>>> Please perform review in public.
>>>>>
>>>>> FYI. v2 was updated per review feedback, which is public:
>>>>> https://lore.kernel.org/all/7d9041a3-9d2b-469a-9fa7-89d53bbd2a1f@linaro.org/
>>>>
>>>> Link above is not from Roger, so again - where did the review leading to
>>>> above tag happen?
>>>
>>> Per feedback of v1, v2 was quite different than v1.
>>> For v2, it's close to initial review, because it looks like a new patch.
>>
>> Where was the review of v2 given?
>>
>> The patch is entirely different. I already said it. I also said what is
>> expected in such case. It is also documented:
>>
>> https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577
>
> Thanks for the guide!
> Yes, v2 was reviewed in private. I'll inform Hongyang to remove the
> tag when he sends the next series.
I am repeating myself but only because you really avoid answering.
I understand v1 was reviewed in private, before posting, but why are you
developing in private also v2? After v1 was posted, this should be all
done in public.
I have no trust in private reviews happening between versions.
Especially if v1 is send on 27th Jan and next day v2 is sent supposedly
reviewed in private. Really?
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-02-07 9:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-28 11:15 [PATCH v2 0/3] Add DSI Port B input support for LT9611 HDMI bridge Hongyang Zhao
2026-01-28 11:15 ` [PATCH v2 1/3] dt-bindings: display: lt9611: Support single Port B input Hongyang Zhao
2026-01-29 8:35 ` Neil Armstrong
2026-02-05 13:07 ` Krzysztof Kozlowski
2026-02-05 20:31 ` Roger Shimizu
2026-02-06 7:08 ` Krzysztof Kozlowski
2026-02-06 9:49 ` Roger Shimizu
2026-02-06 10:55 ` Krzysztof Kozlowski
2026-02-07 5:22 ` Roger Shimizu
2026-02-07 9:35 ` Krzysztof Kozlowski [this message]
2026-02-07 10:35 ` Roger Shimizu
2026-01-28 11:15 ` [PATCH v2 2/3] drm/bridge: lt9611: Add support for " Hongyang Zhao
2026-01-29 0:47 ` Dmitry Baryshkov
2026-01-28 11:15 ` [PATCH v2 3/3] arm64: dts: qcom: qcs6490-rubikpi3: Use lt9611 DSI Port B Hongyang Zhao
2026-01-28 11:26 ` Konrad Dybcio
2026-02-05 13:09 ` Krzysztof Kozlowski
2026-02-05 19:36 ` Roger Shimizu
2026-02-06 7:08 ` Krzysztof Kozlowski
2026-02-07 5:24 ` Roger Shimizu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1e0d724-4d71-4003-b690-9bbab3a01cd0@kernel.org \
--to=krzk@kernel.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=andrzej.hajda@intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hongyang.zhao@thundersoft.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=rosh@debian.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®