From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from SEYPR02CU001.outbound.protection.outlook.com (mail-koreacentralazon11013069.outbound.protection.outlook.com [40.107.44.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9DA121FDE31; Mon, 25 Aug 2025 11:46:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.44.69 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756122383; cv=fail; b=PVRCJo0U7Zl8hz0fWqotDdEunsE2Rg4fOLg0oxQrFfISPViEsWgacIdDdlILEziWLi+mX5/31VjJkPco2twG4tL4q27ydkaFlIkH0z7SYWwkf9R1x2cOk8hVTCb0+9GyvH8LMIS/glWxk7PnbAlGaw5xCF1b+Pvotz0zbl/O97w= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756122383; c=relaxed/simple; bh=bLtqWSULZ1+n+Wm/xxtNK/9hj4zV1Q/nJCU7m2UGGv0=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=ZTc/8Edh2HM2oCrWArA+n8kHD/dfqighknk5SuVQDwQdVx86jHJrJ595wLbzx1zH5uHbvnpLNAu2C9QJKTIdcR92BU335Or3cDzu1SXGEzNWOV1+3aGXaUJToVjLp8Y7XnLjpwf1qR8sY4zfjkihgAM4i46SQy0Pdon5iz5yaW4= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=SnveWUC6; arc=fail smtp.client-ip=40.107.44.69 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="SnveWUC6" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=OC2sPwgbWYKLEWoYW9wMpmTlaD8UAeaSHRjEc++PX9ks1kHUxQ74ZPetqQiLZBx8FTRyC1RVxl45PZM+lFZkw9kk/EhTOM8ocOlGKV6eOMR2EGKWFq7CC7nLJqSmp4cRAg6A0jkt6vzxBwc6AdVZODkyHAk1RtwwnlgwJl/3MT4oGIcQWsxNJe6vrQtpTi8neWytU/x7fqEoLqLvSCY+tRvjqw0a/6lgi4jlxr5Mc/CqKiHnbquVt3R8ALiuKg5r4jg3Mg/bP0ECk/gvD90qZ9u77yfIZn42NI+qTkzbNr2qblKm9MXOyOC1Qt54fU6ft0dbb+K6IEcBJBxegkMNqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bLtqWSULZ1+n+Wm/xxtNK/9hj4zV1Q/nJCU7m2UGGv0=; b=vYKZ+L8F0XgugCR+0A3QKs5/qGSZF+FAopM1ZMoQnpo0s90ppQ1L2HbmF2j+gMyMaiGHWFgRXEibxsFlt3n1+fGWFcnc0NnkSgrS93kNZJJ5BgvoyZpqWzQGxCGvIfN/UNRkfZWUqg8rYWfjLBoU6VlLVWJhtKq2JIgyGrt8p0YqUST0xL215x4DfF5BD85riaWLN6WhiqZTWbFUDqtMBKqGH9X4JK5705GnhzdP7yO9FJsun1MKb0iI/nWDJlnmObm9hnQ7pCCrbCiSMgtA7e/ldwpG4YcDPZCs87p3bPZXE5tlxw2bUby781Gonu2nymYcXz44j5I/Hp2+KeKT+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bLtqWSULZ1+n+Wm/xxtNK/9hj4zV1Q/nJCU7m2UGGv0=; b=SnveWUC6qT95djiaZ6dAMtYHufq1RI1ZOUqD/nA2UhI1n/Z6lgHMiv1EwFTtWrt2/zoG/eweeLp4Zj+LCwsshm4k3ZQJl/rtj8udBQKqhCtwrh3CyY/P5sXY7fneAJu8fT9r/GkanEgUiJK7e9Ctn44Nv3aWEsLJV/+Qg4zJ0AgHe93aY5bPcW3MgliF8Bfx+ySWLUfXxLxpRUgBq0NXcT/QxJaNRZmmmHAw+ifFbpCA8DTIyU+rr4wwKfWRlZGAaUnNZcNNKMFnr0z9josPnSnwn6AhfaQV6qrpSnMb4FK+u3fOaj1LOxZkk5Lh3V2A3W6zBZ1g/9gThEKYTfNQmg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SI2PR06MB5140.apcprd06.prod.outlook.com (2603:1096:4:1af::9) by SEZPR06MB5366.apcprd06.prod.outlook.com (2603:1096:101:7e::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9052.21; Mon, 25 Aug 2025 11:46:14 +0000 Received: from SI2PR06MB5140.apcprd06.prod.outlook.com ([fe80::468a:88be:bec:666]) by SI2PR06MB5140.apcprd06.prod.outlook.com ([fe80::468a:88be:bec:666%5]) with mapi id 15.20.9052.019; Mon, 25 Aug 2025 11:46:14 +0000 Message-ID: Date: Mon, 25 Aug 2025 19:46:11 +0800 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/3] ALSA: use vmalloc_array() to simplify code Content-Language: en-US To: Andy Shevchenko Cc: Jaroslav Kysela , Takashi Iwai , Philipp Stanner , Thorsten Blum , "open list:SOUND" , open list References: <20250824135521.590780-1-rongqianfeng@vivo.com> From: Qianfeng Rong In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SG2PR04CA0161.apcprd04.prod.outlook.com (2603:1096:4::23) To SI2PR06MB5140.apcprd06.prod.outlook.com (2603:1096:4:1af::9) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SI2PR06MB5140:EE_|SEZPR06MB5366:EE_ X-MS-Office365-Filtering-Correlation-Id: cfbee5fe-1f0e-4356-282d-08dde3ccfeda X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?bmZ6MWpmS1dRNmQzUWkvOTR3bHpwL1JEOGJPbFRJeFdsZnplTzhiRlI5SDRh?= =?utf-8?B?SjRMaDJmZmo4MGdxQitReDJPYzFFNXJ1aWVSQS9hMWhybklHMXdHZHcvUTQ5?= =?utf-8?B?ZkoxaHA4TllvQldOQ2VxaWxFYWFZY3NCUEcwM00wZ2VORlhYSFFDTkFWOWU5?= =?utf-8?B?TXVBU1c4NUh3N1Y3ZlFVbnFwVDNKUVh0VEpDSDVKaHZzVEFjM0FIcU5CZDhC?= =?utf-8?B?ZC9FU0RDanJBMlNkTnMycFVFbkJZY3BJSm1HUlEyWkM0Sk1vb3VDL0NpTnMx?= =?utf-8?B?RUgxazU1aGFJbkRMdlZMeG5FQXVMQ1poMUFaakV3TnU3WGpqUC9QazFvNitL?= =?utf-8?B?Q2ZCcFlQcUoyR2dnME9MS2xkbnJmZ0hsNDVMUmVyVk85VFMwNmlpRUhHaFR5?= =?utf-8?B?clZMVUIrVnk4a1Y0dWh6RFNhTTdwVjYxVUpRTGQvS255OWhXRWl6azhhOFAz?= =?utf-8?B?NHVYbWhwemdhZVoxQVpFbUJKTFpwSk5oNHUxSnhqTEhKK3VTTW4xK0ZSd0NU?= =?utf-8?B?THQvb1hkYk04eEkwdWpuL1Y5TkF0dEpTNWhGQjBIUVJCQkZjSXVPZG84QjFM?= =?utf-8?B?RW5SNzgwODdhbURwZkY2UE1Kd3FtZDFoem1tQlVDMlBHUnpEK0JKb2IwN09F?= =?utf-8?B?UjMyR3RMVGlOVXh3dTZUOHdnTnU4OEMzYTJST2NuZEs5NmNQQTFzMDJFU2NB?= =?utf-8?B?d0RGWGU1V2lVbG1LVVhyb1JEZ3ZaTTk2WENyblpwdXAyRkFZL1Z0c3BKUUth?= =?utf-8?B?RU4rUFZmdFplZEZZVnlxVVFwUHVmc2toRGFGYkJUNG41RlRua21sZWluOWNr?= =?utf-8?B?dkNQV214dzZiNXFJSVUvUGlWNnl4VGFDdi93MWZTZVBmZzBuKzdpczd6TEtp?= =?utf-8?B?cEw0WS9QWDlsTlBXQ2VRV0I0Uk0vSGp2azA1aFZIenJ3aUlrenhyT2o0Nmh1?= =?utf-8?B?aERGWS9WK3dyVHBtNnZhaTJRWng2enJVdWVkY3ZrQVNPUEVFUWcwWWZoUzdi?= =?utf-8?B?Zkl0VXJ0aTdxVlova21wVFl6THdIeCtOOWJvVkxtNnYxcm9wTnpiZjN5WVlO?= =?utf-8?B?WFh6Y0E4NTJJeTFLTDVYbmxGdGszaU5GR3pESDJtSlFwQ3JEeDB2bEhkN1Nx?= =?utf-8?B?eHQ2NnpzN2I0cGdFcnd1UnRxalNnTzV3TDl3bUxPTHoyaGZoUXFoV0xTMy94?= =?utf-8?B?UTRuamJ6NFpMWUhTSHg0aHFvZ2FXKzh3R2Q4aEljbW9LcnFISjhJREhFRDhW?= =?utf-8?B?UXBQUEozb2dYWVpVRExxTlhaeE0wTm8vcEZFVWc0dmpOOTA1cmN6amdsMjQ5?= =?utf-8?B?bFR5eFQ2Qi81L3p4M2ZHNHJGRU1tTkhtWWtRQVgxcWNKNXQ2UTNMcEQ5TElC?= =?utf-8?B?TnlyZndaOGlld2FGM2diSUw5Tk1XTjdTWURqdjZuWlVZZkprOXZubDlFb21l?= =?utf-8?B?OTBEdnJPMHBzSjBCWFg1L3FDaHBvSXNEZmRKOWlNUGc3MzlXdW44T0dEZEZT?= =?utf-8?B?K3NrSHhGNlFjYmlWeHRtY3cwelhhOE9GRElabURtYkdzaDdCZzd2NE5sTHpO?= =?utf-8?B?N3U3RG50Y2k0YWJrdDZWSlNqUkhWSmxDVXJIc0hDcmttWVZNQU9jV0hGTHpL?= =?utf-8?B?Z0RDMnhrWHNwY2o0MGIzbVJJWWE3TlVzWW5PUkxES2d6RFh1cGFDVTJoZWhk?= =?utf-8?B?cVIzUjVFbFRMNk9nMEpzNFAvQWdPZUsvSS9jdThDeXFEdE55cHhaVWNiR2V0?= =?utf-8?B?TEoxd1VoYjFNRWdmb0QzTDF1bU1FNExVblNsY2NwcWdwVkNJa2dTV2ljZkRK?= =?utf-8?B?SXY1djBHY0lhbmxhWVltSTNhZC9tckxPNWJQbXIxSHZJU2g5LzdDUVVRWHRu?= =?utf-8?B?SXFnbnYyVlhtY3o1WHE5ekJuM3JEOTc3SUJGK3VhdDFQK1JaWWg2L0ZxbG12?= =?utf-8?Q?HSQNmSCBEAQ=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SI2PR06MB5140.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UWw5eU9FR2dNVkZaOGoxbWpEV3BPbkVEclU3WWhONFd6dzBzOS8rcXF2MnJZ?= =?utf-8?B?bWpvVDdHcXNTS1JyVnJaWGVOcHdNZ2tqMzV1clBUWmU1Vjd6RVFBRzN6NXdv?= =?utf-8?B?RTFMTU9PQXUzWnJXZ3N3QmttZmtxUFBub3d0eE9XVTdwQ1gxQkx1VVlVQXht?= =?utf-8?B?Rkk5akVlNlJPMnhYSmVSdkxzaDQ1UXBFSGhQV3RPVWVKd2xNRVRBRVVQOE1k?= =?utf-8?B?VVVxK2l3VmQwMnJodlZNYURJQXlWRzdXRmJvYXBNSGkxdDZ3QldHclNoakxW?= =?utf-8?B?NUlkY05kSDRuRk9SWFZWaWFJY3VTcnpDWkt5VzVZOVczZHN2UGxMSVlmaFNH?= =?utf-8?B?c054SHVsTWNPRTB3TmNxM1o1MEJ5alVFYUFSSWtIeHg3a1M2MFlVUjgxTFN3?= =?utf-8?B?cU4wMTZKL0hjbUtpS1c0SVZRQjgyOGd3dkwxUzViOVVBQ1VsZWFqdWRJK3BR?= =?utf-8?B?Um9HUjNoVzdheE9ld2s3OGFWcXl5anBqUU93SEs5VmZLemJqWHExdFY2dXVh?= =?utf-8?B?cWlBWmt3UVdJL1ZjYW1STzBpSk9JUERYMGs1Nk00REM1dFFDY3Iza2YyV3BB?= =?utf-8?B?Yml2NW5QajJRZ3FUb2p5R2NqbzNTQncwemNjNGhkUG0yNWR6Vk05c2cycUFa?= =?utf-8?B?OHpxOGlrNTd2ZWtZV2RNRWpyaFdkdFFraW0xbDNkamIvdmZPM3BjbUxuMXJs?= =?utf-8?B?L0s4YUlxcjNqVDYydWlMdjM1eWNQWkFCMERydjlkQjJMV3dZbnptcFY4Rjha?= =?utf-8?B?UHpuTEx5ZENNeDBOQzBKQVdHUXZ1SHlyWFdVOEVsSnpJM253ZU9XRUlTdm5t?= =?utf-8?B?MjNXaWZjSmhaMGVoaUhqb2VpdjBwdjE2VnZJR093Sjd5VjNvcnNoRFBVNlhq?= =?utf-8?B?dnhRVlR4SFpJSWJhNmpSdTUrY1oyMm41NTNwdGt1S0E2UXhaQ2hlVmxpajNG?= =?utf-8?B?ZkNrazJZNm9MYTNxWjNFazVjYmw4ZnFtcW55TWlHNEhCdUQ0VDVORzZrbVMr?= =?utf-8?B?aElmRVN0NU1oOEdQSysvZTJoNUhDL0M2dGZBK2lvZ09EQUpJNy8zbTBuZWNp?= =?utf-8?B?RkdPUytJT3Y4cWhPa1ErdmNvS0tSRklpRDVIRVNNc2hQaGlsc0R6S0JBV1dH?= =?utf-8?B?THZqQWxISENiYmwxVTQ0dXNXdHhwT3QrUEFSVXVFRCt0K0xDNVBGYmhTakNt?= =?utf-8?B?ZmhwdVVHTEhFOThuOGl5ZU1selpWQk9DaUltNDNrbmd2RWJjK2ZUMU44bzFC?= =?utf-8?B?b3BERUJDcnR2RUtaSlVhSFI1VG8rbkRlRFdxVWNMZzdFSXpQSUdBbEx6czNE?= =?utf-8?B?YnJ2WG9zRE9TM21icktDQVgvVDQrdG5CWVFFRWJBeTN2SVNmZ0daQ3U4d1h4?= =?utf-8?B?Sk1yeU1MZXlVVm4zUkJzTVZIUTlydEJQM01kQXQydStSODF2b3ptVUNPd1hG?= =?utf-8?B?WUNhVFRoTkhHWm5tRnNRaDdSS0FzUDd4QVhYN0ljQ1o2RVNaQlhhY0V4bkkw?= =?utf-8?B?MnQzYUlVYkpGSDNKSWtaSnhVSzhYOTdGWjhRNkF0WWJhelEwd2E2eXhOSFhD?= =?utf-8?B?WUx3clBmZ0h4ZlNBaHVkOHJLajZqYXpzVGpIT01henpuN3hwV2gxNFM5OVFE?= =?utf-8?B?N0U5YlRMMHpTamNqcmhKS0MzUVhOSURxeE9yY3VCYVViNnllVFM3bXdEL3RZ?= =?utf-8?B?R3hqWXI4dUdqdFA1a04rNno4S1JPWkU4eUxScnVkYldiM1hadW1GRkwrbFB3?= =?utf-8?B?K3NWSi9JdmNicVhGKzNCYzFPa21acFFhQXpnMXpMTnN3WjZFTEZoYUlwd2kw?= =?utf-8?B?NTB6aFhDMUF5U2FoUXlrQVBsOU1uN21Kdm9ZejBzRURjTHVQcFp3b0JzeUJi?= =?utf-8?B?amJ3RUFQOEVJYlVIVDZNUVBqSzRGTDJRc2NXbHNzNlI4eFlWb29TajhYNWo0?= =?utf-8?B?elkvQkpvV3NRZjFwSHBWdit4eE5iN0dkMHZGZ2EvT1NuT3ZRUU5vZXEzc0tP?= =?utf-8?B?WDhrYmxlMXZzek8xc2oyUUFlVEx6U0NnS3RXYlZEMlR6VzdORkpSOHhnZGpp?= =?utf-8?B?YlYvYnc1bFlxV0dvS25OY3ZoS0E1eHF6empJSC91RVFmZzVEenM5SUw3eEww?= =?utf-8?Q?uesWX7jKkI3MAQAa6P/ISwbJb?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: cfbee5fe-1f0e-4356-282d-08dde3ccfeda X-MS-Exchange-CrossTenant-AuthSource: SI2PR06MB5140.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Aug 2025 11:46:14.6840 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Q2WFtScpKbUb3WkKcy2j/T2jU+YcqWd2fEBo+IMmYwow8mYyFFPU+paagoNf6Xt9qRzTuixt30itVw+1rsKrsw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR06MB5366 在 2025/8/25 19:01, Andy Shevchenko 写道: > On Sun, Aug 24, 2025 at 09:55:09PM +0800, Qianfeng Rong wrote: >> Remove array_size() calls and replace vmalloc() with vmalloc_array() to >> simplify the code and maintain consistency with existing kmalloc_array() >> usage. >> >> vmalloc_array() is also optimized better, resulting in less instructions >> being used [1]. > Have you considered using sizeof(*...) where it makes sense? I believe that sizeof(*...) should preferably not be mixed with this patch; instead, it should be addressed in a separate, independent patch that covers all relevant instances. Additionally, I understand that not everyone prefers using sizeof(*...), as it reduces readability.  What do you think, Andy? Best regards, Qianfeng >