From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E39E42F7456 for ; Fri, 14 Nov 2025 21:57:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763157477; cv=none; b=VK3+kEe8IMxtW2epUKY/r+PFq6uA+eVdi2gBzFPDP9hay5ury1SB/oMaXKeet/ufe6+CwE4L5cU9DwRu7y8zoeY/2yxGd0DzrK1m5G2m4XQwD4t4F0hiL1lvgkRLtmcCvfLcUE2eEzUjEQh46nGYFaxZD4DVZRlHr6swoqT9fts= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763157477; c=relaxed/simple; bh=NejWZ+/c7eJzxkqIJLUq6kOMKEwS/zt3yIZkcOMgvtc=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=hcr3I3gyBbjOGiz40nG+dNKNKcRXMTuxU/VOEpWkmN8AHB+0YAodiBVfodMBHMGaW5QBJ7HMxA+eVQooQY7ch6enqBSwOroGNKS20mvKj0PeqA4TDNtZIGsoAUV/3DMgg33R93BeT+502sJ0fHjbfL/gtnQCgOiu3VvOusX9Hdc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Dvq7y1MV; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Dvq7y1MV" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-42b3ac40ae4so1309484f8f.0 for ; Fri, 14 Nov 2025 13:57:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763157474; x=1763762274; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=vbNWOmHpdEa5AGQhVuTfa8JxnnOc6K3WrOIf2UEgPrA=; b=Dvq7y1MVyrcGRpWXca4pLx+e+8RdgNkKTnASp232YHPUasCie0xPxnL9F7Rp+RCoyq xo6RX4VzSZ6jRzeRNwOpeLA56N452p7lXYF25nlHdwaghfFqeXqbU3kaSwY1hnPqDJU/ W1GnX0hoRP+jen3R+qFgFgruB0GTikL++sxvCePrrLkMHK5LlOw5h6XpCGMgnVhsotEe 6uTF8cmdry+dmzj/0Wtw5EhxPuG0nR0OUHaW75A2EG9HIPKG99ObxHI1fv9w1UyBAwgS hQahVYFxliyUAnTbEXMEsbTII9+Uw01y5QzWXXhYKlkbJ+nIvTjHizQNefZM6N4EhhPC Vh1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763157474; x=1763762274; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vbNWOmHpdEa5AGQhVuTfa8JxnnOc6K3WrOIf2UEgPrA=; b=omQXfQPvKJZNB/Pt+7tFlhXJYM3ewlEvpHJwC/tow+fubuKlzZdz0tcih3eEWKcMj/ 5CyQxsaXfXdklSYMhFB432ikXsyOV2cKvZ/qGUCnoGfJeNvHgsFLOvxW7a9bUlDp0AnB 5uh+DmxixAlGZmd+rGydp/gsRKpYKbZXJtPQV7MdO0k02a7OL0IeWOcdyBRFf3YhPwyW PkcxHl2G/5nwclk7R/OZ4KMdlWOgYBXr1diAxBm3KGTvDV3XBpat0Onj/5rfURraVV2b mrbqNTyfK8GYnVZ0ynSbJqtYq4CV/kAYP0ucQgXK9Dp4UBqhiUcbUBM3xmM5qfMvEl9U Pzww== X-Forwarded-Encrypted: i=1; AJvYcCVgONO4sKc1yEVrt+b3vF0lQOTZP5ZmsSreeETyJY5KoP5PJOaXdirawteKhzmQzwq32h+Paf82BIzN7L4=@vger.kernel.org X-Gm-Message-State: AOJu0YyNlFvImdbj2EBN3mAJ39Wo8FEA87vlh51pUkV0gwSBoP/OQKHy 1RthvyfUesQS6qHlhZbEnizKcOYBrPCSJSM/bgHxHs3siiyD6hCvqOuFjz98DVAuU1c= X-Gm-Gg: ASbGncv06F6HVv1EM3DpBfJni4upVvUXaL+TbEmIfy8AGLauFDkzgc55omTOtSeyIT4 axyoaZJexorizciFnB8sAnG/6hhqBwkxxDDBYkcRTXfL2nZCWUvD9pQtUWCNpoK80om0DKUoj63 RRzS2CmzkSrydhcIi4bsymdlJwCpLkvIFH8KbW79jWZf2cBnJSePCh9Gx+WIHtY5I/LE6PsAjGB Mgcod1Hw9qv6zJIQVhydN18sQBWYf6cT3lVJicPSmN4Wp4l9WqXRrLMlRFAeRNTjiNtiRAMIn7A bTh5CcqTRpHBwHX+jWeTNcPcBEooXGvcN45pcUZ+BQyGO8uKM2hHF1fv325L+AgUlU4+LH4b81J xfmaXxxecBb+gwV8GjBX7RTBMtLdMuCpYFL+/RAcJxhl6o14VjFbVQRtjxOaSexDjdJUEvB3yvO A4el1+XWP/nP/DaDkfcg== X-Google-Smtp-Source: AGHT+IGZJojwQ5TmPU9HbJqZqk3xKa3jFdu0oCf5mPPHwz3sSCeo2kX4zEUPEQ1wpVk6J/TBJSkFkw== X-Received: by 2002:a5d:64e3:0:b0:42b:4061:2416 with SMTP id ffacd0b85a97d-42b59396ee3mr4481398f8f.52.1763157474288; Fri, 14 Nov 2025 13:57:54 -0800 (PST) Received: from draszik.lan ([212.129.82.217]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42b53f0b8d6sm12805516f8f.28.2025.11.14.13.57.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Nov 2025 13:57:53 -0800 (PST) Message-ID: Subject: Re: [PATCH v3 09/20] mfd: sec: Add support for S2MPG11 PMIC via ACPM From: =?ISO-8859-1?Q?Andr=E9?= Draszik To: Mark Brown Cc: Lee Jones , Tudor Ambarus , Rob Herring , Conor Dooley , Krzysztof Kozlowski , Liam Girdwood , Linus Walleij , Bartosz Golaszewski , Krzysztof Kozlowski , Peter Griffin , Will McVicker , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org Date: Fri, 14 Nov 2025 21:56:41 +0000 In-Reply-To: References: <20251103-s2mpg1x-regulators-v3-0-b8b96b79e058@linaro.org> <20251103-s2mpg1x-regulators-v3-9-b8b96b79e058@linaro.org> <20251113162534.GO1949330@google.com> <45ce203c03ec34631a0170baa7e4cf26c98b9cd3.camel@linaro.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-2+build3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi Mark, On Fri, 2025-11-14 at 16:46 +0000, Mark Brown wrote: > On Thu, Nov 13, 2025 at 09:43:29PM +0000, Andr=C3=A9 Draszik wrote: > > On Thu, 2025-11-13 at 16:25 +0000, Lee Jones wrote: >=20 > > > > +static const struct mfd_cell s2mpg11_devs[] =3D { > > > > + MFD_CELL_NAME("s2mpg11-meter"), > > > > + MFD_CELL_BASIC("s2mpg11-regulator", NULL, NULL, 0, S2MPG11_BUCKBO= OST), >=20 > > > This is highly irregular - in that, we've never done this before. >=20 > > > We're going to need to have Mark look at this. >=20 > > I did see this in at least one other driver, ah yes at least > > drivers/mfd/88pm860x-core.c is doing something similar, maybe others, t= oo > > (I stopped there). >=20 > Other drivers doing something doesn't mean that they're following good > practice.=C2=A0 We do also have drivers which have multiple identical IP > blocks and are passing in resources with base address, interrupt and > whatever for the IP blocks which is different to just passing a Linux > internal ID number through. That's fine and I understand that. My reply was in relation to that this has never been done before. I'm happy to use an alternative approach that can solve my problem, if ther= e is something that I have missed. I think the commit message for patch 8 describes the problem in better detail than this one. Cheers, Andre'