From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932312AbdEKT4J (ORCPT <rfc822;w@1wt.eu>);
        Thu, 11 May 2017 15:56:09 -0400
Received: from mout.gmx.net ([212.227.15.15]:56603 "EHLO mout.gmx.net"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1754095AbdEKT4H (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 11 May 2017 15:56:07 -0400
Subject: Re: [PATCH][V2] ethernet: aquantia: remove redundant checks on error
 status
To: Colin King <colin.king@canonical.com>,
        Pavel Belous <pavel.belous@aquantia.com>,
        "David S . Miller" <davem@davemloft.net>,
        David VomLehn <vomlehn@texas.net>,
        Alexander Loktionov <Alexander.Loktionov@aquantia.com>,
        Dmitry Bezrukov <Dmitry.Bezrukov@aquantia.com>,
        Dmitrii Tarakanov <Dmitrii.Tarakanov@aquantia.com>,
        netdev@vger.kernel.org
References: <20170511182940.18774-1-colin.king@canonical.com>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
From: Lino Sanfilippo <LinoSanfilippo@gmx.de>
Message-ID: <f1f0eb63-85cf-695f-e6db-4d58e5103e19@gmx.de>
Date: Thu, 11 May 2017 21:55:50 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <20170511182940.18774-1-colin.king@canonical.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:vTTp4d913z6vGCQ+uc6ZwVueNfNgXX8MSMp9YFIsXgaL2WFX8G7
 Qm0K45PEn0yBwA+xBPrvja1mVNU8JmozCe71w6IkPzjm5P6F8nmbr94kTBllZXqUjFBInKl
 wmuThNkXRpfSeanKr3QkW3feYZxzdhIcJXw8+cvraApQxApKIjSIrXYJxp4opKz3lG6nuHJ
 Ro3Pgokw2Dz6xxQkAJTAA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:TQ4N1gwycFQ=:zlhJ4uotl0JHbpq2NkZqok
 W+oIAtPaWL4JrUGNl+t3qJnVDgOdHRnmVWnt6lDgamoO4v+elHOyasWzFLZK8t35skoJ8fjYT
 KeiNZzRn/aYVGjwwI24ZySuLSk05F0AqJKcuGSho7w5WD/pY14ur2u+EmffAMlABN/cL+yhO8
 q+hz7VDG2JKZm10oNJMV+Y+U42ftu+tm2Xui8a8lYI0eETKYmKaePiH3h5qQwFQ2Hs5tgm85K
 74c7q7MC5llTBaga2K9ewOIQe3jinafxSPAqVi0Z3NzYLisurdwlCGMMvLPImX36Bg3AqRzCb
 v685wdbdvuVDyY9d1VWUGXUdZCWpVOFqkqRZ0CMTdJImqAZ9PkzWj840riT8P1ik5GqpWemTr
 5K1/3utaq+VqWEhumnHMaFbR5v11j9QvSLTZZumgSaE47AfP+PnSxECIt9CFzzrdHhHRPicDt
 HbWQYjHuXSyDS4cCbRyn2Zg8NSpIoH0eYPWsySQsgLBs+S8/pfH5sA3PP1TaDbKJLs/uNJ9pA
 Bi2iJwHy32pYjaoVSRpzewVBj/G/xMvjb8BIocWo5Cbm1w4fpULqJrG8/hmwBsg82gAvPRH/A
 Y1zz8AAZLyA0r2VdbSUEZj9BPLm2HulHkxE26+/or7pBV1b/Hbdx7jcsYeFSGhrwf8KEUDbHp
 Q3XRuEiDSm3qEGMSUoSUZ6PEaKnfq/0x0fIVujHpEOAKWpiiOd+QBPjLURR6u9fr2KqIQdMbF
 KrnQu6HtDNjDRGsK+27dujwPr7WaZ+2F0RJNV57/pDSCZrvnmT0hjkBFBHRuC8NAwFIGU9LCz
 LaIdarO
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

On 11.05.2017 20:29, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The error status err is initialized as zero and then being checked
> several times to see if it is less than zero even when it has not
> been updated.  It may seem that the err should be assigned to the
> return code of the call to the various *offload_en_set calls and
> then we check for failure, however, these functions are void and
> never actually return any status.  
> 
> Since these error checks are redundant we can remove these
> as well as err and the error exit label err_exit.
> 
> Detected by CoverityScan, CID#1398313 and CID#1398306 ("Logically
> dead code")
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

FWIW:


Reviewed-by: Lino Sanfilippo <LinoSanfilippo@gmx.de>

Regards,
Lino