From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754066AbcKITIt (ORCPT ); Wed, 9 Nov 2016 14:08:49 -0500 Received: from mail-eopbgr00106.outbound.protection.outlook.com ([40.107.0.106]:14418 "EHLO EUR02-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751496AbcKITIr (ORCPT ); Wed, 9 Nov 2016 14:08:47 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=aryabinin@virtuozzo.com; Subject: Re: [PATCH 2/2] kasan: improve error reports To: Andrey Konovalov , Alexander Potapenko , Dmitry Vyukov , , , , References: <12f35b740fd59901898c72c837600f5f4e1c2d56.1478632698.git.andreyknvl@google.com> CC: From: Andrey Ryabinin Message-ID: Date: Wed, 9 Nov 2016 19:23:18 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <12f35b740fd59901898c72c837600f5f4e1c2d56.1478632698.git.andreyknvl@google.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [195.214.232.10] X-ClientProxiedBy: HE1PR0902CA0015.eurprd09.prod.outlook.com (10.171.90.25) To AM5PR0801MB2051.eurprd08.prod.outlook.com (10.168.158.141) X-MS-Office365-Filtering-Correlation-Id: f36db8b3-259a-41b4-bf6a-08d408bcad36 X-Microsoft-Exchange-Diagnostics: 1;AM5PR0801MB2051;2:2KowdX6h+8gtZ8DO97OUFsIAKHyJJRsWB0eDpcIYnZlLxX+KXe7N88efrAWoL0JeVENmH2CGjI7gJFrYO5qmpYTMpFbQ+uFcOY+Iwiwe1E5pCpvYg1gIrd+OO5JEjSAfLp5JgmKXhHMRq7yJfnAK+adwK2JLsaPf/YRT72vch3MEA+VURRCYvChhVUjtLZovtyDJRMHBwgNd9ZP+FBbk6Q==;3:rk3HE7wwWqB2PbkWppnoPH/jf7PY/NK4t4KaU8EAarYLGGJv9e4dr/jvdcIe726ZZg2szgXVEV5XBz7rJKLaQOVHYOehHQHIS57f/pZiEIDOKM52gXPnBSlwtiUgTIz5U4fP9GQUyBDRusqR25fpig==;25:4KBC2OSHS1yLGxnBPF/ZspwOTXVeS0d1J4A/80PXI8IRuatdBcgYfsvfWkXVQt+3XdNLTFOpfLk5vRHqfNhNpFVcQB0xSPyI9uMnlCjvUz5A7lvs6cHFPONh21J/n6B4Ds9FYpJ4kVhLOZryU9xyesjlNzTz5Qv4wNEw8vWfPqKAs7jzEi+TXJbi8N+SFGqvtsWoACQQBuyGBpTuQQVAr/x/5rYTRedoosxSLA5Jm4Cu2hiGmQI+M95gawlREKdfbRYc0hTOFsrSrzHiGAISkzVvlUNJFH2r+F32uexryjFld8/QBBFYgP5vT0gqxcYWMdVEufiXzvAZpgHynRxPviIS2h5kyg/9ckvHFPy39oH04VVT8VTHL6XXNF2+8hdxVzXUJ0fqwsypHaT5tq3tkxr7FoPi6bNWC9mpDHWtlB0= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AM5PR0801MB2051; X-Microsoft-Exchange-Diagnostics: 1;AM5PR0801MB2051;31:ozxzxST+4s54Otl5otJN3kjRae2i2xb6OROycf25RAGHGhtc2SD2sM3sPq2e7cg4nT2Lc3SAZJvVcD4UrykOogbN9BVI0TQDvRNL+xI+KMBtYcTdGM7QDyO3W7klMZsGumyi6HLC0MROGYViNdjbkDP3pTw2+xSQWEIO5WNgPsmAzqaSb8jgU6WeTporckg3+tbNC0luJ1g+yR+mn2wKe5uIm6lGMtQxhz82/pE3dYu0oGXV0fRz5f2Iz3v+98jx;20:63Ik8p1bBC9/9iWWq50womZX51nVCDuvE7sH8Emm5KFSfJ9HTF/cSVGp3HNn+dBvmfOn3ZZRIGabtTeJ62goEn/MKnHuNpO7D6SM9B8KpyVQogfomVuis0xUh8aZiVpIxLn/6nX5k37DuBdLzygOKItW7U+ha8jj7w74xgVgLZ9rViDqclCzT+a3Iar9UA8nRGzgZCmlp1coZCX3DLOohXjyzd6rq5FZwW6wThXvqyWKIxpLXFcZCBvlNyy0/QSL X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(20558992708506)(211936372134217); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6043046)(6042046);SRVR:AM5PR0801MB2051;BCL:0;PCL:0;RULEID:;SRVR:AM5PR0801MB2051; X-Microsoft-Exchange-Diagnostics: 1;AM5PR0801MB2051;4:44wf3ajMVFgwpf+Zvtvhl1DcZ8NVFIEsTN+NhiYyBGqtjvZp1rSjCMubRwDq0aolambHxPQkUyG9DsspGAeqTqIUbs1TyqW/51NDiz3jZrFYGKYy001Rflf6umSxSm731qBtNE2R+G+da8yMOzhSI1rY0WZvsH22AHz+XCrr+NFcERlti8VRgdnSvGLZPIu3WCNGIBWfi50N29/NMqsLLLYhL0b+eb+ahR+FYzxYSEZnVb0kha5N+Q8RBApwEzRCtiRl/8zho0Sl0jiyFDfAD/qmBq3Y93iEEviEwR9BYhDFP0Q8D6jYgyeUDnQko59f5lePMyqtLYg4EYqS0zbgLZ+qicYukUTRV+KV4ps24p8zMUoFWUiXnZ2adDMYmzoTwXnLLfqj6bJjQoxwmPTgp7PA9xKQNzxiUFzpRd3xwfLm7AGrYBsZldP0Foh6EFLPT9i2eVTXdbToAx+Ke3oirLoz8wclGl/8MCrdf6Zie78GBZjcg4HoWPHHjMcl8hlV1bs5AMAzWyvrO/eR2YXrqw== X-Forefront-PRVS: 0121F24F22 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(7916002)(199003)(377454003)(24454002)(189002)(65956001)(305945005)(31686004)(7736002)(92566002)(7846002)(65806001)(2201001)(4326007)(5660300001)(81156014)(47776003)(105586002)(42186005)(77096005)(64126003)(33646002)(50986999)(2906002)(106356001)(6116002)(8676002)(54356999)(23746002)(76176999)(4001350100001)(36756003)(101416001)(3846002)(6666003)(66066001)(97736004)(189998001)(50466002)(5001770100001)(65826007)(586003)(83506001)(230700001)(31696002)(86362001)(68736007)(2950100002)(81166006)(2101003);DIR:OUT;SFP:1102;SCL:1;SRVR:AM5PR0801MB2051;H:[10.30.19.223];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;AM5PR0801MB2051;23:utdNjlBdLCaba1HCVjtJ3QCjvoTwCnk2vTA?= =?Windows-1252?Q?yJiHpCjurk7XyZVF9wYuNPzeXaF5f6ffrJuYdgKuELYGlRANNaCRt86S?= =?Windows-1252?Q?OjhhK59EeWRpdVihRVAWEcbp7muFFqVF5IKWXvKUQE1AfPmdT7ZifU1t?= =?Windows-1252?Q?hWcT3u4XZqmQVFQncuB0C7S18ykRLAXR9+2eq56dnYYrQNl/ZU6kvs8E?= =?Windows-1252?Q?avtZUAHvwAezd2hz2JPIQK/KTPJ+TEieAwHKzX24LF4Ev++ldJaOMy6I?= =?Windows-1252?Q?3hRA2m3JdqBOJyk2wayXKazNjoCfGvX/V2b7fCkW+k1p9B3I5K5AanxV?= =?Windows-1252?Q?2Df54rW+do44Es+Vg1D/uICxzkCJPczpB/Auy5cJuGNJviEW4imUEpX6?= =?Windows-1252?Q?w/GvdKoQ1MLRyExMqA2byAxeNBgtg1lOU2oDqIE/DOHz/Txiz2b4Dz4b?= =?Windows-1252?Q?D5JoAJhdL5fEpogOIxapCjrFvB3DF4q7NZuynSqVuiwe5HZjzqp80Bor?= =?Windows-1252?Q?y0/2VRKXmx/kZv/EG14UcdyCFEbZgGKgEVeFu9cd4oZ4hSGukd0iGcCQ?= =?Windows-1252?Q?ykllk+CkcfJUaQlRjk7zbbPD9fGfXbILFlsnki3Aw/zMuv/MEBHDhv1c?= =?Windows-1252?Q?6oyIZLS3y8+DKrCPtUy8B5tdIxblfEWQwdeuk356wC0AnwFKc5IRcval?= =?Windows-1252?Q?ldSOm08wOahTsBzXm29H1ZxYvVtx++v5dbOWZc0df9ZeuBUmBlkpJKyr?= =?Windows-1252?Q?aKmfJjvZahhoeRvYjmIuizMP8/Ebh4HRYPAwYxtQ99Nh4zGsO0I3EvkH?= =?Windows-1252?Q?OQYZLz4pnr3eMkw5eTc31LTcUDrTyosbBuJVO/emlC+VtoV1BqLamWBn?= =?Windows-1252?Q?yyrJGZ0ICGb5vkSMH5MqwgnpvzmVSep0uWELkMs5Z2kXqT+VikGXKIZm?= =?Windows-1252?Q?t2LLAuz+9SsaMAA0dT9cqffNdYdq0tImiyqs9FPbDmgHxec704lRut2P?= =?Windows-1252?Q?+rRCeA+Mbl/zUgAqmH+TLnMn+q2/DmowJcemxxwPFmw2lPmndnGBeKI0?= =?Windows-1252?Q?fLsY8NO9xBbJ5hPgjWJlzeY3YjA5EoNxjchB3AuNpazoo2NO4ohD9/xK?= =?Windows-1252?Q?6eaC9AY8pddYriT0yw9ga4G2WKHrb0be317aBM8z4ZkAFLHgUpGD8y4P?= =?Windows-1252?Q?2/7ddv7A9oXGtzZf6B6StM+hl4j5xBKAX5CwO8nWTql6Fr1bkalhRIUL?= =?Windows-1252?Q?4p0t4CgDGEqxP7V7jmEoFDy6oVhhDfwNhcSV3t7ejPG9ASZAMGOm0faJ?= =?Windows-1252?Q?tqREmeBqNLTXRw9dAmw7HJ40of0HrGnGIMtEirtIEC22NSyiUa2gdrAI?= =?Windows-1252?Q?CswWdZ33IPVmmYnEljt3Kz9e3UD9L2gkO+qD/WpXkFUsRo5XWV9nDp7k?= =?Windows-1252?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;AM5PR0801MB2051;6:/B/70gihZd18pOSIasfleEo6mNMSbPEzVkm3vkSGlWwSd0IJ+dedW1WXtijD81c6l9MZZb92Cb2XisZ4u0LgDfmEGRoZSOZJmdltIDeI4kuTu14mI0yBvI9D8nlXDcaawOH3wN56t2k9+M5a51Rv1YHZpPu3YlG04o5FfsXV0fB5hX5ig/6v0ikgJg+IeK8Ihbl2PpFAOoyiKOwUY3UnZb7yfBUhqZWsVNA2xCadhAOo3yRBw6UPAwN0lGRwaghwt+9iipoLVoDEG3lSRFwZuGGrPbJOyQ6xDusx6gMFNISq7AQpnVkZcNJFWE8Olmv3ke0xMMz0j1pfvfgEjWNMig==;5:g0RfZVSHrXIDPrc/ywXY2y6/AZqgADDvJyQofh08M887ZarRSabTpQmlSh9WBNA73SqEGbjFEqVn/MUjC/WKhyxdoVqcINSAsfg+88aECo9wYFBwwJgaOUj2dJFUYUO7gjeApaLkbTBEGVFdboL5IQ==;24:DMo1rcRzkF0hl0wmi9L5Gxuv7TTnb9X5bZM2X3r2JCv0ULCDCfI3xP87IRBGq4oNYmK7fcLh7sV7t2QK9x/cPB5DA2P+Dw/CgfHifHYYIlQ= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;AM5PR0801MB2051;7:wVgxkz9o1crm7YdHnEApuJD5GBwUreOTRL3swxlUP/CHvYOmeJ+3MK3K+HPwZZL1gl+2plwpsbqH0yg4XllKXU33/4KVwJykhhAW/Cwpeedp2NOV1LVIY86YuLW6dxbh65o7Kb7SsEIVqlFApMyGqfp4j583cHJVCXEPGKG6/uM+/NjCAGNk0QorCtM+v14UQ33x8FLcBz8eVheVJvram9bixpVlgbCa5fJPwa49NxFeO+Gmy4svh2zHtXF3p2PZ3aeC81VIt/HQ++rDhQvsamDc5BVDGIu850YNjq/1kFz0YwwIV3lmuhTaWE/N7cCbinqxvSqbWfep7+Iz1/oYu4iMLkrUwxTjT/mdJ8oPWIU=;20:0FUGqncACFWgrvpTniPeZkoVPhvl4slXyceTyLMgAI0fWL8AMsgp3V4HFi2Zul7rRBiX3pKuyFB32Pj+SE9I5F3hSFW4g0javZDd27epsvEH+D12aQShdkY7+8bhmpcFScx5JVFqg5+uw9E9ToXixIDDJtxpRf7ROusNJ4hh6/8=;23:78LVGTCObthhw500OD82Zex1iVMwb6qOoqGYsCW77rECjNjvoOUJkWtr2SPoJyvVkIp6wjLoym2SJhTbL9FmoUsLLaAksfdfCNqv1V8b2bsj59Vg6sFCqfCG0jkq8BJ3lCXT6dViY+VO7gT9gqoGxNX4Epgx7Rg5ydkNyrnTteoYwWyaL621wcn0OZI/VECd X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2016 16:23:00.7943 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB2051 X-OriginatorOrg: virtuozzo.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/08/2016 10:37 PM, Andrey Konovalov wrote: > 1. Change header format. > 2. Unify header format between different kinds of bad accesses. > 3. Add empty lines between parts of the report to improve readability. > 4. Improve slab object description. > 5. Improve mm/kasan/report.c readability. > Can you please do not dump everything in one patch? It only makes review process much more complicated. Please break it up into 'one patch per logical change'. > Signed-off-by: Andrey Konovalov > ---