From: Wei Huang <wei.huang2@amd.com>
To: Jiri Slaby <jirislaby@kernel.org>,
Jakub Kicinski <kuba@kernel.org>,
bhelgaas@google.com
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, helgaas@kernel.org, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com, asml.silence@gmail.com,
almasrymina@google.com, gospo@broadcom.com,
michael.chan@broadcom.com, ajit.khaparde@broadcom.com,
somnath.kotur@broadcom.com, andrew.gospodarek@broadcom.com,
manoj.panicker2@amd.com, Eric.VanTassell@amd.com
Subject: Re: [PATCH V1 1/2] bnxt_en: Add TPH support in BNXT driver
Date: Thu, 9 Jan 2025 13:09:52 -0600 [thread overview]
Message-ID: <f1f6af31-7667-4416-95d0-2f59c91a1b62@amd.com> (raw)
In-Reply-To: <68e23536-5295-4ae0-94c9-691a74339de0@kernel.org>
On 1/8/25 05:33, Jiri Slaby wrote:
> On 15. 11. 24, 23:04, Jakub Kicinski wrote:
>> On Fri, 15 Nov 2024 14:04:11 -0600 Wei Huang wrote:
>>> +static void bnxt_irq_affinity_release(struct kref __always_unused *ref)
>>
>> unused? you're using it now
>>
>>> +{
>>> + struct irq_affinity_notify *notify =
>>> + (struct irq_affinity_notify *)
>>> + container_of(ref, struct irq_affinity_notify, kref);
>>
>> this is ugly, and cast is unnecessary.
>>
>>> + struct bnxt_irq *irq;
>>> +
>>> + irq = container_of(notify, struct bnxt_irq, affinity_notify);
>>
>> since you init irq out of line you can as well init notify here
>>
>>> + if (pcie_tph_set_st_entry(irq->bp->pdev, irq->msix_nr, 0)) {
>>
>> You checked this function can sleep, right? Because rtnl_lock()
>> will sleep.
>
> Based on the above, I assume a new version was expected, but I cannot
> find any. So, Wei Huang, what's the status of this?
Currently the Broadcom team is driving the changes for upstream bnxt. I
will leave this question to them (Andy, Somnath, Michael).
>
> thanks,
next prev parent reply other threads:[~2025-01-09 19:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-15 20:04 [PATCH V1 0/2] Enable " Wei Huang
2024-11-15 20:04 ` [PATCH V1 1/2] bnxt_en: Add " Wei Huang
2024-11-15 22:04 ` Jakub Kicinski
2024-11-15 22:19 ` Michael Chan
2024-11-15 22:20 ` Bjorn Helgaas
2024-11-15 22:28 ` Andy Gospodarek
2025-01-08 11:33 ` Jiri Slaby
2025-01-09 19:09 ` Wei Huang [this message]
2025-01-09 19:17 ` Michael Chan
2024-11-15 20:04 ` [PATCH V1 2/2] bnxt_en: Pass NQ ID to the FW when allocating RX/RX AGG rings Wei Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1f6af31-7667-4416-95d0-2f59c91a1b62@amd.com \
--to=wei.huang2@amd.com \
--cc=Eric.VanTassell@amd.com \
--cc=ajit.khaparde@broadcom.com \
--cc=almasrymina@google.com \
--cc=andrew.gospodarek@broadcom.com \
--cc=asml.silence@gmail.com \
--cc=bhelgaas@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gospo@broadcom.com \
--cc=helgaas@kernel.org \
--cc=jirislaby@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=manoj.panicker2@amd.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=somnath.kotur@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®