From: "Paluri, PavanKumar" <papaluri@amd.com>
To: Borislav Petkov <bp@alien8.de>
Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Eric Van Tassell <Eric.VanTassell@amd.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
Ashish Kalra <ashish.kalra@amd.com>,
Michael Roth <michael.roth@amd.com>,
"H . Peter Anvin" <hpa@zytor.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH v3 1/2] x86, KVM:SVM: Move sev specific parsing into arch/x86/virt/svm
Date: Sun, 15 Sep 2024 04:42:45 +0530 [thread overview]
Message-ID: <f1f8e625-0771-4d25-cb1f-8949ad264954@amd.com> (raw)
In-Reply-To: <20240912112847.GGZuLQb4Z2Vvor5-JM@fat_crate.local>
Hello Boris,
On 9/12/2024 4:58 PM, Borislav Petkov wrote:
> On Thu, Sep 05, 2024 at 09:30:55AM -0500, Pavan Kumar Paluri wrote:
>> diff --git a/arch/x86/include/asm/sev-common.h b/arch/x86/include/asm/sev-common.h
>> index 98726c2b04f8..d3e7f97e2a4a 100644
>> --- a/arch/x86/include/asm/sev-common.h
>> +++ b/arch/x86/include/asm/sev-common.h
>> @@ -8,6 +8,9 @@
>> #ifndef __ASM_X86_SEV_COMMON_H
>> #define __ASM_X86_SEV_COMMON_H
>>
>> +#include <asm/cache.h>
>
>
>> +#include <asm/pgtable_types.h>
>
> What is that include for?
>
This include was a part of the diff you suggested when we had a
discussion on including only those headers that provide the definitions
for the functions we use. Here's the link to that diff:
https://lore.kernel.org/all/20240829132438.GCZtB2lqeYpleYk9c4@fat_crate.local/
I included the diff as-is and looked beyond for any more changes needed.
Should've taken a look at why the above headers were necessary.
Now that I see, <asm/pgtable_types.h> is not really needed here. While
<asm/cache.h> is needed for __read_mostly.
I will fix this for v4.
Thank you for raising this question.
- Pavan
next prev parent reply other threads:[~2024-09-14 23:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-05 14:30 [PATCH v3 0/2] nosnp sev command line support Pavan Kumar Paluri
2024-09-05 14:30 ` [PATCH v3 1/2] x86, KVM:SVM: Move sev specific parsing into arch/x86/virt/svm Pavan Kumar Paluri
2024-09-12 11:28 ` Borislav Petkov
2024-09-14 23:12 ` Paluri, PavanKumar [this message]
2024-09-05 14:30 ` [PATCH v3 2/2] x86 KVM:SVM: Provide "nosnp" boot option for sev kernel command line Pavan Kumar Paluri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1f8e625-0771-4d25-cb1f-8949ad264954@amd.com \
--to=papaluri@amd.com \
--cc=Eric.VanTassell@amd.com \
--cc=ashish.kalra@amd.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.roth@amd.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®