From: Dave Hansen <dave.hansen@intel.com>
To: Yuanhe Shu <xiangzao@linux.alibaba.com>,
jarkko@kernel.org, dave.hansen@linux.intel.com, tglx@kernel.org,
mingo@redhat.com, bp@alien8.de, hpa@zytor.com
Cc: x86@kernel.org, linux-sgx@vger.kernel.org,
linux-kernel@vger.kernel.org, kexec@lists.infradead.org,
challvy.tee@gmail.com
Subject: Re: [PATCH] x86/sgx: Skip EPC initialization in the kdump kernel
Date: Wed, 11 Nov 2026 07:06:41 -0800 [thread overview]
Message-ID: <f20043bc-87a1-4ce3-89aa-49fa1f2ff092@intel.com> (raw)
In-Reply-To: <20261111123942.3842771-1-xiangzao@linux.alibaba.com>
On 11/11/26 04:39, Yuanhe Shu wrote:
> + /* The kdump kernel has no use for SGX. Skip it. */
> + if (is_kdump_kernel())
> + return -ENODEV;
I'd much rather this be inverted: have the kdump code maintain a list of
things it needs to turn off rather than sprinkle is_kdump_kernel()
around any further.
I'd suggest a small bit of kdump specific code that does:
setup_clear_cpu_cap(X86_FEATURE_SGX);
It'll need to be in x86 code or under an x86 #ifdef.
prev parent reply other threads:[~2026-11-11 15:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 12:39 Yuanhe Shu
2026-11-11 15:06 ` Dave Hansen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f20043bc-87a1-4ce3-89aa-49fa1f2ff092@intel.com \
--to=dave.hansen@intel.com \
--cc=bp@alien8.de \
--cc=challvy.tee@gmail.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jarkko@kernel.org \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
--cc=xiangzao@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®